From: "Huang, Kai" <kai.huang@intel.com>
To: "Annapurve, Vishal" <vannapurve@google.com>,
"seanjc@google.com" <seanjc@google.com>
Cc: "jmattson@google.com" <jmattson@google.com>,
"mizhang@google.com" <mizhang@google.com>,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"dapeng1.mi@linux.intel.com" <dapeng1.mi@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 2/2] KVM: TDX: Disable pmu virtualization for TDX VMs
Date: Wed, 6 May 2026 23:56:09 +0000 [thread overview]
Message-ID: <3dc2300e50f655e261115099b416c6a1abbb9e9d.camel@intel.com> (raw)
In-Reply-To: <afvIuEuSYuktmtA2@google.com>
On Wed, 2026-05-06 at 16:03 -0700, Sean Christopherson wrote:
> The question then becomes, do we keep patch 1 and also clear enable_pmu in tdx.c,
> or do we keep the ordering and have kvm_arch_init_vm() consume has_protected_pmu?
> Neither one is particularly awesome :-/
Maybe keeping patch 1 is slightly better? This allows the vm_init() to toggle
all the values and flags that the default ones don't fit. If we go with latter,
when there's similar cases where we need more flags, then kvm_arch_init_vm()
needs to consume more flags.
This is also consistent with how KVM sets the existing kvm-
>arch.shadow_mmio_value: KVM sets the default in kvm_arch_init_vm() ->
kvm_mmu_init_vm(), and then TDX changes it to other values in tdx_vm_init().
next prev parent reply other threads:[~2026-05-06 23:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 1:41 [PATCH 0/2] KVM: TDX: Disable PMU virtualization for TDX VMs FirstName LastName
2026-05-05 1:41 ` [PATCH 1/2] KVM: x86: Move the default arch state init before vm_init() call FirstName LastName
2026-05-05 1:41 ` [PATCH 2/2] KVM: TDX: Disable pmu virtualization for TDX VMs FirstName LastName
2026-05-06 23:03 ` Sean Christopherson
2026-05-06 23:39 ` Vishal Annapurve
2026-05-06 23:56 ` Huang, Kai [this message]
2026-05-07 0:40 ` Vishal Annapurve
2026-05-07 14:24 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dc2300e50f655e261115099b416c6a1abbb9e9d.camel@intel.com \
--to=kai.huang@intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mizhang@google.com \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=vannapurve@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox