[PATCH bpf-next] bpftool: Remove llvm-strip from Makefile

[PATCH bpf-next] bpftool: Remove llvm-strip from Makefile

[Tao Chen]

As Quentin and Andrri said [0], bpftool gen object strips
out DWARF already, so remove the repeat operation.

[0] https://github.com/libbpf/bpftool/issues/161

Suggested-by: Andrii Nakryiko <andrii@kernel.org>
Suggested-by: Quentin Monnet <qmo@kernel.org>
Signed-off-by: Tao Chen <chen.dylane@gmail.com>
---
 tools/bpf/bpftool/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
index ba927379eb20..43bd826b0879 100644
--- a/tools/bpf/bpftool/Makefile
+++ b/tools/bpf/bpftool/Makefile
@@ -219,7 +219,6 @@ $(OUTPUT)%.bpf.o: skeleton/%.bpf.c $(OUTPUT)vmlinux.h $(LIBBPF_BOOTSTRAP)
 		-I$(LIBBPF_BOOTSTRAP_INCLUDE) \
 		-g -O2 -Wall -fno-stack-protector \
 		--target=bpf -c $< -o $@
-	$(Q)$(LLVM_STRIP) -g $@
 
 $(OUTPUT)%.skel.h: $(OUTPUT)%.bpf.o $(BPFTOOL_BOOTSTRAP)
 	$(QUIET_GEN)$(BPFTOOL_BOOTSTRAP) gen skeleton $< > $@
-- 
2.25.1

Re: [PATCH bpf-next] bpftool: Remove llvm-strip from Makefile

[Quentin Monnet]

2024-09-25 00:52 UTC+0800 ~ Tao Chen <chen.dylane@gmail.com>
> As Quentin and Andrri said [0], bpftool gen object strips
> out DWARF already, so remove the repeat operation.
> 
> [0] https://github.com/libbpf/bpftool/issues/161
> 
> Suggested-by: Andrii Nakryiko <andrii@kernel.org>
> Suggested-by: Quentin Monnet <qmo@kernel.org>
> Signed-off-by: Tao Chen <chen.dylane@gmail.com>

Acked-by: Quentin Monnet <qmo@kernel.org>

Thank you!

Re: [PATCH bpf-next] bpftool: Remove llvm-strip from Makefile

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Wed, 25 Sep 2024 00:52:02 +0800 you wrote:
> As Quentin and Andrri said [0], bpftool gen object strips
> out DWARF already, so remove the repeat operation.
> 
> [0] https://github.com/libbpf/bpftool/issues/161
> 
> Suggested-by: Andrii Nakryiko <andrii@kernel.org>
> Suggested-by: Quentin Monnet <qmo@kernel.org>
> Signed-off-by: Tao Chen <chen.dylane@gmail.com>
> 
> [...]

Here is the summary with links:
  - [bpf-next] bpftool: Remove llvm-strip from Makefile
    https://git.kernel.org/bpf/bpf-next/c/25bfc6333e32

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH bpf-next] bpftool: Remove llvm-strip from Makefile

[Daniel Borkmann]

On 9/25/24 11:50 AM, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
>
> This patch was applied to bpf/bpf-next.git (master)
> by Daniel Borkmann <daniel@iogearbox.net>:
>
> On Wed, 25 Sep 2024 00:52:02 +0800 you wrote:
>> As Quentin and Andrri said [0], bpftool gen object strips
>> out DWARF already, so remove the repeat operation.
>>
>> [0] https://github.com/libbpf/bpftool/issues/161
>>
>> Suggested-by: Andrii Nakryiko <andrii@kernel.org>
>> Suggested-by: Quentin Monnet <qmo@kernel.org>
>> Signed-off-by: Tao Chen <chen.dylane@gmail.com>
>>
>> [...]
I'll toss this shortly from the tree again, this missed that bpftool gen 
object call
needs to strip out dwarf.
>> Here is the summary with links:
>>    - [bpf-next] bpftool: Remove llvm-strip from Makefile
>>      https://git.kernel.org/bpf/bpf-next/c/25bfc6333e32
>>
>> You are awesome, thank you!

Re: [PATCH bpf-next] bpftool: Remove llvm-strip from Makefile

[Tao Chen]

在 2024/9/25 18:32, Daniel Borkmann 写道:
> On 9/25/24 11:50 AM, patchwork-bot+netdevbpf@kernel.org wrote:
>> Hello:
>>
>> This patch was applied to bpf/bpf-next.git (master)
>> by Daniel Borkmann <daniel@iogearbox.net>:
>>
>> On Wed, 25 Sep 2024 00:52:02 +0800 you wrote:
>>> As Quentin and Andrri said [0], bpftool gen object strips
>>> out DWARF already, so remove the repeat operation.
>>>
>>> [0] https://github.com/libbpf/bpftool/issues/161
>>>
>>> Suggested-by: Andrii Nakryiko <andrii@kernel.org>
>>> Suggested-by: Quentin Monnet <qmo@kernel.org>
>>> Signed-off-by: Tao Chen <chen.dylane@gmail.com>
>>>
>>> [...]
> I'll toss this shortly from the tree again, this missed that bpftool gen 
> object call
> needs to strip out dwarf.

Hi Daniel, i saw linker_sanity_check_elf will ignore the dwarf sec, 
which means bpftool gen object will strip, is my understanding correct?

static int linker_sanity_check_elf(struct src_obj *obj)
{
	...
	if (is_dwarf_sec_name(sec->sec_name))
		continue;
	...
}
>>> Here is the summary with links:
>>>    - [bpf-next] bpftool: Remove llvm-strip from Makefile
>>>      https://git.kernel.org/bpf/bpf-next/c/25bfc6333e32
>>>
>>> You are awesome, thank you!


-- 
Best Regards
Dylane Chen