From: He Ying <heying24@huawei.com>
To: <rmk+kernel@armlinux.org.uk>, <arnd@arndb.de>, <ardb@kernel.org>,
<akpm@linux-foundation.org>, <maninder1.s@samsung.com>,
<wangkefeng.wang@huawei.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm: Show real address of stack limit in __die()
Date: Mon, 27 Dec 2021 09:56:47 +0800 [thread overview]
Message-ID: <3df20137-3a0e-e22b-fccb-4dc7409406ec@huawei.com> (raw)
In-Reply-To: <20211202061916.204718-1-heying24@huawei.com>
Ping. Any ideas about this patch?
在 2021/12/2 14:19, He Ying 写道:
> Printing real address of stack limit makes debug easier.
> And system is dying, there is no security risk to show real
> address.
>
> Signed-off-by: He Ying <heying24@huawei.com>
> ---
> arch/arm/kernel/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c
> index 195dff58bafc..7d7c86d00482 100644
> --- a/arch/arm/kernel/traps.c
> +++ b/arch/arm/kernel/traps.c
> @@ -273,7 +273,7 @@ static int __die(const char *str, int err, struct pt_regs *regs)
> print_modules();
> __show_regs(regs);
> __show_regs_alloc_free(regs);
> - pr_emerg("Process %.*s (pid: %d, stack limit = 0x%p)\n",
> + pr_emerg("Process %.*s (pid: %d, stack limit = 0x%px)\n",
> TASK_COMM_LEN, tsk->comm, task_pid_nr(tsk), end_of_stack(tsk));
>
> if (!user_mode(regs) || in_interrupt()) {
prev parent reply other threads:[~2021-12-27 2:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 6:19 [PATCH] arm: Show real address of stack limit in __die() He Ying
2021-12-27 1:56 ` He Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3df20137-3a0e-e22b-fccb-4dc7409406ec@huawei.com \
--to=heying24@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox