From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11022112.outbound.protection.outlook.com [52.101.126.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 081ED445AF2; Thu, 13 Aug 2026 09:39:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786613973; cv=fail; b=kbj8E2hReynoFPvUMvGnKcukH5u7UIJLJLxbs2kT8UrEXC6i8UlXMYpfUJRYNn+e99hhhlCS99DCYxAKM1OpoUY5A5EIQuk7BvZcogYF32pf4do+Udk7CWeFmz69gjGoiX41tU/HGrZFvEOeRhDgiCFKuzynNt/WXXoBCAe2tQM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786613973; c=relaxed/simple; bh=ufgXk60n8TZ+kPESS4kvBmY4YY6g9EWl9upwAb9RwLI=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=aC8z1eDvE2UNFXCGqhsbrWe/Tl7XFEDRf1Zx8ucHi0+MNORTrpc2KN4ixNY9OzPomTO0RbIcsw4uJh/7oKJohyEImJ+0BSbIjxKhK50IxLYemEsxQDscKzAdDGyRk6lRqS/9MMFkSVDonqpcMdfYMzRSBK5cFpxDJ7UMQ/UuhvM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amlogic.com; spf=pass smtp.mailfrom=amlogic.com; dkim=pass (2048-bit key) header.d=amlogic.com header.i=@amlogic.com header.b=s9zimO/V; arc=fail smtp.client-ip=52.101.126.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amlogic.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amlogic.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amlogic.com header.i=@amlogic.com header.b="s9zimO/V" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fc2rCbIjvu1RBTlAUPcNsO/z8BMuxGt55h7QwUxkfqQv7PdArkdY7IZZpf7c66UyLnkpcs7gZsBiPaDm9edB/hq0V9L+UKxotjo4gv7Hzcn8NLNr0A/VKYsiqxaRJyIzPyAyCX2B8iQe3utTmkZLirj0gwpkIVhwk5JJWblAMDzrl7s9X2S5TKJMqpj7oVOVFeMR3nBQtn7pw0Cnzz+E0LJSchWDc1eWLfO4G4UsebhtMnbOyTzDF7KpWlCBLmR99ZyvHetDsftOQAT6XHeBmKQ5xZtOnIDIa29Lg1hvYN3VUxloU1lSyj+JfyV8CMsro7EMLtRHkdoNIT9qQjeetQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S/LQCbvOoVAWp9Q0pfWjKn07UIzYqfWb2erj+/83zyg=; b=xIPHmtthXFTAHv8wR39qPuok1guGUpN7CbPv3eNzEEO+Ly3UqcwyZk31ZorBpTIotD7aSqbg72W15B7y9Usl4OH6/NndTOVpXkqTR/AO8NH2PNhsPRXPUSF9KL5O17yQwGdHaYRmqzcbfGwrMbETLGitT+xHQH0JwTb2LYKBH6mTShgiye27FNPwL7gT6RJe2Dd3PJk4ofo+pMW/rnMHGVLm0GFi+LOMAEq19Zl4xOPdOEqOsR5jHkf6NkxZfMWjr4PlekhOuA86rTdyAFAI5Gwa77lKvDDansYT+xonmjlFmKeV7yjk9gMMTjbFvD5aAjug+I0ai030uh++Wc01cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amlogic.com; dmarc=pass action=none header.from=amlogic.com; dkim=pass header.d=amlogic.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amlogic.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S/LQCbvOoVAWp9Q0pfWjKn07UIzYqfWb2erj+/83zyg=; b=s9zimO/VNPIzm67dRlSmHVeI/aILexxyK0bOHedGLKixOVDW8ZF0m+PpvrTOXMRfVYfRhChV3ksq590mGw9AwBuN0n8hyVN90VLzui7OkkTe0J7S0YWHuTJl2+I5S2Gqpl1S3KskJhMHnS8lwKCWKtcVpTu+38ARsTjsfymNaUCjqHbjq5FfkhTXLC24w14J0Tk79AEssgz3G5KueKOezGx2HfX1uUeYb2YNGq+NAS2/Dvj11nALUDL43x+Usa8yTy7RDaxU/dnzaPsBfeWms6OQt1L5ZIj76Oe7ITexzLvU+N4oQcB2IGSzO+kArAey9YcQibUBtNS3PGJJ5bJVdg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amlogic.com; Received: from KL1PR03MB5521.apcprd03.prod.outlook.com (2603:1096:820:51::12) by SEZPR03MB7702.apcprd03.prod.outlook.com (2603:1096:101:10d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.14; Thu, 13 Aug 2026 09:39:28 +0000 Received: from KL1PR03MB5521.apcprd03.prod.outlook.com ([fe80::f12b:85e:f95c:191e]) by KL1PR03MB5521.apcprd03.prod.outlook.com ([fe80::f12b:85e:f95c:191e%3]) with mapi id 15.21.0315.014; Thu, 13 Aug 2026 09:39:28 +0000 Message-ID: <3e00b38c-70d2-452d-a71f-7e82d85fb610@amlogic.com> Date: Thu, 13 Aug 2026 17:39:24 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder To: Krzysztof Kozlowski Cc: Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org References: <20260812-b4-s4-vdec-upstream-v7-0-3fae085861bd@amlogic.com> <20260812-b4-s4-vdec-upstream-v7-3-3fae085861bd@amlogic.com> <20260813-rustling-sassy-terrier-11b99d@quoll> <80e58bd7-7eb7-4d05-b309-115643767a43@amlogic.com> From: Zhentao Guo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SE2P216CA0084.KORP216.PROD.OUTLOOK.COM (2603:1096:101:2c6::8) To KL1PR03MB5521.apcprd03.prod.outlook.com (2603:1096:820:51::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: KL1PR03MB5521:EE_|SEZPR03MB7702:EE_ X-MS-Office365-Filtering-Correlation-Id: bd930ed1-a58a-4379-65f3-08def91ec4d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|23010399003|22082099003|18002099003|56012099006|3023799007|11063799006|4143699003|10067099003; X-Microsoft-Antispam-Message-Info: 8MxGJo8rKeYJDXxLLm6KywEpE0pPoDsIT8D435M4tmPiV3OoP9bouRIL/54/qEdjqD249SKyr3g1D/IbPVS+Y5pNHKPP3GO+gZ9qhhxk4d9/ePEAGJIGf9ooF/mna/Kh710eqZbOn6LY4cdCh+DsoHKrud+7lYnhQbcyOPdsWExt2kqEwBsaIduwicQzjoGLIrFXXYlvUkQaHZ1njxdQ70mfPYpKPLjtIu47xI7sgw+Q6sCNPfTVfIFvsPveEQVh5fD5eHV2K5hZGWO0vIih9961HhUlhlpNB7wBo1hZ6OzNzqTNWmPQ0H4k2N+HH5OpDZabWAlmiv1DNb4pL8fxzXYUSmA+cGMFXKV3ATgOj5J03ZIX+bPS2QY0L5WkRK7n2sBW2+itXbWxx8wkFxXVkoiitBdkxVa1m/qD+lkaVWvKYcxJPReNr0n8RFqgCVPcAW+VthsB8hCFl/alVPceyZ/DrTHtS75KLq94ELY24UcCc15v2/5SV2g6XldIsYQyuHD2xSU0TNZ2msQswY0m2zHYm8T34Q+8+Bz3Bn+DMZA+LkZzDZjK/xp8xoP+Vll56N17BFYlBUs/uXQuYeuntFj6PmEit6+60lqFnnYN+J8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:KL1PR03MB5521.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(23010399003)(22082099003)(18002099003)(56012099006)(3023799007)(11063799006)(4143699003)(10067099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnpydHZ4NzdyUmcycVJ0Z0piYVY5eDJRbkZadFdDZXBKQWpqVWFwZlc1MzRr?= =?utf-8?B?aUlNU0dUM2YwU0NLSmNNMlNSMWVvNmR4enhWaEYrLytDWjhjYStMeEo2aFZG?= =?utf-8?B?MzYvdENXeTZ6UmRzcEtGSGhhWnJVQWFjblE3Q1RHbi9NYk9OSFk0N0FISGFu?= =?utf-8?B?RzJOYkVadkZHTFI3MGNsaStkL0tNNERBVTdic0crbVF6ZzU1TkhvUERoNlk2?= =?utf-8?B?bmo2VHNFYlVucXVHdDJtQmJiT0Q5V2FXSnlHZnZ2aCtqc3RSMXlCSXlLbTRu?= =?utf-8?B?Mk45MTJXUWRSUks4MHJhdFZqcGdvTUdNUHA0bHFwUUNlZkZGK1VQaFZrNWNl?= =?utf-8?B?ci9nMXdtems3VnRoRUpzQnpjL0J4STF4Z0N4UHJuQWdvRzhjQlV3WSt2WUJC?= =?utf-8?B?SmlKQU5GcjdvdmNmbnVsTU1vOWFXeDZDYWtOYVVTRlhKTENpSVhLSFR2YTBv?= =?utf-8?B?Ry90VFkwMzRGakN6bkZtT1FPTElySERVaU5YUDIvczMraE51YW4zTWVPajhR?= =?utf-8?B?YU5aWjhjM3J2bFlaMmRIVEZkRitaMlg3M0E3NG1icjg5MDVzM3FyakZxUGx5?= =?utf-8?B?RlRQZVVSYWNlNTVIQ3ZFb1ZQWjhDYTB6U0JZV3JJK01XR0lGVndxNng2M1JF?= =?utf-8?B?cElXTWR2N0xtM1BwSGdRanZLaVRLUHlXb1JHdlhZWVk5Vy9lWTV0MjhNcmNu?= =?utf-8?B?VjFyWjVVYTg0NUtHNjFYd0dyZ2J2NmFqL3RJZ21yUjlmOER4N2J3NEttalc0?= =?utf-8?B?Q2dDc0pxa0l0M01NUVVEaVFnak0yakxhSytDajNsYXh6QVJPYkFEeTVaTllC?= =?utf-8?B?TDY4VVdZZUhoWU9oNnFreC9VQVk5eER5MjJCQ25DcVUwZEVyWGhWKytldXJz?= =?utf-8?B?MWJaMnVTd0IzRTA4NEI2bURRVThsWmdhUFVhMmJBR05TYzgyU2lDS2F6RjVH?= =?utf-8?B?VjQ3WG5rWlBRdG80L3dYblozeEd4OWR3MDZiRjIremNvdXR1eEExaTFzZ3pH?= =?utf-8?B?bnh2THo1NTFRRW1pNWZTdS9ONnFWN3BLam5NOUNucHRHVHFweDMxb25sYkZV?= =?utf-8?B?ektzZ3I4RmxLYnR1Vyt4OHIyVkk4N1cyYjBUNFJoMU9TRlRjNGJZM3FjaXlF?= =?utf-8?B?bElUejZxZWdES2VZLyt0Lys4K0dFVXZrNE1pK0RtWHNmdjFCSnJ4MHFSTTZO?= =?utf-8?B?OWNvNUwxNVNBWVc3N094OW0ydnlkaEk0cXFzbUpSUFhPM2ljMThaamtSdFk4?= =?utf-8?B?enhzemdTM2cxeUl6RXRYcU9wbVd4R2FWN3NHdFJ5MG5KOUFpQzd4UkpjQkdZ?= =?utf-8?B?YjlEdWV5Q0lDNmhlMHR0VTBxSEp1Z3lQRlljNUkra1o5K0FmK2p2RHlKVE9X?= =?utf-8?B?MXR2a1VnRkR3NW5tNVBZWHFSNEJLNlBSMzZERkhDM0Vjby9URGRJRjhzY2Vy?= =?utf-8?B?aHl4Y3FpdER6MGhGNUM4S3cwSWRlMkgzMWdvRjM3Tk9mY0UwNFA1MUZYU1lH?= =?utf-8?B?SW1LVG4zbjNVK3REOXlUSzBDVERIeGpleHkrVEI2QmFEYThuTWI4N2R1bXVh?= =?utf-8?B?UzRlQkxqek45bU9nbmJibDR4WTIxSlZsam1HK0xxOEhva05lcTF1bUR4NUpQ?= =?utf-8?B?Mkh2dzZJMmptMFNEU3Q5WGdPeW1odlBnZTlDSlBHTnlzcGdkWGFQVVJSeFRY?= =?utf-8?B?NWdBSDBwaU5jdUlQNkN1emUyVzUzcHNPU2NoTUhQY1dvbWlJa0xWRjhVSGtH?= =?utf-8?B?WGQzQWdNb1BEazNpb09nUW1nREU0VHo3Z3EvTkRjS1VsdFNVRndQalJBOFRJ?= =?utf-8?B?SjNGV2cvdWhSYjNmVUNETnNzN3dWdGQ0YzI4bDRvdlYxK0F6ZitUQ0NuQTZm?= =?utf-8?B?QzR3V0hkdFFFNFJab2x1V0pZdTRqL0lqK0luSlR5V2FXNncwelI3SWVsT0tK?= =?utf-8?B?SnRtbi9KcC9jNkt5Y3JaeE9RL2dxZWp3MHYvVVdWMXVKMmErbnUyZGRKL3NG?= =?utf-8?B?aVgwSHY0QnNSYnkwNFEwaVdJZDBaWjNyYnZ1OGt0dmh2UDVpbDBWa0JWOHcr?= =?utf-8?B?bXFGMThyUkt4UXBhNlI3ajhHdnE5S0hoVlhHdGtCK09LMWwxaURrbXd4eHJX?= =?utf-8?B?MzVGYU80WHcvblRhS3d2ZFh2TE1vR3ZPdDZ4ZmZScnN4NisvVU5acHBEWHlE?= =?utf-8?B?M0pQajVaQ2h0N25mbmhFUkJWS0RWTFNqaDd4alBldTNKcHFCSVQ5OFZLQXpE?= =?utf-8?B?dFI1ZmxBUE14ZEJ3UTN3U1A0TXoxNm55QmIxMWQ1aGs2UnBMTHA5ckVqWkJI?= =?utf-8?B?dTBUYk5yY3dKM20xYURGd1NBaE1zZmhhYllEVzcyNi83U0VaQ3JTZz09?= X-OriginatorOrg: amlogic.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd930ed1-a58a-4379-65f3-08def91ec4d5 X-MS-Exchange-CrossTenant-AuthSource: KL1PR03MB5521.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2026 09:39:28.1934 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 10QPQXtx25XSdnOdYYUodYFLS/bcPdoEvSy33HTEOT+iL2BI5mimVhF4Gh5GkICInBMDLBQS0XGPNXJMjEZ7GA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR03MB7702 在 2026/8/13 17:22, Krzysztof Kozlowski 写道: > [ EXTERNAL EMAIL ] > > On 13/08/2026 10:39, Zhentao Guo wrote: >> Hi Krzysztof >> >>> On Wed, Aug 12, 2026 at 10:41:25AM +0800, Zhentao Guo wrote: >>>> Describe the initial support for the V4L2 stateless video decoder >>>> driver used with the Amlogic S4 (S805X2) platform. >>>> >>>> Signed-off-by: Zhentao Guo >>>> --- >>>> .../devicetree/bindings/media/amlogic,s4-vdec.yaml | 111 +++++++++++++++++++++ >>>> 1 file changed, 111 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml >>>> new file mode 100644 >>>> index 000000000000..b5af3f931b26 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml >>>> @@ -0,0 +1,111 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +# Copyright (C) 2025 Amlogic, Inc. All rights reserved >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/media/amlogic,s4-vdec.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Amlogic Video Decode Accelerator >>>> + >>>> +maintainers: >>>> + - Zhentao Guo >>>> + >>>> +description: >>>> + The Video Decoder Accelerator present on Amlogic SOCs. >>>> + It supports stateless h264 decoding. >>>> + >>>> +properties: >>>> + compatible: >>>> + const: amlogic,s4-vdec >>>> + >>>> + reg: >>>> + maxItems: 2 >>>> + >>>> + reg-names: >>>> + items: >>>> + - const: dos >>>> + - const: dmc >>>> + >>>> + interrupts: >>>> + maxItems: 2 >>>> + >>>> + interrupt-names: >>>> + items: >>>> + - const: hvdec >>>> + - const: vdec >>> vdec is the name of the module, so not really useful name. >> Ok, I'll come up with a new name and change it in the next revision. >>>> + >>>> + clocks: >>>> + maxItems: 3 >>>> + >>>> + clock-names: >>>> + items: >>>> + - const: dos >>>> + - const: vdec >>> Same here >> OK, but there would be a nit. In file >> drivers/soc/amlogic/meson-clk-measure.c, This clock source is also named >> *"vdec"*in|drivers/soc/amlogic/meson-clk-measure.c|, where a > Source does not matter. You do not describe here the source, but this > device. How is the input called in this device, not in the source? Yes, I get what you mean. >> *"vdec"*clock node is created in debugfs for checking its status. Using >> a different name in the driver (including DT and binding) would make it >> inconsistent with the debugfs node naming. > What inconsistency? How would provider name matter? This isn't actually a provider name either, it merely defines a debug node and names it "vdec". I dose not matter, I'll rename the clock in the device. > > Best regards, > Krzysztof BRs Zhentao