From: Markus Elfring <Markus.Elfring@web.de>
To: Jeroen de Borst <jeroendb@google.com>,
Ziwei Xiao <ziweixiao@google.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
Harshitha Ramamurthy <hramamurthy@google.com>,
Praveen Kaligineedi <pkaligineedi@google.com>,
Willem de Bruijn <willemb@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
John Fraker <jfraker@google.com>, Paolo Abeni <pabeni@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Shailend Chand <shailend@google.com>,
rushilg@google.com
Subject: Re: [PATCH net-next 5/5] gve: Add flow steering ethtool support
Date: Wed, 8 May 2024 16:09:00 +0200 [thread overview]
Message-ID: <3e10ff86-902d-45ed-8671-6544ac4b3930@web.de> (raw)
In-Reply-To: <20240507225945.1408516-6-ziweixiao@google.com>
…
> +++ b/drivers/net/ethernet/google/gve/gve_ethtool.c
…
> +static int gve_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd, u32 *rule_locs)
> +{
> + struct gve_priv *priv = netdev_priv(netdev);
> + int err = 0;
> +
> + dev_hold(netdev);
> + rtnl_unlock();
…
> +out:
> + rtnl_lock();
> + dev_put(netdev);
> + return err;
> +}
…
How do you think about to increase the application of scope-based resource management
at such source code places?
Regards,
Markus
next prev parent reply other threads:[~2024-05-08 14:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 22:59 [PATCH net-next 0/5] gve: Add flow steering support Ziwei Xiao
2024-05-07 22:59 ` [PATCH net-next 1/5] gve: Add adminq mutex lock Ziwei Xiao
2024-05-08 12:07 ` Markus Elfring
2024-05-07 22:59 ` [PATCH net-next 2/5] gve: Add adminq extended command Ziwei Xiao
2024-05-08 12:17 ` Markus Elfring
2024-05-11 14:32 ` Simon Horman
2024-05-07 22:59 ` [PATCH net-next 3/5] gve: Add flow steering device option Ziwei Xiao
2024-05-08 5:32 ` David Wei
2024-05-10 0:18 ` Ziwei Xiao
2024-05-08 5:34 ` [PATCH net-next 2/5] gve: Add adminq extended command David Wei
2024-05-10 0:17 ` Ziwei Xiao
2024-05-07 22:59 ` [PATCH net-next 4/5] gve: Add flow steering adminq commands Ziwei Xiao
2024-05-08 6:24 ` David Wei
2024-05-10 0:18 ` Ziwei Xiao
2024-05-20 17:27 ` David Wei
2024-05-08 13:23 ` Markus Elfring
2024-05-08 14:24 ` kernel test robot
2024-05-07 22:59 ` [PATCH net-next 5/5] gve: Add flow steering ethtool support Ziwei Xiao
2024-05-08 14:09 ` Markus Elfring [this message]
2024-05-10 0:19 ` Ziwei Xiao
2024-05-10 3:16 ` Jakub Kicinski
2024-05-10 6:45 ` Markus Elfring
2024-05-11 14:45 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e10ff86-902d-45ed-8671-6544ac4b3930@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=jfraker@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=pkaligineedi@google.com \
--cc=rushilg@google.com \
--cc=shailend@google.com \
--cc=willemb@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox