From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A75573A9DA6 for ; Tue, 31 Mar 2026 10:17:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774952229; cv=none; b=Wi8TtQwg5laMY6PUh3X2Uee8H/hYYj9RPKZuWOqn0QnxQOTbI3F+/2DZ68jYhTPCKtEEwIzRKSzCSxYm3oy/xSMwMS0AJ0Q5m+PC2QiXLVPPK/1MnA7vvrTHg2Gh5+RylRnuuQim6MZezYHkSvLvEfY7odhNU94IY4UJGnEfXck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774952229; c=relaxed/simple; bh=Zg4Ozx7Sg/VGDX3zwMxzagQpkXxbVKtpFM1Lw2PFmJ4=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=VMThwxOpDffaFUD4t3QJiMEG2ToI0zsz+CWjGiGqFmXadIfBGRgKVgK+9lVcuhD7o1SITeqi8P4unLt7b81QJIwKyZv6VrUDIDJmlr+6Hd9Q5ulV9cVZVOvsVG9XnuFpS4RUN4x8VgnyTf/Ubox7RtSnsAi+pXWTP7xqql1qjVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=loXJfLsl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PGrQRP62; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="loXJfLsl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PGrQRP62" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62V6xskc2164238 for ; Tue, 31 Mar 2026 10:17:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= N4pKfZf1Rj3Vm8qq6JVDSEPxGWYp4S4vfpw302SHdg4=; b=loXJfLsleyyK2lYk uUqEUWFp00l/vt2tn+U3wXTNfpw2JRYo4gzMgTuy6J0/uG8k+4PKq8OHAvufrzaJ 6y4BNNrQ6nmC3zp0zQXKTurNGkkcaM/r6N/Qkhed2fa1vlRN+Geqt5d6Q9YnUCyz G0yn1c50zJoKaXna701oSwDAnh7NOB+GySLqiO1brg+Gi2EdLRVYl+ZigbF8qRjr cR61pM7/rrvBRksOMRhy0QPPlxIsJBFzSI7SNSDlfQwezPlVuf+dg9BovZhsZxwD 60pDLZEkbp77A0gHRfkVlvAYKW6ZDkLB/3Yhke1+QkAfcEDe0M45BZrQSRkTYXmt N/He/w== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d89ga0ur4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 31 Mar 2026 10:17:07 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-89ccb129547so19242336d6.0 for ; Tue, 31 Mar 2026 03:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774952227; x=1775557027; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=N4pKfZf1Rj3Vm8qq6JVDSEPxGWYp4S4vfpw302SHdg4=; b=PGrQRP620wRXEKp+W1/3g972RGd2pe4HIna0rwNULUqEQUOMYtuhNG4guqMV6/I4Wz tE7PwbIPAcvNcGqiBxIiyuk2Lw/tHgPowqf+597yTXWLqBkvCNpTflBu3tUkE+n+VKIO gCBGfI2ImkI9OAqTFzWVERJyyPffR+tIBXeHVPmY0L/sygZ+umfXYpF2NDXVaR+9XMNn hUG9uFHUkb+yYfEWRfqqP4G2t2VJw4SxB4i8rC3rUPNl/dSH0NHR8DGD6UUfOQygbLeN 60qbXW9nhfeL4mKkaJ1R4sp0UID/BEXBQDci9+xmNHjC2hSqwAMAb58kE5aMh6Wf8h8o UZjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774952227; x=1775557027; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N4pKfZf1Rj3Vm8qq6JVDSEPxGWYp4S4vfpw302SHdg4=; b=GMl20+58auMhrUk0QE+r7Z+9kUmBZwrmuqcqz1Fo7n0SyMDTqNUN5/Ig9C+JNlo8tI P/Wm+g4gsJ18MNJblXquJcCwyW7mR4NISW0WaVopqVFoQnAVCYAGqJ6KVi/d0tt9XkLd 5OF9vgJpAf18LaipiqjN5VuPdi4S3Zb8NdB1FoyoddX6rjTDHGhGw4uv3sH8uOk9fi7E zoeH//Mw/SsFpZtRB1ctqRXC5Bj8WoSmonfTtn+Su7fepo53BRQ84rPgNaq7/6FTbiR3 OW7rgYpID/YM042pOEJkbnSJZZURvIHnX568kUk1RAecIeLL87v4ta3WBSDthzN5u2cT CVeg== X-Forwarded-Encrypted: i=1; AJvYcCXM5wEHTaV6OZAQJwxps+f0YO4vnFsjGCrTTzo2XFyAQM44DTkCcIVp8MxGq0/OaXsbQUHSasWA1VsmAnc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3LiLhD4t8d2pHts7YzFD8GuRx+uUyJGb8tvZ8TsK/+zxOLUS+ yvWPtX/K+D7Dru4IHHoJxB5Ti20/fHB/VkkE2LeEa0KMsJdDTn7Vtup55//H/UK56T9803sR15w 58ZPLk/v+nC37eeT7eCc5rZHikD+K0NFETMAVzL7qgLU9ArouAdIQ7ePAQrANOfVUZCA= X-Gm-Gg: ATEYQzxiB+Vgo44PrNWa9KYSGI4TivcXel7w9WaIHcPAy+px9VkI0s3a+k9xHljbcz6 EZMDTIyPB5Cdh0AISmaA/O7t5AaMfuiNjy1MEzz4lWodS6ImG/AsxmPpwCCqahP0VbBSbVqaZh/ NFvU/mFIJSobJdZnCk15/r4QiVYP4JWiFA64EAdSHoTSc5fmXBe57TXnGKlehUOcmCI31e279Hy yxZMKOX0hNjP8iuHUTEC8obGkvruNF5DX7b1+hsmqEEn6Gy4nFm6GDIzCnx1t4UFM2t2jJKchLF 1tk9fS/lJgzbtRN7h0PbVZsC2wpcYvUF4v2oJ42LFT4DSQ880pnGOdqck1Q6Mbjxifrzhmyd7pf WXJ9zc/tGqF5QP95SVgwyw5uGIGcLZ6QetFccCPkXG9D4grWFNyweds/mWcOBVNq+2H9BfAWuwy iTqbM= X-Received: by 2002:a05:6214:27cb:b0:89a:45d4:4e42 with SMTP id 6a1803df08f44-89ce8f96a82mr171653096d6.5.1774952226925; Tue, 31 Mar 2026 03:17:06 -0700 (PDT) X-Received: by 2002:a05:6214:27cb:b0:89a:45d4:4e42 with SMTP id 6a1803df08f44-89ce8f96a82mr171652776d6.5.1774952226451; Tue, 31 Mar 2026 03:17:06 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b7b1a6744sm377853566b.30.2026.03.31.03.17.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 03:17:05 -0700 (PDT) Message-ID: <3e3428e2-b07e-4d65-9cb4-afad1a943bb5@oss.qualcomm.com> Date: Tue, 31 Mar 2026 12:17:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] clk: qcom: Constify qcom_cc_driver_data To: Krzysztof Kozlowski , Bjorn Andersson , Michael Turquette , Stephen Boyd , Maxime Coquelin , Alexandre Torgue , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <20260331091721.61613-3-krzysztof.kozlowski@oss.qualcomm.com> <6ca492d7-c041-42b0-8f41-cd29ab7b4bab@oss.qualcomm.com> <51a05279-1759-4c03-8bba-835a9e972ccb@oss.qualcomm.com> <445a53e3-f467-40fc-9b01-dc776555c3fb@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <445a53e3-f467-40fc-9b01-dc776555c3fb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=KJpXzVFo c=1 sm=1 tr=0 ts=69cb9f23 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=y-Wd9Zd1aYVehlAUloYA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-GUID: 0Ht9ytFEbeHU9J0YHRljC1o7-vyhteMI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMxMDA5OCBTYWx0ZWRfX2z+taI+3ZDPv LcuoJ1tbGdbnrUmMTSBDnyoMaM3HppzB9s32Y4u8jLXzmf/e0we0D1lxPrvG3eIodGpjysL+w75 LAKsA3rf9OVR4YKqmHVdKe5n/p4mhDQdWGSyXWMcCVi7I5/n9Vs6nY6MM7P7z5dgPseq8PrnV9E gzvvwMVEuKN58hTKltbQTHvS9aWR7GWwXMhPWC02TSx0P0KQwMp2uwqE+qBrvA8ya+24W6TjkAl yLHQsOmJPlxu5h8bz2U+VS6s+WbWHXtrRDk3VWFUwG8TCxGerNXTywPUKYthe/Cvg5A03Hr1YCA 35fgLy/UC/roGqwKbX362Ajq/e7gyEmRF+3IXowsbS90qw0X1vJJqdQwwwzfCVx4jnxfmGk7SaJ LDJe8ZgpwBj/y5jKixR/Uo0/rdsPzXxYWFbZQBPw59f2h1hHvEQPNQ20xvvZfNzSHLCsmlz+rnI d6MxLERCE9dx3OSKjyg== X-Proofpoint-ORIG-GUID: 0Ht9ytFEbeHU9J0YHRljC1o7-vyhteMI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-31_02,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 adultscore=0 spamscore=0 suspectscore=0 malwarescore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310098 On 3/31/26 12:13 PM, Krzysztof Kozlowski wrote: > On 31/03/2026 12:10, Konrad Dybcio wrote: >> On 3/31/26 12:09 PM, Krzysztof Kozlowski wrote: >>> On 31/03/2026 11:33, Konrad Dybcio wrote: >>>> On 3/31/26 11:17 AM, Krzysztof Kozlowski wrote: >>>>> The static 'struct qcom_cc_driver_data' contains probe match-like data >>>>> and is not modified: neither by the driver defining it nor by common.c >>>>> code using it. >>>>> >>>>> Make it const for code safety and code readability. >>>>> >>>>> Signed-off-by: Krzysztof Kozlowski >>>>> --- >>>> >>>> [...] >>>> >>>>> --- a/drivers/clk/qcom/common.h >>>>> +++ b/drivers/clk/qcom/common.h >>>>> @@ -49,7 +49,7 @@ struct qcom_cc_desc { >>>>> size_t num_icc_hws; >>>>> unsigned int icc_first_node_id; >>>>> bool use_rpm; >>>>> - struct qcom_cc_driver_data *driver_data; >>>>> + const struct qcom_cc_driver_data *driver_data; >>>> >>>> This can be a const ptr to const data, even >>> >>> None of other elements in 'qcom_cc_desc' is const pointer, even though >>> they also could. If doing this change, let's make it consistent - so >>> shall all of them be const? >> >> I thought about it, but then it turns out that videocc-sm8550.c has: >> >> video_cc_sm8550_driver_data.clk_cbcrs = video_cc_sm8650_critical_cbcrs >> >> So we'd have to duplicate the entire struct > > No, that's not a problem. Pointer is not modified and we speak here > about const pointer. Right, I already had constifying the various struct members in mind Konrad