Re: [PATCH v2 1/7] arm64: dts: ti: k3-pinctrl: Add WKUP_EN flag

[Kendall Willis <k-willis@ti.com>]

On 8/27/25 14:14, Kendall Willis wrote:
> On 8/12/25 04:15, Markus Schneider-Pargmann wrote:
>> WKUP_EN is a flag to enable pin wakeup. Any activity will wakeup the SoC
>> in that case.
>>
>> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-pinctrl.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-pinctrl.h b/arch/arm64/boot/ 
>> dts/ti/k3-pinctrl.h
>> index 
>> c0f09be8d3f94a70812b66c3f91626aac35f4026..d3b0ecdf1a4a4de25ee6121ec9e62d1c7df26eb9 100644
>> --- a/arch/arm64/boot/dts/ti/k3-pinctrl.h
>> +++ b/arch/arm64/boot/dts/ti/k3-pinctrl.h
>> @@ -19,6 +19,7 @@
>>   #define DS_OUT_VAL_SHIFT    (26)
>>   #define DS_PULLUD_EN_SHIFT    (27)
>>   #define DS_PULLTYPE_SEL_SHIFT    (28)
>> +#define WKUP_EN_SHIFT        (29)
>>   /* Schmitt trigger configuration */
>>   #define ST_DISABLE        (0 << ST_EN_SHIFT)
>> @@ -65,6 +66,7 @@
>>   #define PIN_DS_PULLUD_DISABLE        (1 << DS_PULLUD_EN_SHIFT)
>>   #define PIN_DS_PULL_DOWN        (0 << DS_PULLTYPE_SEL_SHIFT)
>>   #define PIN_DS_PULL_UP            (1 << DS_PULLTYPE_SEL_SHIFT)
>> +#define WKUP_EN                (1 << WKUP_EN_SHIFT)
>>   /* Default mux configuration for gpio-ranges to use with pinctrl */
>>   #define PIN_GPIO_RANGE_IOPAD    (PIN_INPUT | 7)
>>
> 
> Reviewed-by: Kendall Willis <k-willis@ti.com>

FYI: A series by Akash [1] has been picked in linux-next. It includes 
the WKUP_EN macro but defined differently as PIN_WKUP_EN. The series 
needs to be rebased to account for that macro.

[1] https://lore.kernel.org/all/20250909044108.2541534-1-a-kaur@ti.com/

Best,
Kendall Willis