From: Marek Vasut <marek.vasut@gmail.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Icenowy Zheng <icenowy@aosc.xyz>,
Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 06/15] mtd: nand: kill the MTD_NAND_IDS Kconfig option
Date: Wed, 4 Jan 2017 16:10:17 +0100 [thread overview]
Message-ID: <3e5f31dd-c577-faf4-b186-bfdd5498e526@gmail.com> (raw)
In-Reply-To: <1483448495-31607-7-git-send-email-boris.brezillon@free-electrons.com>
On 01/03/2017 02:01 PM, Boris Brezillon wrote:
> MTD_NAND_IDS is selected by MTD_NAND, which makes it useless. Remove the
> Kconfig option and link nand_ids.o into the nand.o object file.
> Doing that also prevents adding an extra nand_ids.ko module when MTD_NAND
> is activated as a module.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
> ---
> arch/cris/arch-v32/drivers/Kconfig | 1 -
> drivers/mtd/nand/Kconfig | 4 ----
> drivers/mtd/nand/Makefile | 3 +--
> 3 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/arch/cris/arch-v32/drivers/Kconfig b/arch/cris/arch-v32/drivers/Kconfig
> index 2735eb7671a5..b7cd6b9209a9 100644
> --- a/arch/cris/arch-v32/drivers/Kconfig
> +++ b/arch/cris/arch-v32/drivers/Kconfig
> @@ -136,7 +136,6 @@ config ETRAX_NANDFLASH
> bool "NAND flash support"
> depends on ETRAX_ARCH_V32
> select MTD_NAND
> - select MTD_NAND_IDS
> help
> This option enables MTD mapping of NAND flash devices. Needed to use
> NAND flash memories. If unsure, say Y.
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 353a9ddf6b97..69f9b03c372e 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -13,7 +13,6 @@ config MTD_NAND_ECC_SMC
> menuconfig MTD_NAND
> tristate "NAND Device Support"
> depends on MTD
> - select MTD_NAND_IDS
> select MTD_NAND_ECC
> help
> This enables support for accessing all type of NAND flash
> @@ -109,9 +108,6 @@ config MTD_NAND_OMAP_BCH
> config MTD_NAND_OMAP_BCH_BUILD
> def_tristate MTD_NAND_OMAP2 && MTD_NAND_OMAP_BCH
>
> -config MTD_NAND_IDS
> - tristate
> -
> config MTD_NAND_RICOH
> tristate "Ricoh xD card reader"
> default n
> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
> index 19a66e404d5b..bfd5d12b9ade 100644
> --- a/drivers/mtd/nand/Makefile
> +++ b/drivers/mtd/nand/Makefile
> @@ -5,7 +5,6 @@
> obj-$(CONFIG_MTD_NAND) += nand.o
> obj-$(CONFIG_MTD_NAND_ECC) += nand_ecc.o
> obj-$(CONFIG_MTD_NAND_BCH) += nand_bch.o
> -obj-$(CONFIG_MTD_NAND_IDS) += nand_ids.o
> obj-$(CONFIG_MTD_SM_COMMON) += sm_common.o
>
> obj-$(CONFIG_MTD_NAND_CAFE) += cafe_nand.o
> @@ -61,4 +60,4 @@ obj-$(CONFIG_MTD_NAND_BRCMNAND) += brcmnand/
> obj-$(CONFIG_MTD_NAND_QCOM) += qcom_nandc.o
> obj-$(CONFIG_MTD_NAND_MTK) += mtk_nand.o mtk_ecc.o
>
> -nand-objs := nand_base.o nand_bbt.o nand_timings.o
> +nand-objs := nand_base.o nand_bbt.o nand_timings.o nand_ids.o
>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2017-01-04 19:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 13:01 [PATCH v4 00/15] mtd: nand: allow vendor specific detection/initialization Boris Brezillon
2017-01-03 13:01 ` [PATCH v4 01/15] mtd: nand: get rid of the mtd parameter in all auto-detection functions Boris Brezillon
2017-01-04 14:53 ` Marek Vasut
2017-01-03 13:01 ` [PATCH v4 02/15] mtd: nand: store nand ID in struct nand_chip Boris Brezillon
2017-01-04 14:57 ` Marek Vasut
2017-01-03 13:01 ` [PATCH v4 03/15] mtd: nand: get rid of busw parameter Boris Brezillon
2017-01-04 14:59 ` Marek Vasut
2017-01-03 13:01 ` [PATCH v4 04/15] mtd: nand: rename nand_get_flash_type() into nand_detect() Boris Brezillon
2017-01-04 15:01 ` Marek Vasut
2017-01-04 17:03 ` Boris Brezillon
2017-01-03 13:01 ` [PATCH v4 05/15] mtd: nand: add manufacturer specific initialization/detection steps Boris Brezillon
2017-01-04 15:07 ` Marek Vasut
2017-05-01 21:02 ` Brian Norris
2017-05-02 9:04 ` Boris Brezillon
2017-01-03 13:01 ` [PATCH v4 06/15] mtd: nand: kill the MTD_NAND_IDS Kconfig option Boris Brezillon
2017-01-04 15:10 ` Marek Vasut [this message]
2017-01-03 13:01 ` [PATCH v4 07/15] mtd: nand: move Samsung specific init/detection logic in nand_samsung.c Boris Brezillon
2017-01-04 15:14 ` Marek Vasut
2017-01-04 17:08 ` Boris Brezillon
2017-01-06 23:53 ` Marek Vasut
2017-01-07 7:49 ` Boris Brezillon
2017-01-10 19:00 ` Marek Vasut
2017-01-11 7:57 ` Boris Brezillon
2017-01-11 13:02 ` Marek Vasut
2017-01-03 13:01 ` [PATCH v4 08/15] mtd: nand: move Hynix specific init/detection logic in nand_hynix.c Boris Brezillon
2017-01-03 13:01 ` [PATCH v4 09/15] mtd: nand: move Toshiba specific init/detection logic in nand_toshiba.c Boris Brezillon
2017-01-03 13:01 ` [PATCH v4 10/15] mtd: nand: move Micron specific init logic in nand_micron.c Boris Brezillon
2017-01-04 15:15 ` Marek Vasut
2017-01-04 17:13 ` Boris Brezillon
2017-01-04 17:22 ` Marek Vasut
2017-01-04 17:58 ` Boris Brezillon
2017-01-04 21:20 ` Marek Vasut
2017-01-03 13:01 ` [PATCH v4 11/15] mtd: nand: move AMD/Spansion specific init/detection logic in nand_amd.c Boris Brezillon
2017-01-03 13:01 ` [PATCH v4 12/15] mtd: nand: move Macronix specific initialization in nand_macronix.c Boris Brezillon
2017-01-03 13:01 ` [PATCH v4 13/15] mtd: nand: samsung: retrieve ECC requirements from extended ID Boris Brezillon
2017-01-03 13:01 ` [PATCH v4 14/15] mtd: nand: hynix: rework NAND ID decoding to extract more information Boris Brezillon
[not found] ` <3073151483449433@web27m.yandex.ru>
2017-01-03 13:32 ` Boris Brezillon
2017-01-03 13:01 ` [PATCH v4 15/15] mtd: nand: hynix: add read-retry support for 1x nm MLC NANDs Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e5f31dd-c577-faf4-b186-bfdd5498e526@gmail.com \
--to=marek.vasut@gmail.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=icenowy@aosc.xyz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox