public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Meir Elisha <meir6264@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Ruan Jinjie <ruanjinjie@huawei.com>,
	Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Staging: rtl8723bs: checkpatch fixes for rtw_mlme.c
Date: Mon, 29 Jan 2024 21:04:23 +0100	[thread overview]
Message-ID: <3e67441a-aafa-403e-b332-c58c5fa75e30@gmail.com> (raw)
In-Reply-To: <20240129141856.416532-1-meir6264@Gmail.com>

On 1/29/24 15:18, Meir Elisha wrote:
> Checkpatch fix series for rtw_mlme.c
> 
> Meir Elisha (4):
>    Staging: rtl8723bs: Remove unnecessary braces
>    Staging: rtl8723bs: Remove extra spaces
>    Staging: rtl8723bs: Fix block comments warning
>    Staging: rtl8723bs: fix else after break warning
> 
>   drivers/staging/rtl8723bs/core/rtw_mlme.c | 241 ++++++++++------------
>   1 file changed, 114 insertions(+), 127 deletions(-)
> 

Hi,

please also fix:

CHECK: From:/Signed-off-by: email comments mismatch: 'From: Meir Elisha 
<meir6264@gmail.com>' != 'Signed-off-by: Meir Elisha <meir6264@Gmail.com>'


In Patch 4/4
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit 
description?)

Please issue a V2 with changelog.

Thanks

Bye Philipp

      parent reply	other threads:[~2024-01-29 20:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29 14:18 [PATCH 0/4] Staging: rtl8723bs: checkpatch fixes for rtw_mlme.c Meir Elisha
2024-01-29 14:18 ` [PATCH 1/4] Staging: rtl8723bs: Remove unnecessary braces Meir Elisha
2024-01-29 14:18 ` [PATCH 2/4] Staging: rtl8723bs: Remove extra spaces Meir Elisha
2024-01-29 15:05   ` Dan Carpenter
2024-01-29 14:18 ` [PATCH 3/4] Staging: rtl8723bs: Fix block comments warning Meir Elisha
2024-01-29 15:06   ` Dan Carpenter
2024-01-29 14:18 ` [PATCH 4/4] Staging: rtl8723bs: fix else after break warning Meir Elisha
2024-01-29 15:08   ` Dan Carpenter
2024-01-29 20:04 ` Philipp Hortmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e67441a-aafa-403e-b332-c58c5fa75e30@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=meir6264@gmail.com \
    --cc=ruanjinjie@huawei.com \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox