From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01A2F21772B for ; Wed, 12 Feb 2025 16:09:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739376546; cv=none; b=UOCbCuCKZKJNxVhncNZjLoBBzHR3ykeMA1w7NBaav/PaUh2gf9CGWuNBNpDfcURDtiL6tgtRErbSOjghXbUMAePiNv/29pbI7P0b6eJhfKzgmN3UKmE5vjE24MYsTP7npO0XHg+6zKj41XuJVLQO5TYfRvEjyWyWxJhPqUvEEgM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739376546; c=relaxed/simple; bh=ZKwXTXROh5P6mHKTAIdz8QlhSs8YJUr+oi3VUfVQJLU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eV095Xo6K4hXVfYWnIwziz60gnBaNhPS2sLbOHf/YF3oYf3sjNMLccuCbIvsML1gbGWdBLDRi6BjoX+cP92p/Lg5Zk97A5m/URfzY2DmGTSG2s2K9ezqw7l3fEI4iMBE+vbrEOC+RFHfPdF3Z+O8RqXPyU4NXzarFXFAadhmmJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uiDQTNEl; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uiDQTNEl" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43955067383so13957065e9.0 for ; Wed, 12 Feb 2025 08:09:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739376543; x=1739981343; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pp5odaFIrW+nbf7Y7JXnx1TjySVWjHWY+ZwKogul8A0=; b=uiDQTNElQR2FMi/AeJIdiJq5RzPZLAbvhcW2IHHckGiuIvw+R6tYloFqcnW9jmKCUd PwIIv5lK0v6x90sm8QnkalU4y7wbQ//B5Z4rUT8hWxht4oHnjOjcS5scriGCIpZT+oEs EiYn8j3CWiBHRhF5dgs3VT+LsZPzyyIyRFP4jCLWvKGEipuUAvFAtaq700KqDiUVNL1P Tr8nHNS7ad2hxq4i/8sS5Jxw4lnyzW57PRzX4ImvV6DkSL8X4HXp3A6fkYsSce8tVQX2 1WMcG/cevucrHOo7nkbQtudZyGP7KBl2mTJNJ6fHVpqbLsb7jFbhEaP9beuKvmFFFPtj o0Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739376543; x=1739981343; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pp5odaFIrW+nbf7Y7JXnx1TjySVWjHWY+ZwKogul8A0=; b=gabWwULS/PJ8Fnyohv3ONIbBoD1ixLk576dgca56Qyv8CcEQLaxW1VWoyr9Va+slUk pWERkNBPslN96gCGrTXx6qa6pImOEe9DvaQZm8gu0FmhnrgqytxYSLB/wfTpfa1VkvQu iUtxOLchIzHmkSzRl2eoTdWtrJTkU5iuA6YktyE+pVquBu1tVgAE56FnATxQvM2+1DSn cf66oyGcER961Mx8/6LWxMDQQG6jGYqltji75LONL4HrwYXRBpZCMhoUDdADsot+e7ha /lq85Azk+0cdHBlVEhT1HJc1JXfkr/Pj+9j3KN+1At+7m6YBT+VcFsXcE1blf1NJ19AA zoIA== X-Forwarded-Encrypted: i=1; AJvYcCXM98fy9A2Ld182o+DVPh5aOgqWCfReWFD/0sh1g5bD7u9SFYWv2bSBGyaUThizeA1MiushaBGWzGlehng=@vger.kernel.org X-Gm-Message-State: AOJu0Yzepe8Igta7P7ucMDsH/1wqZlBw9wvmTciMZPjWXq/Tky3oGxD0 fx5Zdm3HFmizAFY+RHktew8Xoc4nlLC0NBEaS3lRyaBU1rD02he4qNYnxrJD2bs= X-Gm-Gg: ASbGncsn72I4UoaVr7VkFg7CqFNZq++RazeH6YA/LfnXhWXoD+2TaIL8tHoCZi9J2aR luqawNZDraCA1sPUGEedLn+UNpBiAv/ueBE8dpR2FXLZRcmwwrqcprUkFDzr2IGyvPFm3iaeRNl Fd8++B+4VbzejgOJr1dblIoKhb9lmGJ0DJudsg7Rl632TIH1FZM3vZ25sc4181aS5l67x75xSyK 1FjYm1AygRy97cOskwmiXJXGdoPlY+f+rBzQeKHzJ3jNDRffiPcTuSe/OZLk2KZLeVvFtMK43eE upamVx9LxHoNsNIPGuyvkJzPPF+K9rgorbRMxc4leh59xnPxWaIuz9OUztixzgfxPU8sCA== X-Google-Smtp-Source: AGHT+IHJzNcgMxYRPCB+0fE/E++AfEevWhqdpHHpCa2FP4tYjZxOsQp8n228+Yo/EzeDt2qB6MDYHw== X-Received: by 2002:a05:600c:1548:b0:436:1b08:4c78 with SMTP id 5b1f17b1804b1-43959a997a5mr31660955e9.31.1739376543290; Wed, 12 Feb 2025 08:09:03 -0800 (PST) Received: from ?IPV6:2a0a:ef40:1d11:ab01:416b:3913:893e:bb4? ([2a0a:ef40:1d11:ab01:416b:3913:893e:bb4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4395a1aa7f3sm24236205e9.29.2025.02.12.08.09.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Feb 2025 08:09:02 -0800 (PST) Message-ID: <3e8d6cb7-43e3-4375-94be-c6b28331da76@linaro.org> Date: Wed, 12 Feb 2025 16:09:01 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] regulator: qcom_usb_vbus: Add support for PMI8998 VBUS To: Mark Brown Cc: "James A. MacInnes" , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, andersson@kernel.org, konradybcio@kernel.org, quic_wcheng@quicinc.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lgirdwood@gmail.com References: <20250212010744.2554574-1-james.a.macinnes@gmail.com> <20250212010744.2554574-3-james.a.macinnes@gmail.com> <8ec05fd8-1623-457f-a3b5-1095acd62cf7@sirena.org.uk> Content-Language: en-US From: Caleb Connolly In-Reply-To: <8ec05fd8-1623-457f-a3b5-1095acd62cf7@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/12/25 15:37, Mark Brown wrote: > On Wed, Feb 12, 2025 at 03:29:54PM +0000, Caleb Connolly wrote: > >> I would suggest implementing a proper .is_enabled op to poll the status >> register for OTG_STATE_ENABLED and configuring > > No, that would be buggy. Implement a get_status() operation if the > device can report status. is_enabled() should report what the driver > asked for. Ahh yep, that's right. it should implement .get_status() (as per the polling code in _regulator_do_enable()). -- Caleb (they/them)