From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030324AbdAECdo (ORCPT ); Wed, 4 Jan 2017 21:33:44 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34342 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752239AbdAECdl (ORCPT ); Wed, 4 Jan 2017 21:33:41 -0500 Subject: Re: [PATCH 1/2] mfd: micon: Add Buffalo Kurobox Pro, Terastation II Pro/Live driver To: Lee Jones References: <20161229000137.5553-1-f.fainelli@gmail.com> <20161229000137.5553-2-f.fainelli@gmail.com> <20170104112227.GA27589@dell> Cc: linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, gregory.clement@free-electrons.com, andrew@lunn.ch, jason@lakedaemon.net, linux-kernel@vger.kernel.org From: Florian Fainelli Message-ID: <3e9b7bfe-8305-64fc-f175-e612576d58a7@gmail.com> Date: Wed, 4 Jan 2017 18:26:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170104112227.GA27589@dell> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 01/04/17 à 03:22, Lee Jones a écrit : > On Wed, 28 Dec 2016, Florian Fainelli wrote: > >> This driver is currently only used to reboot the devices, but the >> microcontroller hanging off UART1 on the Buffalo Kurobox Pro and >> Terastation II Pro/Live is capable of a lot more than that, which we >> will support in subsequent patches. For now, just add the reboot >> functionality to make the kernel reboot correctly. > > This is not an MFD driver. You have written a UART driver. > > Please relocate it to drivers/char/tty/serial. Not that simple, and as explained in the cover letter the UART attached micro controller can do a lot more than just reboot the machine, but someone else is working on the driver, so this patch series can be ignored. -- Florian