From: 黄少波 <huangshaobo3@xiaomi.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Ahmed S. Darwish" <darwi@linutronix.de>,
Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: 李高鹏 <chenwei29@xiaomi.com>, 梁伟鹏 <weipengliang@xiaomi.com>,
翁金飞 <wengjinfei@xiaomi.com>, 熊亮 <xiongliang@xiaomi.com>
Subject: Subject: [PATCH] pci/msi: remove redundant calculation in msi_setup_msi_desc
Date: Fri, 18 Aug 2023 07:26:38 +0000 [thread overview]
Message-ID: <3ebf5d8032ad418da4f24516cd23406e@xiaomi.com> (raw)
Whether to support 64-bit address status has been calculated before,
and the calculation result can be used directly afterwards, so use
msi_attrib.is_64 to avoid double calculation.
Suggested-by: weipengliang <weipengliang@xiaomi.com>
Signed-off-by: sparkhuang <huangshaobo3@xiaomi.com>
---
drivers/pci/msi/msi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c
index ef1d885..304e889 100644
--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -303,7 +303,7 @@ static int msi_setup_msi_desc(struct pci_dev *dev, int nvec,
desc.pci.msi_attrib.multiple = ilog2(__roundup_pow_of_two(nvec));
desc.affinity = masks;
- if (control & PCI_MSI_FLAGS_64BIT)
+ if (desc.pci.msi_attrib.is_64)
desc.pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_64;
else
desc.pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_32;
--
2.7.4
#/******本邮件及其附件含有小米公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件! This e-mail and its attachments contain confidential information from XIAOMI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!******/#
next reply other threads:[~2023-08-18 7:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 7:26 黄少波 [this message]
2023-08-18 8:30 ` Subject: [PATCH] pci/msi: remove redundant calculation in msi_setup_msi_desc Ilpo Järvinen
2023-08-23 14:15 ` Thomas Gleixner
2023-08-24 7:27 ` huangshaobo3
2023-08-24 9:04 ` Thomas Gleixner
2023-08-24 10:52 ` sparkhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ebf5d8032ad418da4f24516cd23406e@xiaomi.com \
--to=huangshaobo3@xiaomi.com \
--cc=bhelgaas@google.com \
--cc=chenwei29@xiaomi.com \
--cc=darwi@linutronix.de \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=weipengliang@xiaomi.com \
--cc=wengjinfei@xiaomi.com \
--cc=xiongliang@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox