From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0826B1FC0F7 for ; Sat, 15 Mar 2025 13:43:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742046218; cv=none; b=daxk92rvgsZVDtooLC3bTTZ1LbJ3Loa2BNXWTnmIN3/hUvqVPQTXyy3BKmsF8GFkAffd+ta3JEulfI55WSK4clgSc6L8Z3smpov5BHm5bDguSFxkg6foVDQmPs42RX9rQURgqcNLu2At6kWTp3PdfHeKXF42L7FdfIj5SNIdTFg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742046218; c=relaxed/simple; bh=JVuh+mhc/FwpTmDaaZmTnWUK0YVL4MNTJLdpJeZnUw0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Cu3LJix+nMvMqCmQR+1GA0Xeig5+wndmK8zvQmqNXHuzmlQgHC/9DsfBKyND/2R6jU+SrVGK63I45tMcdmQuW6v6RnxT4ERPu8O/xcFrnj7jXZ6nYDH9GyOAqRx8W/LCI103xWyiKuyQr4e/i1BYdFzMyUqjmT/J+IoJuURZQg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LmgEhgos; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LmgEhgos" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52F4gDZG011140 for ; Sat, 15 Mar 2025 13:43:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YHgAsLdlTbAsNFH5Qo9LSY7aWOa7CrR7kjhEOgV/rqI=; b=LmgEhgosFjWf4/+C oFTo8vKFXXjr7sCc65R2x0nvqpSAJFzh1JSUFH7tmJq1QO764OYVm9zOekCe+kz7 grTBdzB+XN3pLpnlCm8dXSuHbSaIsdU/8zBzJwoi7U2pplhNiel8dk9xDmT2zCQv f7ovh0E113129mp8+FdigxPzHzTh5aHFLKyOXg/Fhiq+wghUQWWL5RR72I8zst78 v7SJGjjiEmnch8HEuGGJcM4lu9STbEEU5NrFcMO3hoA4dzcHcg8yY3MIqykBxoRC IZRuhtyS62X7CKrS3cHSHxwMPg0MQ1AGNuUVHGilz7pq99daf1rfUADq/FVgqRJO 0nl9yg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45d1u88rn2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 15 Mar 2025 13:43:35 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7c56e672b71so12014785a.2 for ; Sat, 15 Mar 2025 06:43:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742046214; x=1742651014; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YHgAsLdlTbAsNFH5Qo9LSY7aWOa7CrR7kjhEOgV/rqI=; b=MTkEZtZQ5OJ7uJBoPpNsLr5bm4DpsXMgnQ+fMAsE4/svqgozEsYnEo3xxvz8LT2v4Y WV3mJYS9hZBr2Iv4xmGR7+IlEmAQOluw474ZyAPN9tjs4vAodGvDAbVUGcGl6iqhf/p+ 7A3fdOfo5rUkMkDljG1244EJLEM5x4Lf6vn58Mx07E2sbO9D7BX7T3H8C85udvkrhbuy M8yJd4lDclIRjjwN+/+w0kpAq67Q7upKjzNwWCdLHlGYw9NXZpsK7NCyaD3lSGCLNV70 N3+XoFnKJPbUmNP6Zvy4nfMNDIv33CWIzsI0x/EUpigq9XZxREIR6rGidGz/cY7KRI8b 2tCg== X-Forwarded-Encrypted: i=1; AJvYcCXESw7D5UfQ/5gxB4UzU4N4Nv7S9BD3Uie+cKz0E92v3yLqPq1j8PgiIFs67YVbnRQYc5DFkrZJuiwasXg=@vger.kernel.org X-Gm-Message-State: AOJu0YwiJ8j4l8k4SgXPYX+suN231b1bmhGYTlZLEA7xIWJqvcJWg2Oy q8VS0BAMDyujVTbpyT5f+3QTHDNf4z5p4V8fi3dEqGO33cLuHzs3c6AOUaiFF8pwWS0KFhwY8GB EcND1u3vseE9+R/mx9rJzJxR9lFlVshUQfq2E0WBSYGJ650GkCz3PkVE3zeLWi0w= X-Gm-Gg: ASbGncvvECYmWiWUXzaphOarg97BPpyGXpqV6FPw6VLYPPwK2WKz/lo/oXzcCz0JmwJ 27KnbbCOR2AIQmO2GOQF7TItLOO81xBtnByUrlMcRG6NGPCVpMM07eG5GuQzy6kloepFHCDF2WU bYR+MN/PL4KkjTb0hfA4zP4f0sBFYaYKUySeQ8N+qlTfjV30nJD45hbn/j0ZmpdaFTrmskE7FDt 8qkhsDPfOt5vkiBo5l+ufYLdXfjSGp7aEhvrlRqmrIp+iH8LQbE35i1needOtzGoTT6uvkP8Plx 4Mv+WLsF8MluL/Ekz1ZkLLlD+ZV5iYARXwL9HR54KbQ8nBQVOmKBNWVSE/TDsIXsuC0FvA== X-Received: by 2002:a05:620a:2410:b0:7c3:c340:70bf with SMTP id af79cd13be357-7c57c931333mr349094785a.14.1742046214637; Sat, 15 Mar 2025 06:43:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGS2nqxwW8/paMLInQIBoFDddr15kcIeLrw4iAy+U7F4I0nXMeEk8ATlZcPQydgmcJFGW3Efg== X-Received: by 2002:a05:620a:2410:b0:7c3:c340:70bf with SMTP id af79cd13be357-7c57c931333mr349093085a.14.1742046214233; Sat, 15 Mar 2025 06:43:34 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e8169b04dasm3363342a12.37.2025.03.15.06.43.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Mar 2025 06:43:33 -0700 (PDT) Message-ID: <3ec71075-b1ef-4366-b595-80fe41cd1e13@oss.qualcomm.com> Date: Sat, 15 Mar 2025 14:43:30 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: qcom: sa8775p: add support for video node To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250311-dtbinding-v1-0-5c807d33f7ae@quicinc.com> <20250311-dtbinding-v1-3-5c807d33f7ae@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250311-dtbinding-v1-3-5c807d33f7ae@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: l2ZM9sAczEBjnQYuEGRwNERxBMyrTxFi X-Authority-Analysis: v=2.4 cv=c42rQQ9l c=1 sm=1 tr=0 ts=67d58407 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=COk6AnOGAAAA:8 a=o0DAOHxMhK4SEvgiHlYA:9 a=m1fupbwp798LcsAA:21 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: l2ZM9sAczEBjnQYuEGRwNERxBMyrTxFi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-15_05,2025-03-14_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 mlxscore=0 adultscore=0 malwarescore=0 impostorscore=0 mlxlogscore=999 priorityscore=1501 suspectscore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503150097 On 3/11/25 1:03 PM, Vikash Garodia wrote: > Video node enables video on Qualcomm SA8775P platform. > > Signed-off-by: Vikash Garodia > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 67 +++++++++++++++++++++++++++++++++++ > 1 file changed, 67 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 3394ae2d13003417a15e64c9e47833725ec779e6..09db8e2eb578f1cada0f4a15e3f844dc097bd46d 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -3783,6 +3784,72 @@ llcc: system-cache-controller@9200000 { > interrupts = ; > }; > > + iris: video-codec@aa00000 { > + compatible = "qcom,sa8775p-iris"; > + > + reg = <0 0x0aa00000 0 0xf0000>; > + interrupts = ; > + > + power-domains = <&videocc VIDEO_CC_MVS0C_GDSC>, > + <&videocc VIDEO_CC_MVS0_GDSC>, > + <&rpmhpd SA8775P_MXC>, > + <&rpmhpd SA8775P_MMCX>; > + power-domain-names = "venus", > + "vcodec0", > + "mx", > + "mmcx"; > + operating-points-v2 = <&iris_opp_table>; > + > + clocks = <&gcc GCC_VIDEO_AXI0_CLK>, > + <&videocc VIDEO_CC_MVS0C_CLK>, > + <&videocc VIDEO_CC_MVS0_CLK>; > + clock-names = "iface", > + "core", > + "vcodec0_core"; > + > + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS > + &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ALWAYS>, This path should use QCOM_ICC_TAG_ACTIVE_ONLY on both endpoints > + <&mmss_noc MASTER_VIDEO_P0 QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; > + interconnect-names = "cpu-cfg", > + "video-mem"; > + > + firmware-name = "qcom/vpu/vpu30_p4_s6.mbn"; If it needs different firmware, I have my doubts over why 8550's data would be fully reused. Are you sure everything in iris_platform_sm8550.c applies? > + memory-region = <&pil_video_mem>; > + > + resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>; > + reset-names = "bus"; > + > + iommus = <&apps_smmu 0x0880 0x0400>, > + <&apps_smmu 0x0887 0x0400>; > + dma-coherent; > + > + iris_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-366000000 { > + opp-hz = /bits/ 64 <366000000>; > + required-opps = <&rpmhpd_opp_svs_l1>, > + <&rpmhpd_opp_svs_l1>; > + }; Please add a newline between subsequent subnodes Konrad