From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DDAE3B47D1 for ; Fri, 3 Apr 2026 11:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775217543; cv=none; b=M1xC1bAjUGNElQrGpX5VxQ/XmGWKGMGQPmgYia8vykr5thW4MOD91YdZK5rRzAHatoCFwbAh5GviDs2xmP23LTuX6uiOrlcaK5ew2QwvvMcI88eI2d92Pg2Fo875xicEI+eUekZ9e11NG03Fhl6bYOu5838QGKxVjqK0TDOm8z4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775217543; c=relaxed/simple; bh=VdDqFLBRGI8N+m3XIIgjgCnSsQ+lqeTBaslDzgYOLLI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E85SGsuoo2Tz3/83MfbS/vzfonuACzWIFxWPpwTCEcSG5REZf8gl/MBSaOwg5i1xZtl4wRI+llDSCuVEPavPofhUzNvcce8zcf056OANZDeCuMgSuhYNsOFH6KnzhAeD76OFcDNuv9Fukx6UIMxPh5/yCnM2pILIszsanrrUO7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hekn4g0r; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K4mHRrHx; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hekn4g0r"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K4mHRrHx" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6336F2AI141818 for ; Fri, 3 Apr 2026 11:59:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Y6FSfCNss0WGbrLRmtEKpCH49PaDXVZ75wV9fa1v334=; b=hekn4g0rkwY8LM+u xixae2WYCWWnPmKBpBPD37o1iiyjkeYhBMdU8ClC37SVPcu556dCdNICvKFdodV2 jzgek+Sisymt4CMeQ6REC9eRHHwHXZ06Yey/KkgTKGmqlh7GSGiZOnro7QIVolPo 2EwtM7qrskk9u4h3KhCS/T22M4l7qytyN603PGA4K5wlrIHD/Hj9gsHbUGBvY7YX Tp4Kucse8b+1eM5lDNyeLNc1eH0VNf9NUBg+fY0N1GMx0KWTrNmQv070zO5NXZoF +09dPVIsav1F3rQHj2uL1Qoe+OwCiEWdj15CTwLwZWxlHk7T7QAlgvae5YDKv0B6 haL6vw== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4da83y0xda-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Apr 2026 11:59:02 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82c7a84a43eso3064051b3a.0 for ; Fri, 03 Apr 2026 04:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775217541; x=1775822341; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y6FSfCNss0WGbrLRmtEKpCH49PaDXVZ75wV9fa1v334=; b=K4mHRrHx+SxdjTfdK5FrrWV77UjdBMpFL/4RMrOzeQMgqTR2VdIvcG1FzuqkJ2iH7g Iz99Is7SuTJ3hzPyVMjcDUjY0p4Ov7Gf4Q8nqnji+j8yt/L5rpvInTji8iVAEVW9XFEC j3pxRFcmD30EO5Nvlq0aCxSKZhWGWE6/L37DZFi27okXYbpJWrZws9VShKFtJMYJ1gSA xjfsvpEdGjqhUF33bIjTudF1DQ9+1hC4WzpbRDWn2wD7TmOUilr5ZBzNAphnlM82+ui9 SwPOkNt755Tz383nrvdIFCYzTY4nm46k428XtV+A8Cv8ABCm4lw4R87EIoTRGXtfgJp6 tWdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775217541; x=1775822341; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y6FSfCNss0WGbrLRmtEKpCH49PaDXVZ75wV9fa1v334=; b=VpjsyF3yqKoH9HOibQvO8EwAJsP5Y/OjKvtDA3pssQ5wzNBTr6XlVffIO9HLnsJBcW K5aNR+pXDmysScJsaT+5t22hx1JzqM5dAmUNF6owBqs9DcCw3XO3JOnRuKuIFaFlWEFH T3D97r7n71SWDqiKrXrHMgdGgDUbBxH9ffYeD6p48K8kbuEncdOkAEN3VfRqmLnKngEd VkhI3THX1FM0F1dGg+dEpPhn3oiVmXAaYdvaUvYgmKMN+CpPOKRnlI+/w+nAsGN6es10 DKYxKaBk72rHmYPHY4uEhGxQ0vQ3hjwwrfB+STVE1p6BLoQbGNdsKkVbZ6ZtM0DqdjXI yTxg== X-Forwarded-Encrypted: i=1; AJvYcCUePWf94DHqXdm9gOYOdzs46hDQJYQEX99Bx14mHCivKkzzpnwDDLEDh0EojXch5eC4dma2RrmXD2nQ0R0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywxe+QOGwmThBEi6co/xGp+/e2K1kc/6S/R21KjKdCuMA5KNBDr wRE/M1rmqNGw33cR/5PEhL1gEbBjQmUWNYmQNcUyZijEyNOhfWU1AqwfIplAGG2M+SCI1TPbz9G OeDgH2rhTrOHHNM0morOrC5W7YhRQj3HMM+unlGmc7PpJy5EfYAj9rMAWTilgjBgykMA= X-Gm-Gg: AeBDiesGptRWzE56AEW9jWsjfYYrpiQ+OLSLxIIKLQtLFmOmIApQtI9pQIeBD/I/vxw CgeILnz+5ZxzqZb8mIl0iT4Gg3Da9/qzKYtdzZT4hosIoJPKFMcQoH6/pEFDBZkDQhqNnz2Fgpm 2YS8XoyFTJEQ4I5eVpsCTYULMkrVPNtR1+lXGbyYA8+0t5K8rEQ0oTJcXtW6A18DzwidIahGoaf Jx15FBBzGt0GItE+5SQVkxRtMF+q/D3i3+gADK8DqQpoi1ExiS8bi0mgqOk7+rHp+dzy6z4IM81 VvHK8F/AyPhkNzgIMP5r9fr1Cn2iSbfdyU0OHwYDHJGgxZy3XUtgvO0rSBhqauf5X22sn1Wjp5P 0bVlndoBzCRrPjYhhxQeYTC3zZp186SLqKvGtb+DmKeeT5Ugz+yM= X-Received: by 2002:a05:6a00:181b:b0:82a:687e:c048 with SMTP id d2e1a72fcca58-82d0db7e13dmr2833569b3a.30.1775217541341; Fri, 03 Apr 2026 04:59:01 -0700 (PDT) X-Received: by 2002:a05:6a00:181b:b0:82a:687e:c048 with SMTP id d2e1a72fcca58-82d0db7e13dmr2833545b3a.30.1775217540848; Fri, 03 Apr 2026 04:59:00 -0700 (PDT) Received: from [10.92.178.97] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9c747fdsm5780678b3a.50.2026.04.03.04.58.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2026 04:59:00 -0700 (PDT) Message-ID: <3eeeb94d-a8ce-43e2-bdd6-642e36cb277e@oss.qualcomm.com> Date: Fri, 3 Apr 2026 17:28:56 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 1/2] ufs: core: Configure only active lanes during link To: Bart Van Assche , mani@kernel.org, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, shawn.lin@rock-chips.com, nitin.rawat@oss.qualcomm.com References: <20260327090346.656324-1-palash.kambar@oss.qualcomm.com> <20260327090346.656324-2-palash.kambar@oss.qualcomm.com> Content-Language: en-US From: Palash Kambar In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=ar6/yCZV c=1 sm=1 tr=0 ts=69cfab86 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=8rK0MGtTfqIXTTsz8cQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: uaqEcuGQBZskTwgFbMZP_-eqt4lb3RMl X-Proofpoint-GUID: uaqEcuGQBZskTwgFbMZP_-eqt4lb3RMl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAzMDEwNSBTYWx0ZWRfX4Rg5nbBaMAJS /RZGfEcD1eO/YJCbgaka/WadphzZhFcW1jUW/+nM9ffym3XVBG+Lk+mBHjtStZBu+yX+5eIRWwH +ZOth5M9l+v92r/OpnTyKwMznu/uRWcw4zow/zeqlxL/IzEadJSHX+Da9/Mjzkrpgznthx2+O5g OX7+MnY52tWIfqW7C90iWZ2j5yAgtTtZxnKDTC5cHfJ1UG25rngJTi93VFTkr/mGmVmtezjd15t BdV7O544O1q6FBDHqgnWhSrEY86qCtpMPd21TtPRWrNJYt+HbBjkYvvOdw0HAlOVGQ2RnYiZYAJ 9gdnLLhzchOBXqcspFbv0CansmkHp5DsCk8E2STYDCrq3/NtUb96l9ynnZMCItRqY/wJhMlKY4Q jHWegHHP2bY2AneftAE5cktOziYENQ6j4TxR7K8wSyoXauaW0FZZ3cC+UyV0b83TeNjQrMH/rnI vXQo4fXznRjXZJgFM9A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-03_03,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 malwarescore=0 phishscore=0 spamscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604030105 On 3/28/2026 2:47 AM, Bart Van Assche wrote: > On 3/27/26 2:03 AM, palash.kambar@oss.qualcomm.com wrote: >> +static int ufshcd_validate_link_params(struct ufs_hba *hba) >> +{ >> +    int ret = 0; >> +    int val = 0; > > Both initializers are superfluous. Please remove at least the > initializer for "ret" since the first statement in this function assigns > a value to "ret". > >> +    ret = ufshcd_dme_get(hba, >> +                 UIC_ARG_MIB(PA_CONNECTEDTXDATALANES), &val); > > The formatting of the above statement does not follow the Linux kernel > coding style. Please format it as follows: > >     ret = ufshcd_dme_get(hba, UIC_ARG_MIB(PA_CONNECTEDTXDATALANES), >                  &val); > > A possible alternative to formatting code manually is to run something > like "git clang-format HEAD^" from the command line. > >> +    val = 0; > > This assignment is superfluous, isn't it? > >> +    ret = ufshcd_dme_get(hba, >> +                 UIC_ARG_MIB(PA_CONNECTEDRXDATALANES), &val); > > Please move the UIC_ARG_MIB() to the previous line. > > Thanks, > > Bart. Sure Bart, will address these comments.