The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Zhihao Cheng <chengzhihao1@huawei.com>,
	linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
	Ben Hutchings <ben.hutchings@mind.be>,
	Daniel Golle <daniel@makrotopia.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] ubi: ubi_init: Fix missed ubiblock cleanup in error handling path
Date: Thu, 11 Apr 2024 18:43:27 +0200	[thread overview]
Message-ID: <3eef0167-5dd3-443d-80aa-f450a75550df@web.de> (raw)
In-Reply-To: <20240411031903.3050278-3-chengzhihao1@huawei.com>

…
> Since ubiblock_init() registers notifier and invokes notification
> functions, so we can move it after ubi_init_attach() to fix the problem.

I find this change description improvable.
Would an imperative wording be also more desirable here?

Regards,
Markus

  parent reply	other threads:[~2024-04-11 16:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11  3:18 [PATCH v2 0/4] ubi: Fix serious of resource leaking problems Zhihao Cheng
2024-04-11  3:19 ` [PATCH v2 1/4] ubi: ubi_init: Fix missed debugfs cleanup in error handling path Zhihao Cheng
2024-04-11  3:19 ` [PATCH v2 2/4] ubi: ubi_init: Fix missed ubiblock " Zhihao Cheng
2024-04-11 15:48   ` Daniel Golle
2024-04-12  1:20     ` Zhihao Cheng
2024-04-11 16:43   ` Markus Elfring [this message]
2024-04-11  3:19 ` [PATCH v2 3/4] mtd: ubi: Ignore all debugfs initialisation failures Zhihao Cheng
2024-04-11  3:19 ` [PATCH v2 4/4] ubi: debugfs: Replace IS_ERR_OR_NULL with IS_ERR in error checking path Zhihao Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3eef0167-5dd3-443d-80aa-f450a75550df@web.de \
    --to=markus.elfring@web.de \
    --cc=ben.hutchings@mind.be \
    --cc=chengzhihao1@huawei.com \
    --cc=daniel@makrotopia.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox