From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7615437A3E6 for ; Thu, 18 Dec 2025 16:01:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766073680; cv=none; b=ZAWyziPz/YMN8RrdV5zMUIgncNjW0tFbYGjALMs+kaf0QRdDXfpZ+RPwswBezg8gcxYy8Hck0uniPAgU0isQSHTLMJhDPHt8Le1X0AEWd06xT1+XXmMskjKQavG8tc3qBTMm5TNAqWVWMzZj17nmUjfF8cIaab/avULdLxGPwg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766073680; c=relaxed/simple; bh=tfGgeolmEeMub3msQoiEs35SHiGJUXuzVfjUZB+vOIM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nv2Bnv7iCtjMvb/uVqlfIITaQZ39eRj5JaXMo2EIQ8jJmXVkD1iPtgAgxAzBOGYtPS7zLa/aqsk+2dqBiKpkaHT+3EHaLlkN/RvrU884smKuOFSCFPW4IeTTjnlLMmsCoZhvHxWRT+zbfPo0XxfbNTohSqI+opT22O/TLkNI5l8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SEBSD81X; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SEBSD81X" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-3f0ec55ce57so536337fac.2 for ; Thu, 18 Dec 2025 08:01:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766073677; x=1766678477; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uuAkrD2lct9S73QpH6jqf1LLFy31o/vRAKZaXLJid4Y=; b=SEBSD81XSGg5OusDDrFvmOJ80CDPf1LipzVLhmQK/frzY2B5pJoG7QFIwnhrU7y33v aZX33M8ZoZW4enPDTNTNEoOv4pxOZvVFzCdKTql8gnZaXuljEiMnZ7aiy4C4XnKnPzTi +NbeKC0sptS24l61zsxkpqajHlq/YSAkqcTPZmvdPRnaWdIurVtMypqPXhbcTGiMTLnp vcOuQyj15iTNS1azZopSwbFPOMABnBPRmBiW/0PWB3LpI/zkhxWn/LYZ3rMeXPqBN1km xBhUgw7L7+slKN7nfUGTeG1iul3Y6bt7Dl4SElvXZuucG8UtqEcEBgFDHhTqy8j4204z VAHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766073677; x=1766678477; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uuAkrD2lct9S73QpH6jqf1LLFy31o/vRAKZaXLJid4Y=; b=xG+wTfIY37RItxO9taUiJupNKjA5Ks/5W672Mu2KAF9W48+3GTvUjdnqX/elSbmCW0 yR9A6CJmhe0ZNWjGHdNfZ8VpUCAOeUMWtZy4hUOoWM9FzdM4liqJxDXjQD238CdBtf3H xIHiyCezlSoEsRglooFYpspyEm5W6LGVbUTtOX9Rg6zSTMEYcCqR+UDp4f5jw7eaoVJJ T1+mJy6PuO9XaBzvHgQeBd/cRnqcxPRsvqHlkvpfpRs75hXNpNHbec0KjWLGZWWgx821 ZX0kdOjZ+74RSg9q4uwv7dg6s5gNd/ThN0zLzip7FMKfbcgEiRqTB5X4Ja20z5dv2gsd WjMA== X-Forwarded-Encrypted: i=1; AJvYcCWii/w9T8GTwHGzuP9gy7/R50201tIHyz3eJLMNCeGOtp3uQULqR/4zFNbt3NORteSGfOejfH7Ql89yt/4=@vger.kernel.org X-Gm-Message-State: AOJu0YwvArFNVtTGjllZc5e24rlKq0M8w4io7kNlfbZfNi71gk8Qqfvl BBqmmuu2VtIvLZh1l8vFNx5mY17sGCIEejC8rG6xaLrerToBsmis2N8p X-Gm-Gg: AY/fxX6hZJYb+3Y1PRsJSleMzbGtqDkGRWd/IfT1/JvbSf0zc3eI4KzcoGMudShHhSx QOn17rjxWIdJhvJZJy6xeBChLnUVOZTucBWcMooj453MiPiTqxoko0IYWmMZJXKgoQUqBcdB8Va OJjAU6uOd3VMlSwtRMcLHflUZ9ItmDQrHNG9UxMaAg8vkRK70yBYyq795e1qz1fIKMGMmHvFCBs XhW1h4iV6Mvtd36RFq3vgjV0UwpHU/Hv2yeSdKg2dECFNGlnbp9b/cQoB7I7tazTE3+IgUpo9/T goHwHb0tiwV1trWpjZFVmYHIQFAauNP1iHR1DauUAICvmMdpUXLLqJypC6G6TAXwgdZSq9ewTw3 BqXQGczwG2IO3EGQnLJoVxs2Jl7UKp8cJOc24rEeat453K8apydoj6rgt3UrURDNBmVf8I2IoTF /ZZPHhvQ9PEhzATlSrubhlwMJXVhvLPkGFWVgq6MfyBgUGzLhDK8whBGbDtl+cOztGDqiUvSfoJ QyGRw== X-Google-Smtp-Source: AGHT+IFearGGCMehcaf7l2oGrHLYTG/BJJ+fsXD89fmhah3wKRDfHzTz4sMHeduJJVb5yqsIa+UGaA== X-Received: by 2002:a05:6820:20b:b0:659:9a49:8f9c with SMTP id 006d021491bc7-65b451ac6admr9680026eaf.21.1766073676871; Thu, 18 Dec 2025 08:01:16 -0800 (PST) Received: from ?IPV6:2601:282:1e02:1040:7186:5ba6:22df:700c? ([2601:282:1e02:1040:7186:5ba6:22df:700c]) by smtp.googlemail.com with ESMTPSA id 006d021491bc7-65cff238d6csm1195738eaf.13.2025.12.18.08.01.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Dec 2025 08:01:11 -0800 (PST) Message-ID: <3ef6563c-84bd-49d4-a0bb-3dbc36e73318@gmail.com> Date: Thu, 18 Dec 2025 09:01:08 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests: net: fib-onlink-tests: Set high metric for default IPv6 route Content-Language: en-US To: =?UTF-8?Q?Ricardo_B=2E_Marli=C3=A8re?= , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251218-rbm-selftests-net-fib-onlink-v1-1-96302a5555c3@suse.com> From: David Ahern In-Reply-To: <20251218-rbm-selftests-net-fib-onlink-v1-1-96302a5555c3@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/18/25 5:20 AM, Ricardo B. Marlière wrote: > Currently, the test breaks if the SUT already has a default route > configured for IPv6. Fix by adding "metric 9999" to the `ip -6 ro add` > command, so that multiple default routes can coexist. > > Fixes: 4ed591c8ab44 ("net/ipv6: Allow onlink routes to have a device mismatch if it is the default route") > Signed-off-by: Ricardo B. Marlière > --- > tools/testing/selftests/net/fib-onlink-tests.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/fib-onlink-tests.sh b/tools/testing/selftests/net/fib-onlink-tests.sh > index ec2d6ceb1f08..acf6b0617373 100755 > --- a/tools/testing/selftests/net/fib-onlink-tests.sh > +++ b/tools/testing/selftests/net/fib-onlink-tests.sh > @@ -207,7 +207,7 @@ setup() > ip -netns ${PEER_NS} addr add ${V6ADDRS[p${n}]}/64 dev ${NETIFS[p${n}]} nodad > done > > - ip -6 ro add default via ${V6ADDRS[p3]/::[0-9]/::64} > + ip -6 ro add default via ${V6ADDRS[p3]/::[0-9]/::64} metric 9999 > ip -6 ro add table ${VRF_TABLE} default via ${V6ADDRS[p7]/::[0-9]/::64} > > set +e > > --- > base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 > change-id: 20251218-rbm-selftests-net-fib-onlink-873ad01e6884 > > Best regards, The intent of selftests is to run them in a clean environment with known settings. ie, there should not be a conflicting default route.