From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50F37370D5E for ; Thu, 7 May 2026 07:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778140284; cv=none; b=UTLlRmrqtY9owrLEiv4bzb6anyqMl49oz2ud8kNU45ueQJju1fKU2PfY/79dqGInrz77xiT0KOGjacHwv8Az2Rdkt2+43lTXy7SC5pwbBpbFSV6EM8yuNEJpZUb7XyJn0dmhtZ9kwJPMvxaaN+REwwXu37Yr0xS8LIY29dw1CHs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778140284; c=relaxed/simple; bh=hXQbl8Cit4+T7yJRt5JdQu9NH39mDdQbqe+q74GCoO4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AdSz0rF8KoJ5GI4P888DeQdCDZJdxNs/SDRo/z5I4NbIsuwgzMpyTOkFlP9C5Ip3RZfsn7vdqLbOq98aMqeFZU6ha52LKPeFySx7HIWOJ5HSYFnlg04VW5dbt1kLwvSGefolg6kWvrvaYUUeUaEFTAlbWJNzPh7vQrOKttBQWJc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=KZ6I+6+l; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="KZ6I+6+l" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2f0d3e07e30so1395652eec.0 for ; Thu, 07 May 2026 00:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1778140281; x=1778745081; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I5O+SMVnZI3YBFvbhgSVs7bzkx3ZYwEGUQfzptmHoXU=; b=KZ6I+6+lwczseyjNIJZl4pBnDm0jGr/gk/aThc5B0UbdSKkCg4jGX+fi9cTHPUWAtu SEbDm7iFVXAYEJiKTYZzogHLbb6Q2+VviNncsj/ajX4svIBx6BMXX5mhNMjBwdV+egUG HiKDKtsRgsvHiBcVs5ULSQZJZ17mx/xqCEW/CWQyQPtBWm3srajLdrf84VXJ/fHblgO5 FNjh9tmUVd1C/IMC21YNTU7GSW2d6ozwFIBSB5+bARGWBCA56gt2E7qTPD9aZlsWev0L mop2cbc0ex/mMYvw33aUH3wWDi3ly4mn0M6W94DSrG29xsnTwZP9mwybPBlLc7B81UBk P0eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778140281; x=1778745081; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I5O+SMVnZI3YBFvbhgSVs7bzkx3ZYwEGUQfzptmHoXU=; b=FlBVr9Magbb1Z3GLekD2H7TmKQucFOC4dlm6u0qWCB1bsjIsTnkudM+IMBucGuvWXp hj3vGUC/MyvCJ9moB+WsD9A6pbq1+az8QdwCU4GoZdXvSY6oOPlzYz6L6qOhxEoXeNYx SQhuj42vfod+e7+4KCvGjjI4aRCTeVbop6rAQW7s1GBaMx1Df9dMWQPUBeYGFfZF0Qq/ ls2jZMcGNYpSt4KO9EcJKK2P5Iu9iyn9Rppow+0RzE9vKed9doaXGT5a4fmUAVf/vz24 cLxBa+EHLddUYnGcXtK9n13Ldfc6NjCQCXndzfTfec/hIUQY9OaSEG10IwyCsDb5JGBh juMw== X-Forwarded-Encrypted: i=1; AFNElJ/2PM+DFNWwNx1sd5yRQnmM3quNoKZ3KDbIaN+3/4xtn6pj2WrxIDEmfGzyBLfPiAQvqgFgiCPR2CTbOSk=@vger.kernel.org X-Gm-Message-State: AOJu0YzvEgIGvCVV92b348rsmqprVaTlOcd5I4wWXovkG0dsaF7JKojJ JjMLoQp9cQH54lYfJQupxLDf9AlMgFOu9iizJVBMulTsLX1AOAasE/STjuDHKRSqtfM= X-Gm-Gg: AeBDiesdWb3iSBDHubfsFKMT6SRlFBYTt3ybTbUMC3I88XPvmkSUMJHcD2Ry8IcxJDV pP7CH4rB6EhHDClPcx+5capYn4kGbm/LgVpk6O3Hfx2kQ894x1YJPWIN4LZR0enqP9FUKwkGTyR 8jFuNV+79P1xHM6B7iCnI2Cd1niqKprtwp863wZAvXkQhdcxnCRNT3a8CgzSfzmlg2nCmiNEvlH qU/6lwuBbSrmJjJnw2FZr/u4iuMB7/0qnDV3LPlWqZXh4oRcERPg1M4z4Pp3dbbfkxiso0OVC2q J/Poyb2BWZL1M96Y75xXSWat6JH+Udt0b5KrTAWhXsk3IGfakF4xau+Yg+yrdfZmh3blOdsqOEa Bp1syhf5vnLustEZDWEnhZdd7DjzyvRcAnA6kzUlX7kbKH+ovIIL+g54C2mV5dZl5s990g9aPLx KHl2DQT8NA28twR1YGXBrT7ed1tQEEzwvjaIpE4S1/PX7vHrJy70tsVSfPEBVFnTUbDhBXPr/2f OxfoneJHR3HepkRXSBt4trvI1HF/hFqFBBCVJIk1dp2GLmaYc6GFhuhW8vsB8MroWfj9WTR3Ouc 7VFL40HT X-Received: by 2002:a05:693c:2c01:b0:2c5:b23e:48a6 with SMTP id 5a478bee46e88-2f54b265a7dmr3572827eec.23.1778140281108; Thu, 07 May 2026 00:51:21 -0700 (PDT) Received: from ?IPV6:2600:380:4661:8001:1a06:add6:6891:16e? ([2600:380:4661:8001:1a06:add6:6891:16e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f56f88f89csm6750124eec.15.2026.05.07.00.51.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 00:51:20 -0700 (PDT) Message-ID: <3f01f3b5-f57e-4e04-8a70-ac0722f243be@kernel.dk> Date: Thu, 7 May 2026 01:51:15 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] block: bio-integrity: Fix null-ptr-deref in bio_integrity_map_user() To: Sungwoo Kim , Keith Busch Cc: Chao Shi , Weidong Zhu , Dave Tian , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260427040926.987166-3-iam@sung-woo.kim> Content-Language: en-US From: Jens Axboe In-Reply-To: <20260427040926.987166-3-iam@sung-woo.kim> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit > diff --git a/block/bio-integrity.c b/block/bio-integrity.c > index e54c6e06e1cb..766cc2d1d51c 100644 > --- a/block/bio-integrity.c > +++ b/block/bio-integrity.c > @@ -403,6 +403,23 @@ int bio_integrity_map_user(struct bio *bio, struct iov_iter *iter) > if (unlikely(ret < 0)) > goto free_bvec; > > + /* Handle partial pinning. This can happen when pin_user_pages_fast() > + * returns fewer pages than requested > + */ Please follow the multi-line comment style used in the code around you. > + if (user_backed_iter(iter) && unlikely(ret != bytes)) { > + if (0 < ret) { And never do this, it's so much worse to read than if (ret > 0) -- Jens Axboe