From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Shuah Khan <shuah@kernel.org>, Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Cristian Marussi <cristian.marussi@arm.com>
Subject: Re: [PATCH] kselftest: Fix vdso_test_abi return status
Date: Fri, 28 Jan 2022 11:09:27 +0000 [thread overview]
Message-ID: <3f0ed265-1eec-b12a-2fc2-6a558eb835c4@arm.com> (raw)
In-Reply-To: <5ea69341-73af-e741-7b5d-c161845583c9@linuxfoundation.org>
Hi Shuah,
On 1/27/22 11:18 PM, Shuah Khan wrote:
>
> You can use the ksft_* counts interfaces for this instead of adding
> counts here. ksft_test_result_*() can be used to increment the right
> result counters and then print counts at the end.
>
> Either if there is a failure in any of the tests it will be fail with
> clear indication on which tests failed. vdso_test_clock() test for
> example is reporting false positives by overriding the Skip return
> with a pass.
>
Good point. I missed one condition in updating the test. I will post v2 that
will be compliant with the interface you mentioned.
Thanks.
> thanks,
> -- Shuah
--
Regards,
Vincenzo
next prev parent reply other threads:[~2022-01-28 11:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 10:27 [PATCH 0/5] Miscellaneous trivial fixes Cristian Marussi
2022-01-26 10:27 ` [PATCH 1/5] selftests: skip mincore.check_file_mmap when fs lacks needed support Cristian Marussi
2022-01-27 23:23 ` Shuah Khan
2022-01-26 10:27 ` [PATCH 2/5] kselftest: Fix vdso_test_time to pass on skips Cristian Marussi
2022-01-26 12:22 ` Vincenzo Frascino
2022-01-26 12:34 ` Cristian Marussi
2022-01-26 15:26 ` Vincenzo Frascino
2022-01-26 12:26 ` [PATCH] kselftest: Fix vdso_test_abi return status Vincenzo Frascino
2022-01-27 23:18 ` Shuah Khan
2022-01-28 11:09 ` Vincenzo Frascino [this message]
2022-01-27 23:02 ` [PATCH 2/5] kselftest: Fix vdso_test_time to pass on skips Shuah Khan
2022-01-26 10:27 ` [PATCH 3/5] selftests: openat2: Print also errno in failure messages Cristian Marussi
2022-01-27 23:11 ` Shuah Khan
2022-01-26 10:27 ` [PATCH 4/5] selftests: openat2: Add missing dependency in Makefile Cristian Marussi
2022-01-27 23:12 ` Shuah Khan
2022-01-26 10:27 ` [PATCH 5/5] selftests: openat2: Skip testcases that fail with EOPNOTSUPP Cristian Marussi
2022-01-27 23:13 ` Shuah Khan
2022-01-27 23:05 ` [PATCH 0/5] Miscellaneous trivial fixes Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f0ed265-1eec-b12a-2fc2-6a558eb835c4@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=cristian.marussi@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox