From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70BEB3B8D7E for ; Mon, 8 Dec 2025 11:27:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765193228; cv=none; b=XcK3S5LzYiFOqNtnTc3+9RcmWXMGZXZ3DV63zYpZ0bKVIOik0DYvWe5LwZhAd74ELKn5aPjUu0GoZYaLT0Q0o5P+JMNBlo9XkYlD5srj+pmBAmxQE66BB0RcWjbdxSjATJM56BVTFrdw6R9zF/AS8ohi7aVRGANQNDSO34LXh1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765193228; c=relaxed/simple; bh=Uxvc0qN1aVKZrytCBMtpqiJHC/U5kWCKmiBua2qivZI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q6bcMLF+PuWfLgAOmKwk5oohmtW50a8xDDuJ74Gu1aAMS7QTssA1dJPdwkEVVd73tYVIoZ8qqjUxBGaJu5uqp20YzGyD1x4n+UsI8UJtoZ6eoTOu1KhtN2YjiihW0pSosCemi36VD5GVJfKb6095GzDwzSfy0Thh0azjU/RURAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=RZdoCdds; arc=none smtp.client-ip=91.218.175.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="RZdoCdds" Message-ID: <3f2aee2b-578a-4d82-8dac-14cb9f2ada05@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1765193224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KS9+fkJURzUJE1mmvUiBXK04jhbhsrgQmnTnkE10avY=; b=RZdoCdds7YbZnHkW/nYm6bY4Esp1KjkxKwlJIihYgTfYeYRjDlUR+QMDbixZCFIL3ijkfb MRc4SImvpFbKrkzgt+mxIM/1RqwJgHViy1Bvvv5PWU7XWqKJfJYPOIEoDHWSHfQFq+aJD9 6YpG+e5x6gt+bZ2igvQFu1iLzobsD64= Date: Mon, 8 Dec 2025 11:26:54 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 4/4] drm/tidss: Fix enable/disable order To: Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Dmitry Baryshkov , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Jyri Sarha Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski , Louis-Alexis Eyraud , Linus Walleij , Chaoyi Chen , Vicente Bergas , Marek Vasut , stable@vger.kernel.org References: <20251205-drm-seq-fix-v1-0-fda68fa1b3de@ideasonboard.com> <20251205-drm-seq-fix-v1-4-fda68fa1b3de@ideasonboard.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Aradhya Bhatia In-Reply-To: <20251205-drm-seq-fix-v1-4-fda68fa1b3de@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 05/12/2025 09:51, Tomi Valkeinen wrote: > TI's OLDI and DSI encoders need to be set up before the crtc is enabled, > but the DRM helpers will enable the crtc first. This causes various > issues on TI platforms, like visual artifacts or crtc sync lost > warnings. > > Thus drm_atomic_helper_commit_modeset_enables() and > drm_atomic_helper_commit_modeset_disables() cannot be used, as they > enable the crtc before bridges' pre-enable, and disable the crtc after > bridges' post-disable. > > Open code the drm_atomic_helper_commit_modeset_enables() and > drm_atomic_helper_commit_modeset_disables(), and first call the bridges' > pre-enables, then crtc enable, then bridges' post-enable (and vice versa > for disable). > > Signed-off-by: Tomi Valkeinen > Cc: stable@vger.kernel.org # v6.17+ > --- > drivers/gpu/drm/tidss/tidss_kms.c | 30 +++++++++++++++++++++++++++--- > 1 file changed, 27 insertions(+), 3 deletions(-) > Reviewed-by: Aradhya Bhatia