From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v3 07/25] i2c: designware: Save pointer to semaphore callbacks instead of index
Date: Fri, 17 Nov 2023 15:51:55 +0200 [thread overview]
Message-ID: <3f30ed45-d63c-47c0-a533-43a2d2cfc31a@linux.intel.com> (raw)
In-Reply-To: <20231110182304.3894319-8-andriy.shevchenko@linux.intel.com>
On 11/10/23 20:11, Andy Shevchenko wrote:
> Instead of saving index and do an additional level of referencing,
> save just a pointer to the semaphore callbacks directly. It makes
> code cleaner.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/i2c/busses/i2c-designware-core.h | 4 +++-
> drivers/i2c/busses/i2c-designware-platdrv.c | 12 ++++--------
> 2 files changed, 7 insertions(+), 9 deletions(-)
>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2023-11-17 13:52 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 18:11 [PATCH v3 00/25] i2c: designware: code consolidation & cleanups Andy Shevchenko
2023-11-10 18:11 ` [PATCH v3 01/25] i2c: designware: Delete adapter before disabling in i2c_dw_pci_remove() Andy Shevchenko
2023-11-15 9:45 ` Jarkko Nikula
2023-11-15 13:49 ` Andy Shevchenko
2023-11-10 18:11 ` [PATCH v3 02/25] i2c: designware: Fix PM calls order in dw_i2c_plat_probe() Andy Shevchenko
2023-11-15 11:14 ` Jarkko Nikula
2023-11-15 13:48 ` Andy Shevchenko
2023-11-15 13:51 ` Andy Shevchenko
2023-11-10 18:11 ` [PATCH v3 03/25] i2c: designware: Fix reset call " Andy Shevchenko
2023-11-15 11:26 ` Jarkko Nikula
2023-11-10 18:11 ` [PATCH v3 04/25] i2c: designware: Let PCI core to take care about interrupt vectors Andy Shevchenko
2023-11-15 12:08 ` Jarkko Nikula
2023-11-15 13:54 ` Andy Shevchenko
2023-11-10 18:11 ` [PATCH v3 05/25] i2c: designware: Fix lock probe call order in dw_i2c_plat_probe() Andy Shevchenko
2023-11-10 18:11 ` [PATCH v3 06/25] i2c: designware: Replace a while-loop by for-loop Andy Shevchenko
2023-11-10 19:40 ` Mario Limonciello
2023-11-17 13:51 ` Jarkko Nikula
2023-11-10 18:11 ` [PATCH v3 07/25] i2c: designware: Save pointer to semaphore callbacks instead of index Andy Shevchenko
2023-11-17 13:51 ` Jarkko Nikula [this message]
2023-11-10 18:11 ` [PATCH v3 08/25] i2c: designware: Add missing 'c' into PCI IDs variable name Andy Shevchenko
2023-11-17 13:51 ` Jarkko Nikula
2023-11-10 18:11 ` [PATCH v3 09/25] i2c: designware: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE() Andy Shevchenko
2023-11-10 19:39 ` Mario Limonciello
2023-11-17 14:07 ` Jarkko Nikula
2023-11-10 18:11 ` [PATCH v3 10/25] i2c: designware: Unify terminator in device ID tables Andy Shevchenko
2023-11-10 19:38 ` Mario Limonciello
2023-11-17 14:18 ` Jarkko Nikula
2023-11-20 14:17 ` Andy Shevchenko
2023-11-17 14:08 ` Jarkko Nikula
2023-11-10 18:11 ` [PATCH v3 11/25] i2c: designware: Always provide " Andy Shevchenko
2023-11-10 18:11 ` [PATCH v3 12/25] i2c: designware: Drop return value from i2c_dw_acpi_configure() Andy Shevchenko
2023-11-17 14:46 ` Jarkko Nikula
2023-11-10 18:11 ` [PATCH v3 13/25] i2c: designware: Drop return value from dw_i2c_of_configure() Andy Shevchenko
2023-11-10 19:41 ` Mario Limonciello
2023-11-17 14:19 ` Jarkko Nikula
2023-11-10 18:11 ` [PATCH v3 14/25] i2c: designware: Rename dw_i2c_of_configure() -> i2c_dw_of_configure() Andy Shevchenko
2023-11-10 19:39 ` Mario Limonciello
2023-11-17 14:46 ` Jarkko Nikula
2023-11-10 18:11 ` [PATCH v3 15/25] i2c: designware: Consolidate firmware parsing and configuring code Andy Shevchenko
2023-11-10 18:11 ` [PATCH v3 16/25] i2c: designware: Unify the firmware type checks Andy Shevchenko
2023-11-10 18:11 ` [PATCH v3 17/25] i2c: designware: Move exports to I2C_DW namespaces Andy Shevchenko
2023-11-10 18:11 ` [PATCH v3 18/25] i2c: designware: Remove ->disable() callback Andy Shevchenko
2023-11-14 15:03 ` Jarkko Nikula
2023-11-10 18:11 ` [PATCH v3 19/25] i2c: designware: Consolidate PM ops Andy Shevchenko
2023-11-10 18:11 ` [PATCH v3 20/25] i2c: designware: Uninline i2c_dw_probe() Andy Shevchenko
2023-11-10 18:11 ` [PATCH v3 21/25] i2c: designware: Propagate firmware node Andy Shevchenko
2023-11-10 18:11 ` [PATCH v3 22/25] i2c: designware: Use pci_get_drvdata() Andy Shevchenko
2023-11-10 18:11 ` [PATCH v3 23/25] i2c: designware: Use temporary variable for struct device Andy Shevchenko
2023-11-10 19:36 ` Mario Limonciello
2023-11-10 18:11 ` [PATCH v3 24/25] i2c: designware: Get rid of redundant 'else' Andy Shevchenko
2023-11-10 18:11 ` [PATCH v3 25/25] i2c: designware: Fix spelling and other issues in the comments Andy Shevchenko
2023-11-10 19:35 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f30ed45-d63c-47c0-a533-43a2d2cfc31a@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=p.zabel@pengutronix.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox