From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB8D915B0E6 for ; Wed, 29 May 2024 22:19:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717021155; cv=none; b=WpFhEp4zSh/51dLqO4KAKWr81xhMxtzuETHVm6Q7jYgSDxjB/YpqP7pgOh1qLou5T9jeEWTDC+kFX+RPYzEPt436yaBf5b7RWsZBRBjDK8Jm6CUdhiFjss5NBTXprxaO4+iTKN5qi8mXs4VAtDo7IzBlFZq0RnjVDBEULIgS0z8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717021155; c=relaxed/simple; bh=P15Xc0XyTPFvoCXfmrMxrFhFsyfQkEO7hmX8PLu1Xtk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=leJU3zkVzCqBv/Ds3Q1ElKpBU6nVMa150aQAdwDxskYuS1NJukLPZZSebQuOrsvYH9Nq04T0GJ2zU3+BRw5SM4pyNzFtkr/8BIrhE4/XwGefWQEV5ukvEI5qnqiyGC3nspgaaR7XSm5ztmHOapYsCDyxPIpy2PQsJyutKv7H4ek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IVvMYp6A; arc=none smtp.client-ip=209.85.166.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IVvMYp6A" Received: by mail-il1-f174.google.com with SMTP id e9e14a558f8ab-3745eb24ffaso161915ab.1 for ; Wed, 29 May 2024 15:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1717021153; x=1717625953; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QIQsNObstWkWgKnY1UZsOrj0Wfr/JVGgFuTZShWQ62k=; b=IVvMYp6Ayi1TfYHVt/th2r4xneI5dfgrjM3hn1bakEPDdJqh/wKzx4Dhm9+3RDkFzo vAXnQBiqgU0NM9jF3YeoN4kYJ2qcaXyT3mlT7yZvg7FWWCjlcdFKbdW814LCiBdkaA38 JF/GCCUgIoABz8n7sL7iOmZw9y0quszELsS/Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717021153; x=1717625953; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QIQsNObstWkWgKnY1UZsOrj0Wfr/JVGgFuTZShWQ62k=; b=c/bztJGhZpXKe7oTrFjLCozAM/AO0vdnYV0wds+ReSbohRXpb+tpeRF6sBi0dZL+No UJsXrXUaDmHuCfoBjGAETjcWiXAHWBfl+HOe6Q/BDp6FAyJhtrlwEBvIzbm9UuoWVAT/ 7CJ8yn96gfrffk49ZZVJelUem/sydG6BeVqdFEJFVE8dEcv4dfcFEUT4ZW+NSMb7nFiY /f5DRz2VzbtWMoOJ9IxBEch9AkqB7TYduEUbR+kJMkDC9ynglrAN/ipStt4uOiLtNxhg u2oT35gtZqQQZyzBciv5/vo449bzmfpK/DTTTHtJBVrOfAEwS7gn2qpBp/gSRjZKuNOF P/0Q== X-Gm-Message-State: AOJu0Yzm7IoTrtFXAiPlrGuypnnope203S5GqZDuUpiSRBaA25E5P2h7 AedTagCmnU3sEJfANRw3JvriSBPLQGgi23/ne1FAV+T5ADLk8511mXS1bxKHpHhZASWwde+Brd1 K X-Google-Smtp-Source: AGHT+IGX3vM7AirEhD0z1TjIJ73Jy0G+hX175YByeN8PNH6Y8OAF4RTa4RM3+I+p92DV9/6KWiuc1Q== X-Received: by 2002:a05:6602:1d41:b0:7de:e495:42bf with SMTP id ca18e2360f4ac-7eaf5d79567mr28209339f.1.1717021152820; Wed, 29 May 2024 15:19:12 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4b0e80c3b6fsm1483913173.135.2024.05.29.15.19.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 May 2024 15:19:12 -0700 (PDT) Message-ID: <3f3a70ba-40d2-4624-b8c5-7c3ae2a025fb@linuxfoundation.org> Date: Wed, 29 May 2024 16:19:11 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/overlayfs: Fix build error on ppc64 To: Michael Ellerman , linux-kselftest@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Shuah Khan , shuah References: <20240521022616.45240-1-mpe@ellerman.id.au> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240521022616.45240-1-mpe@ellerman.id.au> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/20/24 20:26, Michael Ellerman wrote: > Fix build error on ppc64: > dev_in_maps.c: In function ‘get_file_dev_and_inode’: > dev_in_maps.c:60:59: error: format ‘%llu’ expects argument of type > ‘long long unsigned int *’, but argument 7 has type ‘__u64 *’ {aka ‘long > unsigned int *’} [-Werror=format=] > > By switching to unsigned long long for u64 for ppc64 builds. > > Signed-off-by: Michael Ellerman > --- > tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c b/tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c > index 759f86e7d263..2862aae58b79 100644 > --- a/tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c > +++ b/tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c > @@ -1,5 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > #define _GNU_SOURCE > +#define __SANE_USERSPACE_TYPES__ // Use ll64 > > #include > #include Applied to linux-kselftest fixes for the next rc. Michael, If you want to take this through, let me know, I can drop this. thanks, -- Shuah