From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61E5520C463 for ; Fri, 31 Oct 2025 02:25:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761877504; cv=none; b=Sh63pk6yKQ6GoZpkNh+vYA/uaKVAzRdhZLwbzFIkekwkvSd67nAWjtEvhQm7FR/FPfkK+/SZXVS3clRAirn6XuVyFEIFYW0k1RKtkxh9LxpP0vPKEqCBoBXudtsTrsEBLnscqhpJC9++SKTX1bpKfah27WFrWNxX1/yjoqvNpow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761877504; c=relaxed/simple; bh=a0/Aw9rdJRh6TCw+ET1ntS2tFV2UR6oax8kPz5yEtOU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YdLDfVk6szQ5KN/ngx/ji63LvpbWXoc+rUXMHLrFa7BYA7z1aCP19WcRasB8+2n0OrGqxbk6AfYQqJJ2HlQBAxdZa8HlXogp8lr97aEoR/0seBguo93AypN2AyZvLD5nwk7TLjDeYam83/4MZn00qQ9pTd7wvNOqXvuJLXwaEQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ODaJ2JG9; arc=none smtp.client-ip=91.218.175.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ODaJ2JG9" Message-ID: <3f706533-6dac-4aff-b71b-65dfc9c0a45f@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1761877497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9zXpaf1PUl+ks+7sZWUmsZnpMNh1FxPUUYlNyCCH1AY=; b=ODaJ2JG9/pcH7xJnRc/fb8LZUtMg79iLyQ4vIW8DPiTOAW17Ei7eBT9rLg5xTH0YAblp6b Fl5rIbLihEqpt9BUXftwnCvAsM4IX/mK7nm49nJhFWfaI3ktN4hfRRHGoZ9LGl0a8PeIM9 scN71ObN38ZzZ5yUDkrXOXE+gu7Fgx4= Date: Fri, 31 Oct 2025 10:24:06 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v4 15/24] smb: move FILE_SYSTEM_POSIX_INFO to common/smb1pdu.h To: Steve French , =?UTF-8?Q?Ralph_B=C3=B6hme?= Cc: sfrench@samba.org, linkinjeon@kernel.org, linkinjeon@samba.org, christophe.jaillet@wanadoo.fr, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251027071316.3468472-1-chenxiaosong.chenxiaosong@linux.dev> <20251027072206.3468578-1-chenxiaosong.chenxiaosong@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: ChenXiaoSong In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Got it, thank you for your answer. Thanks, ChenXiaoSong. 在 2025/10/31 09:53, Steve French 写道: > Sorry forgot to attach the link > > https://gitlab.com/samba-team/smb3-posix-spec > > On Thu, Oct 30, 2025 at 8:53 PM Steve French wrote: >> >> Ralph, >> Is this link current? or do you have the link to a more current >> version of the POSIX extensions documentation? >> >> On Thu, Oct 30, 2025 at 8:42 PM ChenXiaoSong >> wrote: >>> >>> Hi Namjae and Steve, >>> >>> I couldn’t find the definition of FILE_SYSTEM_POSIX_INFO in any of the >>> following MS documents: >>> >>> - MS-FSCC: >>> https://learn.microsoft.com/pdf?url=https%3A%2F%2Flearn.microsoft.com%2Fen-us%2Fopenspecs%2Fwindows_protocols%2Fms-fscc%2Ftoc.json >>> - MS-CIFS: >>> https://learn.microsoft.com/pdf?url=https%3A%2F%2Flearn.microsoft.com%2Fen-us%2Fopenspecs%2Fwindows_protocols%2Fms-cifs%2Ftoc.json >>> - MS-SMB: >>> https://learn.microsoft.com/pdf?url=https%3A%2F%2Flearn.microsoft.com%2Fen-us%2Fopenspecs%2Fwindows_protocols%2Fms-smb%2Ftoc.json >>> - MS-SMB2: >>> https://learn.microsoft.com/pdf?url=https%3A%2F%2Flearn.microsoft.com%2Fen-us%2Fopenspecs%2Fwindows_protocols%2Fms-smb2%2Ftoc.json >>> >>> Is this structure defined in other MS document? >>> >>> On 10/27/25 3:21 PM, chenxiaosong.chenxiaosong@linux.dev wrote: >>>> From: ChenXiaoSong >>>> >>>> Rename "struct filesystem_posix_info" to "FILE_SYSTEM_POSIX_INFO", >>>> then move duplicate definitions to common header file. >>>> >>>> Signed-off-by: ChenXiaoSong >>>> --- >>>> fs/smb/client/cifspdu.h | 22 ---------------------- >>>> fs/smb/common/smb1pdu.h | 23 +++++++++++++++++++++++ >>>> fs/smb/server/smb2pdu.c | 4 ++-- >>>> fs/smb/server/smb_common.h | 23 ----------------------- >>>> 4 files changed, 25 insertions(+), 47 deletions(-) >>>> >>>> diff --git a/fs/smb/client/cifspdu.h b/fs/smb/client/cifspdu.h >>>> index d106c6850807..55aaae6dbc86 100644 >>>> --- a/fs/smb/client/cifspdu.h >>>> +++ b/fs/smb/client/cifspdu.h >>>> @@ -1875,28 +1875,6 @@ typedef struct { >>>> >>>> #define CIFS_POSIX_EXTENSIONS 0x00000010 /* support for new QFSInfo */ >>>> >>>> -typedef struct { >>>> - /* For undefined recommended transfer size return -1 in that field */ >>>> - __le32 OptimalTransferSize; /* bsize on some os, iosize on other os */ >>>> - __le32 BlockSize; >>>> - /* The next three fields are in terms of the block size. >>>> - (above). If block size is unknown, 4096 would be a >>>> - reasonable block size for a server to report. >>>> - Note that returning the blocks/blocksavail removes need >>>> - to make a second call (to QFSInfo level 0x103 to get this info. >>>> - UserBlockAvail is typically less than or equal to BlocksAvail, >>>> - if no distinction is made return the same value in each */ >>>> - __le64 TotalBlocks; >>>> - __le64 BlocksAvail; /* bfree */ >>>> - __le64 UserBlocksAvail; /* bavail */ >>>> - /* For undefined Node fields or FSID return -1 */ >>>> - __le64 TotalFileNodes; >>>> - __le64 FreeFileNodes; >>>> - __le64 FileSysIdentifier; /* fsid */ >>>> - /* NB Namelen comes from FILE_SYSTEM_ATTRIBUTE_INFO call */ >>>> - /* NB flags can come from FILE_SYSTEM_DEVICE_INFO call */ >>>> -} __attribute__((packed)) FILE_SYSTEM_POSIX_INFO; >>>> - >>>> /* DeviceType Flags */ >>>> #define FILE_DEVICE_CD_ROM 0x00000002 >>>> #define FILE_DEVICE_CD_ROM_FILE_SYSTEM 0x00000003 >>>> diff --git a/fs/smb/common/smb1pdu.h b/fs/smb/common/smb1pdu.h >>>> index 82331a8f70e8..38b9c091baab 100644 >>>> --- a/fs/smb/common/smb1pdu.h >>>> +++ b/fs/smb/common/smb1pdu.h >>>> @@ -327,6 +327,29 @@ typedef struct { >>>> __le32 BytesPerSector; >>>> } __packed FILE_SYSTEM_INFO; /* size info, level 0x103 */ >>>> >>>> +typedef struct { >>>> + /* For undefined recommended transfer size return -1 in that field */ >>>> + __le32 OptimalTransferSize; /* bsize on some os, iosize on other os */ >>>> + __le32 BlockSize; >>>> + /* The next three fields are in terms of the block size. >>>> + * (above). If block size is unknown, 4096 would be a >>>> + * reasonable block size for a server to report. >>>> + * Note that returning the blocks/blocksavail removes need >>>> + * to make a second call (to QFSInfo level 0x103 to get this info. >>>> + * UserBlockAvail is typically less than or equal to BlocksAvail, >>>> + * if no distinction is made return the same value in each >>>> + */ >>>> + __le64 TotalBlocks; >>>> + __le64 BlocksAvail; /* bfree */ >>>> + __le64 UserBlocksAvail; /* bavail */ >>>> + /* For undefined Node fields or FSID return -1 */ >>>> + __le64 TotalFileNodes; >>>> + __le64 FreeFileNodes; >>>> + __le64 FileSysIdentifier; /* fsid */ >>>> + /* NB Namelen comes from FILE_SYSTEM_ATTRIBUTE_INFO call */ >>>> + /* NB flags can come from FILE_SYSTEM_DEVICE_INFO call */ >>>> +} __packed FILE_SYSTEM_POSIX_INFO; >>>> + >>>> /* See MS-CIFS 2.2.8.2.5 */ >>>> typedef struct { >>>> __le32 DeviceType; >>>> diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c >>>> index 47fab72a3588..dc0f0ed4ccb6 100644 >>>> --- a/fs/smb/server/smb2pdu.c >>>> +++ b/fs/smb/server/smb2pdu.c >>>> @@ -5633,14 +5633,14 @@ static int smb2_get_info_filesystem(struct ksmbd_work *work, >>>> } >>>> case FS_POSIX_INFORMATION: >>>> { >>>> - struct filesystem_posix_info *info; >>>> + FILE_SYSTEM_POSIX_INFO *info; >>>> >>>> if (!work->tcon->posix_extensions) { >>>> pr_err("client doesn't negotiate with SMB3.1.1 POSIX Extensions\n"); >>>> path_put(&path); >>>> return -EOPNOTSUPP; >>>> } else { >>>> - info = (struct filesystem_posix_info *)(rsp->Buffer); >>>> + info = (FILE_SYSTEM_POSIX_INFO *)(rsp->Buffer); >>>> info->OptimalTransferSize = cpu_to_le32(stfs.f_bsize); >>>> info->BlockSize = cpu_to_le32(stfs.f_bsize); >>>> info->TotalBlocks = cpu_to_le64(stfs.f_blocks); >>>> diff --git a/fs/smb/server/smb_common.h b/fs/smb/server/smb_common.h >>>> index 6141ca8f7e1c..61048568f4c7 100644 >>>> --- a/fs/smb/server/smb_common.h >>>> +++ b/fs/smb/server/smb_common.h >>>> @@ -108,29 +108,6 @@ struct file_id_both_directory_info { >>>> char FileName[]; >>>> } __packed; >>>> >>>> -struct filesystem_posix_info { >>>> - /* For undefined recommended transfer size return -1 in that field */ >>>> - __le32 OptimalTransferSize; /* bsize on some os, iosize on other os */ >>>> - __le32 BlockSize; >>>> - /* The next three fields are in terms of the block size. >>>> - * (above). If block size is unknown, 4096 would be a >>>> - * reasonable block size for a server to report. >>>> - * Note that returning the blocks/blocksavail removes need >>>> - * to make a second call (to QFSInfo level 0x103 to get this info. >>>> - * UserBlockAvail is typically less than or equal to BlocksAvail, >>>> - * if no distinction is made return the same value in each >>>> - */ >>>> - __le64 TotalBlocks; >>>> - __le64 BlocksAvail; /* bfree */ >>>> - __le64 UserBlocksAvail; /* bavail */ >>>> - /* For undefined Node fields or FSID return -1 */ >>>> - __le64 TotalFileNodes; >>>> - __le64 FreeFileNodes; >>>> - __le64 FileSysIdentifier; /* fsid */ >>>> - /* NB Namelen comes from FILE_SYSTEM_ATTRIBUTE_INFO call */ >>>> - /* NB flags can come from FILE_SYSTEM_DEVICE_INFO call */ >>>> -} __packed; >>>> - >>>> struct smb_version_ops { >>>> u16 (*get_cmd_val)(struct ksmbd_work *swork); >>>> int (*init_rsp_hdr)(struct ksmbd_work *swork); >>> >> >> >> -- >> Thanks, >> >> Steve > > >