From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8E93C43441 for ; Mon, 19 Nov 2018 22:11:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E91B2080C for ; Mon, 19 Nov 2018 22:11:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LCtGN4NG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E91B2080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731468AbeKTIhV (ORCPT ); Tue, 20 Nov 2018 03:37:21 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38934 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731256AbeKTIhV (ORCPT ); Tue, 20 Nov 2018 03:37:21 -0500 Received: by mail-wr1-f67.google.com with SMTP id b13so33667479wrx.6; Mon, 19 Nov 2018 14:11:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5Dck1jKnruAxnGiVRmbcWgWiXQ+KB5ToM3dB3un7OJQ=; b=LCtGN4NG3Magzw2HzWRkqPzSPTo5I0aNbEi60M4NCXi5gaA2/XqcvpShH86zDeSR4m j0Mf3+0eNfGyL6HP5t2uKzowAmmNKBtQscoOCFrXkveOOzZBWE5LXH9/SdgQ8TaPDwre 99WgdE04BQvrRn4CvJd5a5W/oSDh+TPX2mMbQP+ArT4I0dtIXFRiJdaaqLBiu0exkZ7f F7HPMEDfsX3SwTRx6N31Mpf8KbK0NEQHnph1Voe37gVwP5iJ12j335kVkHHA8+j6tNs9 IPujMT5YE1XWlGtOtSbvVkqaRIA7PbBwy3bGki1iDOxMTTKxLTRWqE1uk+s/hRiArd/g cQyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5Dck1jKnruAxnGiVRmbcWgWiXQ+KB5ToM3dB3un7OJQ=; b=cEwvlLqRWe2KbyoSeJZ/CCpYw7m5QKNNcZQkl9yzdH1Gf+XgZJUZ9ST0+Z5+G0GmaS gaMPgps+d6ua/Ce5TFtUA1mrCNR9ZD3KH9z0UvQsmC33GM6iOIi3qmvfpdNaEk4JDq8i wYTg9Luc0MLzxWj8t8x+QD257uz12luhd0G82wpy818VtYYC9J0ibF6xgEH3YMJiPABE 5zMFNyqoXpGiIwCLrvp9o7L6Aq8o8No+IlVn+DQomjgnpJuQks6/mmK0P//ma2SHNW8A sfYfKjL7r6xUEvdIyGY4iPgyKeOOMOcdZh1GiXIQA2ANbLI184gTKwATjgNkHhJ3s+ZL i9Xg== X-Gm-Message-State: AGRZ1gKXBke+RNwFGwA96lARZFTWiz54ZJkUuO3cUTDobAT+q/QrgNZS RjoYaHie5HVKwo5zyfno26U= X-Google-Smtp-Source: AJdET5dSLT+3r2lDV0bJEcXvkDnKp1X0fFUAF8GOr434Di6DcbX7/CnTAstz98qtzMXvTk/gvLwblA== X-Received: by 2002:a05:6000:8a:: with SMTP id m10mr19225213wrx.79.1542665493404; Mon, 19 Nov 2018 14:11:33 -0800 (PST) Received: from [192.168.1.4] (ip-86-49-110-70.net.upcbroadband.cz. [86.49.110.70]) by smtp.gmail.com with ESMTPSA id p74sm5430985wmd.29.2018.11.19.14.11.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Nov 2018 14:11:32 -0800 (PST) Subject: Re: [PATCH 2/2] dt-binding: spi: Document Renesas R-Car RPC controller bindings To: Boris Brezillon Cc: Mason Yang , broonie@kernel.org, tpiepho@impinj.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Simon Horman , juliensu@mxic.com.tw, Geert Uytterhoeven , zhengxunli@mxic.com.tw References: <1542621690-10229-1-git-send-email-masonccyang@mxic.com.tw> <1542621690-10229-3-git-send-email-masonccyang@mxic.com.tw> <629a5d6f-5c13-9b24-1c21-461d09f1aa8a@gmail.com> <20181119151009.490413d9@bbrezillon> <20181119154338.2dfa7a5a@bbrezillon> <4c0683d3-fe9d-5a10-6f5c-4774024cb12a@gmail.com> <20181119162127.71d0665d@bbrezillon> From: Marek Vasut Message-ID: <3f791a3c-4a2e-5d43-1026-e1e7b879b562@gmail.com> Date: Mon, 19 Nov 2018 23:11:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20181119162127.71d0665d@bbrezillon> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/19/2018 04:21 PM, Boris Brezillon wrote: > On Mon, 19 Nov 2018 16:12:41 +0100 > Marek Vasut wrote: > >> On 11/19/2018 03:43 PM, Boris Brezillon wrote: >>> On Mon, 19 Nov 2018 15:14:07 +0100 >>> Marek Vasut wrote: >>> >>>> On 11/19/2018 03:10 PM, Boris Brezillon wrote: >>>>> On Mon, 19 Nov 2018 14:49:31 +0100 >>>>> Marek Vasut wrote: >>>>> >>>>>> On 11/19/2018 11:01 AM, Mason Yang wrote: >>>>>>> Document the bindings used by the Renesas R-Car D3 RPC controller. >>>>>>> >>>>>>> Signed-off-by: Mason Yang >>>>>>> --- >>>>>>> .../devicetree/bindings/spi/spi-renesas-rpc.txt | 33 ++++++++++++++++++++++ >>>>>>> 1 file changed, 33 insertions(+) >>>>>>> create mode 100644 Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt >>>>>>> >>>>>>> diff --git a/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt >>>>>>> new file mode 100644 >>>>>>> index 0000000..8286cc8 >>>>>>> --- /dev/null >>>>>>> +++ b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt >>>>>>> @@ -0,0 +1,33 @@ >>>>>>> +Renesas R-Car D3 RPC controller Device Tree Bindings >>>>>>> +---------------------------------------------------- >>>>>>> + >>>>>>> +Required properties: >>>>>>> +- compatible: should be "renesas,rpc-r8a77995" >>>>>>> +- #address-cells: should be 1 >>>>>>> +- #size-cells: should be 0 >>>>>>> +- reg: should contain 2 entries, one for the registers and one for the direct >>>>>>> + mapping area >>>>>>> +- reg-names: should contain "rpc_regs" and "dirmap" >>>>>>> +- interrupts: interrupt line connected to the RPC SPI controller >>>>>> >>>>>> Do you also plan to support the RPC HF mode ? And if so, how would that >>>>>> look in the bindings ? >>>>> >>>>> Not sure this approach is still accepted, but that's how we solved the >>>>> problem for the flexcom block [1]. >>>>> >>>>> [1]https://elixir.bootlin.com/linux/v4.20-rc3/source/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt >>>> >>>> That looks pretty horrible. >>>> >>>> In U-Boot we check whether the device hanging under the controller node >>>> is JEDEC SPI flash or CFI flash and based on that decide what the config >>>> of the controller should be (SPI or HF). Not sure that's much better,but >>>> at least it doesn't need extra nodes which do not really represent any >>>> kind of real hardware. >>>> >>> >>> The subnodes are not needed, you can just have a property that tells in >>> which mode the controller is supposed to operate, and the MFD would >>> create a sub-device that points to the same device_node. >> >> Do you even need a dedicated property ? I think you can decide purely on >> what node is hanging under the controller (jedec spi nor or cfi nor). > > Yes, that could work if they have well-known compatibles. As soon as > people start using flash-specific compats (like some people do for > their SPI NORs) it becomes a maintenance burden. Which, on this controller, is very likely never gonna happen. Once it does , we can add a custom property. >>> Or we can have >>> a single driver that decides what to declare (a spi_controller or flash >>> controller), but you'd still have to decide where to place this >>> driver... >> >> I'd definitely prefer a single driver. >> > > Where would you put this driver? I really don't like the idea of having > MTD drivers spread over the tree. Don't know what's Mark's opinion on > this matter. Well, it's both CFI (hyperflash) and SF (well, SPI flash) controller, so where would this go ? -- Best regards, Marek Vasut