From: Daniel Baluta <daniel.baluta@nxp.com>
To: Eduard Bostina <egbostina@gmail.com>, gregkh@linuxfoundation.org
Cc: broonie@kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, simona.toaca@nxp.com
Subject: Re: [PATCH v2] staging: rtl8723bs: Clean up unnecessary parentheses and braces
Date: Wed, 4 Mar 2026 17:53:08 +0200 [thread overview]
Message-ID: <3f897a93-3aab-4274-bc9b-abe23f2a70cb@nxp.com> (raw)
In-Reply-To: <20260304153426.2217417-1-egbostina@gmail.com>
On 3/4/26 17:34, Eduard Bostina wrote:
> Increase code readability and follow Linux kernel coding style by
> removing unnecessary parentheses and braces.
>
> This also fixes the following checkpatch.pl issues:
> WARNING: Unnecessary parentheses - maybe == should be = ?
> WARNING: braces {} are not necessary for any arm of this statement
>
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>
>
Hi Eduard, This looks good to me!
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
As for the v2 in the subject, you should always start fresh
when sending a patch to the community no matter on how many reviews we did in private.
Community is not aware of that and having [PATCH v2] is confusing.
Greg,
Should Eduard send the patch again and remove v2? Or is this patch still fine.
prev parent reply other threads:[~2026-03-04 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 15:34 [PATCH v2] staging: rtl8723bs: Clean up unnecessary parentheses and braces Eduard Bostina
2026-03-04 15:44 ` Greg KH
2026-03-04 15:53 ` Daniel Baluta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f897a93-3aab-4274-bc9b-abe23f2a70cb@nxp.com \
--to=daniel.baluta@nxp.com \
--cc=broonie@kernel.org \
--cc=egbostina@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=simona.toaca@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox