From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] platform/goldfish: goldfish_pipe: add missing MODULE_DESCRIPTION() macro
Date: Fri, 28 Jun 2024 20:10:18 -0700 [thread overview]
Message-ID: <3f8bb9ef-059e-4ef1-9e03-f90ddc8e612f@quicinc.com> (raw)
In-Reply-To: <20240615-goldfish_pipe-md-v2-1-b4323a969594@quicinc.com>
On 6/15/2024 2:34 PM, Jeff Johnson wrote:
> With arch=x86, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/goldfish/goldfish_pipe.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> Changes in v2:
> - Rebased to v6.10-rc3
> - Updated commit text to use a more recent boilerplate
> - Since there are no matching entries in MAINTAINERS, added Andrew & Greg
> to see if this can go through one of their misc trees
> - Link to v1: https://lore.kernel.org/r/20240509-goldfish_pipe-md-v1-1-acb513276263@quicinc.com
> ---
> drivers/platform/goldfish/goldfish_pipe.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
> index 061aa9647c19..c2aab0cfab33 100644
> --- a/drivers/platform/goldfish/goldfish_pipe.c
> +++ b/drivers/platform/goldfish/goldfish_pipe.c
> @@ -946,4 +946,5 @@ static struct platform_driver goldfish_pipe_driver = {
>
> module_platform_driver(goldfish_pipe_driver);
> MODULE_AUTHOR("David Turner <digit@google.com>");
> +MODULE_DESCRIPTION("Goldfish virtual device for QEMU pipes");
> MODULE_LICENSE("GPL v2");
>
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240509-goldfish_pipe-md-1dec20bd3a90
Following up to see if anything else is needed from me. Hoping to see this in
linux-next so I can remove it from my tracking spreadsheet :)
/jeff
prev parent reply other threads:[~2024-06-29 3:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-15 21:34 [PATCH v2] platform/goldfish: goldfish_pipe: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-29 3:10 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f8bb9ef-059e-4ef1-9e03-f90ddc8e612f@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox