public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] platform/goldfish: goldfish_pipe: add missing MODULE_DESCRIPTION() macro
@ 2024-06-15 21:34 Jeff Johnson
  2024-06-29  3:10 ` Jeff Johnson
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Johnson @ 2024-06-15 21:34 UTC (permalink / raw)
  To: Andrew Morton, Greg Kroah-Hartman
  Cc: kernel-janitors, linux-kernel, Jeff Johnson

With arch=x86, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/goldfish/goldfish_pipe.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
Changes in v2:
- Rebased to v6.10-rc3
- Updated commit text to use a more recent boilerplate
- Since there are no matching entries in MAINTAINERS, added Andrew & Greg
  to see if this can go through one of their misc trees
- Link to v1: https://lore.kernel.org/r/20240509-goldfish_pipe-md-v1-1-acb513276263@quicinc.com
---
 drivers/platform/goldfish/goldfish_pipe.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index 061aa9647c19..c2aab0cfab33 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -946,4 +946,5 @@ static struct platform_driver goldfish_pipe_driver = {
 
 module_platform_driver(goldfish_pipe_driver);
 MODULE_AUTHOR("David Turner <digit@google.com>");
+MODULE_DESCRIPTION("Goldfish virtual device for QEMU pipes");
 MODULE_LICENSE("GPL v2");

---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240509-goldfish_pipe-md-1dec20bd3a90


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] platform/goldfish: goldfish_pipe: add missing MODULE_DESCRIPTION() macro
  2024-06-15 21:34 [PATCH v2] platform/goldfish: goldfish_pipe: add missing MODULE_DESCRIPTION() macro Jeff Johnson
@ 2024-06-29  3:10 ` Jeff Johnson
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Johnson @ 2024-06-29  3:10 UTC (permalink / raw)
  To: Andrew Morton, Greg Kroah-Hartman; +Cc: kernel-janitors, linux-kernel

On 6/15/2024 2:34 PM, Jeff Johnson wrote:
> With arch=x86, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/goldfish/goldfish_pipe.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> Changes in v2:
> - Rebased to v6.10-rc3
> - Updated commit text to use a more recent boilerplate
> - Since there are no matching entries in MAINTAINERS, added Andrew & Greg
>   to see if this can go through one of their misc trees
> - Link to v1: https://lore.kernel.org/r/20240509-goldfish_pipe-md-v1-1-acb513276263@quicinc.com
> ---
>  drivers/platform/goldfish/goldfish_pipe.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
> index 061aa9647c19..c2aab0cfab33 100644
> --- a/drivers/platform/goldfish/goldfish_pipe.c
> +++ b/drivers/platform/goldfish/goldfish_pipe.c
> @@ -946,4 +946,5 @@ static struct platform_driver goldfish_pipe_driver = {
>  
>  module_platform_driver(goldfish_pipe_driver);
>  MODULE_AUTHOR("David Turner <digit@google.com>");
> +MODULE_DESCRIPTION("Goldfish virtual device for QEMU pipes");
>  MODULE_LICENSE("GPL v2");
> 
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240509-goldfish_pipe-md-1dec20bd3a90

Following up to see if anything else is needed from me. Hoping to see this in
linux-next so I can remove it from my tracking spreadsheet :)

/jeff

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-29  3:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-15 21:34 [PATCH v2] platform/goldfish: goldfish_pipe: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-29  3:10 ` Jeff Johnson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox