From: "Jaswinder Singh Rajput" <jaswinderlinux@gmail.com>
To: "Petr Titera" <P.Titera@century.cz>
Cc: linux-kernel@vger.kernel.org,
"Jaswinder Singh Rajput" <jaswinder@infradead.org>,
"Ingo Molnar" <mingo@elte.hu>
Subject: Re: Build error on latest git
Date: Sun, 11 Jan 2009 18:36:31 +0530 [thread overview]
Message-ID: <3f9a31f40901110506v646bd599q863be03accbfd8b2@mail.gmail.com> (raw)
In-Reply-To: <4969DEA0.5020301@century.cz>
On Sun, Jan 11, 2009 at 5:27 PM, Petr Titera <P.Titera@century.cz> wrote:
> Going through source it seems to me (still building) that it is caused by
> including asm/smp.h only if build with CONFIG_SMP. This patch seems to fix
> this
>
> diff --git a/include/linux/smp.h b/include/linux/smp.h
> index b824669..fd51bb9 100644
> --- a/include/linux/smp.h
> +++ b/include/linux/smp.h
> @@ -11,6 +11,8 @@
> #include <linux/list.h>
> #include <linux/cpumask.h>
>
> +#include <asm/smp.h>
> +
> extern void cpu_idle(void);
>
No, this is wrong.
asm/smp.h should only be included when CONFIG_SMP is defined.
I will send fix of this.
--
JSR
next prev parent reply other threads:[~2009-01-11 13:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 9:49 Build error on latest git Petr Titera
2009-01-11 11:57 ` Petr Titera
2009-01-11 13:06 ` Jaswinder Singh Rajput [this message]
2009-01-11 13:08 ` Jaswinder Singh Rajput
2009-01-11 13:51 ` Ingo Molnar
2009-01-11 14:54 ` Petr Titera
2009-01-11 15:04 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f9a31f40901110506v646bd599q863be03accbfd8b2@mail.gmail.com \
--to=jaswinderlinux@gmail.com \
--cc=P.Titera@century.cz \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox