From: Jens Axboe <axboe@kernel.dk>
To: Ladvine D Almeida <Ladvine.DAlmeida@synopsys.com>,
"ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Manjunath M Bettegowda <Manjunath.MB@synopsys.com>,
Prabu Thangamuthu <Prabu.T@synopsys.com>,
Tejas Joglekar <Tejas.Joglekar@synopsys.com>,
Joao Pinto <Joao.Pinto@synopsys.com>
Subject: Re: [PATCH] block: Add block level changes for inline encryption
Date: Thu, 31 May 2018 09:46:07 -0600 [thread overview]
Message-ID: <3fc7786c-af85-d047-047f-44d4eded6124@kernel.dk> (raw)
In-Reply-To: <BD7FB879CC136E419544C8E2AE7B9C3020BD90@IN01WEMBXA.internal.synopsys.com>
On 5/31/18 1:47 AM, Ladvine D Almeida wrote:
> On Monday 28 May 2018 04:54 PM, Jens Axboe wrote:
>> On 5/28/18 7:43 AM, Ladvine D Almeida wrote:
>>> This patch introduces new variable under bio structure to
>>> facilitate inline encryption. This variable is used to
>>> associate I/O requests to crypto information.
>> Hard no on this, for two reasons:
>>
>> 1) Any additions to struct bio are scrutinized heavily and
>> need strong justification.
>
> Thanks for sharing your feedback on the patch.
> I am providing reference to an earlier article related to inline encryption support below:
> https://lwn.net/Articles/717754/
Took a quick look, and this looks like a classic case of something
that should just be a cloned bio. If you clone, you own the bi_private
field, which is what you need.
--
Jens Axboe
next prev parent reply other threads:[~2018-05-31 15:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d3624fab-e6fc-f14d-c780-db703c809068@synopsys.com>
[not found] ` <77544032-b6ff-bc5e-9fec-666e66b2cc70@kernel.dk>
2018-05-31 7:47 ` [PATCH] block: Add block level changes for inline encryption Ladvine D Almeida
2018-05-31 15:46 ` Jens Axboe [this message]
2018-06-01 6:27 ` Ladvine D Almeida
2018-06-01 17:30 ` Jens Axboe
[not found] ` <20180601081330.GA13067@infradead.org>
[not found] ` <BD7FB879CC136E419544C8E2AE7B9C3020C566@IN01WEMBXA.internal.synopsys.com>
2018-06-07 1:52 ` Jens Axboe
2018-06-07 6:55 ` Ladvine D Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fc7786c-af85-d047-047f-44d4eded6124@kernel.dk \
--to=axboe@kernel.dk \
--cc=Joao.Pinto@synopsys.com \
--cc=Ladvine.DAlmeida@synopsys.com \
--cc=Manjunath.MB@synopsys.com \
--cc=Prabu.T@synopsys.com \
--cc=Tejas.Joglekar@synopsys.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox