From: Shazad Hussain <quic_shazhuss@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<agross@kernel.org>, <andersson@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>
Cc: <dmitry.baryshkov@linaro.org>, <athierry@redhat.com>,
<robh@kernel.org>, <konrad.dybcio@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-usb@vger.kernel.org>
Subject: Re: [PATCH v2 1/6] dt-bindings: usb: qcom,dwc3: Add bindings for SA8775P
Date: Fri, 28 Apr 2023 19:29:06 +0530 [thread overview]
Message-ID: <3fe4ff88-4640-a348-e88f-ef7d8bcbef19@quicinc.com> (raw)
In-Reply-To: <4b690859-be5a-c331-8243-b875136d4807@linaro.org>
Hi Krzysztof,
On 4/28/2023 6:57 PM, Krzysztof Kozlowski wrote:
> On 28/04/2023 15:08, Shazad Hussain wrote:
>> Add the compatible string for SA8775P SoC from Qualcomm.
>>
>> Signed-off-by: Shazad Hussain <quic_shazhuss@quicinc.com>
>> ---
>
> (...)
>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sa8775p-dwc3
>> + then:
>> + properties:
>> + interrupts:
>> + minItems: 3
>> + maxItems: 4
>> + interrupt-names:
>> + minItems: 3
>> + items:
>> + - const: pwr_event
>> + - const: dp_hs_phy_irq
>> + - const: dm_hs_phy_irq
>> + - const: ss_phy_irq
>
> Why the last interrupt line is optional? Is it really optional?
>
Third usb controller i.e usb_2 supports only high speed, so I believe
ss_phy_irq is not required for that instance.
> Best regards,
> Krzysztof
>
-Shazad
next prev parent reply other threads:[~2023-04-28 13:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 13:08 [PATCH v2 0/6] arm64: qcom: sa8775p: add support for USB Shazad Hussain
2023-04-28 13:08 ` [PATCH v2 1/6] dt-bindings: usb: qcom,dwc3: Add bindings for SA8775P Shazad Hussain
2023-04-28 13:27 ` Krzysztof Kozlowski
2023-04-28 13:59 ` Shazad Hussain [this message]
2023-05-01 6:42 ` Krzysztof Kozlowski
2023-04-28 13:08 ` [PATCH v2 2/6] dt-bindings: phy: qcom,usb-snps-femto-v2: " Shazad Hussain
2023-04-28 13:08 ` [PATCH v2 3/6] dt-bindings: phy: qcom,sc8280xp-qmp-usb3-uni: Add SA8775P USB PHY binding Shazad Hussain
2023-04-28 13:08 ` [PATCH v2 4/6] phy: qcom-qmp: Add SA8775P USB3 UNI phy Shazad Hussain
2023-04-28 19:51 ` Dmitry Baryshkov
2023-04-28 13:08 ` [PATCH v2 5/6] arm64: dts: qcom: sa8775p: add USB nodes Shazad Hussain
2023-04-28 13:08 ` [PATCH v2 6/6] arm64: dts: qcom: sa8775p-ride: enable " Shazad Hussain
2023-05-08 9:30 ` [PATCH v2 0/6] arm64: qcom: sa8775p: add support for USB Vinod Koul
2023-05-15 3:33 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fe4ff88-4640-a348-e88f-ef7d8bcbef19@quicinc.com \
--to=quic_shazhuss@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=athierry@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox