Re: [PATCH 0/4] Add MST support for qcs8300 platform

[Yongxing Mou <quic_yongmou@quicinc.com>]

On 2025/2/12 18:51, Dmitry Baryshkov wrote:
> On Wed, Feb 12, 2025 at 03:12:23PM +0800, Yongxing Mou wrote:
>> This series of patches introduces how to enable MST functionality on
>> the qcs8300 platform.
> 
>> The qcs8300 platform uses dpu_8_4 hardware, which
>> is the same as the sa8775p, but it only has one DPU. So it only has one
>> DP0 controller, supporting 4-stream MST.
> 
> This is irrelevant, unless you want to point out something else.
Got it.
> 
>> This patch only enables
>> 2-stream MST, using intf0 and intf3. The first and second patches are
>> modifications to the correspond dt-bindings, third patch is the dp
>> controller driver after not reuse sm8650, fourth patch is the qcs8300
>> dts modification which add the clk support for stream 1.
> 
> This is obvious. Really. Instead you must explain why QCS8300 isn't
> compatible with SM8650. How many streams are supported by the SM8650?
> 
Got it, will update in new patchset.
>>
>> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
>> ---
>> This patch depends on following series:
>> https://lore.kernel.org/all/20250120-mdssdt_qcs8300-v4-0-1687e7842125@quicinc.com/
>> https://lore.kernel.org/all/20250114-dts_qcs8300-v3-0-d114cc5e4af9@quicinc.com/
>> https://lore.kernel.org/all/20241202-dp_mst_bindings-v1-0-9a9a43b0624a@quicinc.com
>> https://lore.kernel.org/all/20241205-dp_mst-v1-0-f8618d42a99a@quicinc.com/
>>
> 
> Please don't patches against series which were requested to be changed
> singificantly. Don't spam mailing lists just to be able to 'FROMLIST'
> them. Instead work with Abhinav to get this patchset integrated into his
> next iteration of the series.
> 
Emmm, got it, thanks for reminder. Will work with Abhinav to modify the 
MST patchset comments first. And then repost qcs8300 enablement changes.
>> ---
>> Yongxing Mou (4):
>>        dt-bindings: display/msm: Redocument the dp-controller for QCS8300
>>        dt-bindings: display/msm: Add stream 1 pixel clock for QCS8300
>>        drm/msm/dp: Populate the max_streams for qcs8300 mst controller
>>        arm64: dts: qcom: qcs8300: Add support for stream 1 clk for DP MST
>>
>>   .../devicetree/bindings/display/msm/dp-controller.yaml     |  5 +----
>>   .../devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml | 14 ++++++++------
>>   arch/arm64/boot/dts/qcom/qcs8300.dtsi                      | 12 ++++++++----
>>   drivers/gpu/drm/msm/dp/dp_display.c                        |  8 ++++++++
>>   4 files changed, 25 insertions(+), 14 deletions(-)
>> ---
>> base-commit: 7ba9bcc5090556c007d9a718d7176e097fe54f19
>> change-id: 20250211-mst_qcs8300-4c18a5179165
>>
>> Best regards,
>> -- 
>> Yongxing Mou <quic_yongmou@quicinc.com>
>>
>