From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752656AbcFCLrG (ORCPT <rfc822;w@1wt.eu>);
	Fri, 3 Jun 2016 07:47:06 -0400
Received: from ozlabs.org ([103.22.144.67]:46524 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752515AbcFCLrF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 3 Jun 2016 07:47:05 -0400
In-Reply-To: <566929FA.2050409@linux.vnet.ibm.com>
To: xinhui <xinhui.pan@linux.vnet.ibm.com>, linux-kernel@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org
From: Michael Ellerman <mpe@ellerman.id.au>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
        Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
        Hari Bathini <hbathini@linux.vnet.ibm.com>,
        Paul Mackerras <paulus@samba.org>, tglx@linutronix.de,
        Nathan Fontenot <nfont@linux.vnet.ibm.com>
Subject: Re: powerpc/nvram: Fix an incorrect partition merge
Message-Id: <3rLj4P6Swcz9t6B@ozlabs.org>
Date: Fri,  3 Jun 2016 21:47:01 +1000 (AEST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote:
> From: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
> 
> When we merge two contiguous partitions whose signatures are marked
> NVRAM_SIG_FREE, We need update prev's length and checksum, then write it
> to nvram, not cur's. So lets fix this mistake now.
> 
> Also use memset instead of strncpy to set the partition's name. It's
> more readable if we want to fill up with duplicate chars .

Does this ever happen in practice? ie. should we backport the fix to stable
kernels?

Has it always been broken?

cheers