From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Simon Guo <wei.guo.simon@gmail.com>
Cc: Michael Neuling <mikey@neuling.org>,
"Amanieu d'Antras" <amanieu@gmail.com>,
Simon Guo <wei.guo.simon@gmail.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, Cyril Bur <cyrilbur@gmail.com>
Subject: Re: powerpc: set used_vsr/used_vr/used_spe in sigreturn path when MSR bits are active
Date: Tue, 13 Sep 2016 22:16:38 +1000 (AEST) [thread overview]
Message-ID: <3sYNvV5Mb5z9svs@ozlabs.org> (raw)
In-Reply-To: <1469520361-9035-1-git-send-email-wei.guo.simon@gmail.com>
On Tue, 2016-26-07 at 08:06:01 UTC, Simon Guo wrote:
> From: Simon Guo <wei.guo.simon@gmail.com>
>
> Normally, when MSR[VSX/VR/SPE] bits = 1, the used_vsr/used_vr/used_spe
> bit have already been set. However signal frame locates at user space
> and it is controlled by user application. It is up to kernel to make
> sure used_vsr/used_vr/used_spe(in kernel)=1 and consistent with MSR
> bits.
>
> For example, CRIU application, who utilizes sigreturn to restore
> checkpointed process, will lead to the case where MSR[VSX] bit is
> active in signal frame, but used_vsx bit is not set. (the same applies
> to VR/SPE).
>
> This patch will reinforce this at kernel by always setting used_* bit
> when MSR related bits are active in signal frame and we are doing
> sigreturn.
>
> This patch is based on Ben's Proposal.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Simon Guo <wei.guo.simon@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/e1c0d66fcb179a1737b3d5cc11
cheers
prev parent reply other threads:[~2016-09-13 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 8:06 [PATCH] powerpc: set used_vsr/used_vr/used_spe in sigreturn path when MSR bits are active wei.guo.simon
2016-09-11 13:58 ` Simon Guo
2016-09-13 12:16 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3sYNvV5Mb5z9svs@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=amanieu@gmail.com \
--cc=anton@samba.org \
--cc=cyrilbur@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
--cc=wei.guo.simon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox