From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [v4,2/6] powerpc: ftrace: restore LR from pt_regs
Date: Tue, 25 Apr 2017 08:47:29 +1000 (AEST) [thread overview]
Message-ID: <3wBhLT756kz9s8S@ozlabs.org> (raw)
In-Reply-To: <5aa5ca47d531a530285fe5b453f6921d0960bde3.1492606062.git.naveen.n.rao@linux.vnet.ibm.com>
On Wed, 2017-04-19 at 12:52:24 UTC, "Naveen N. Rao" wrote:
> Pass the real LR to the ftrace handler. This is needed for
> KPROBES_ON_FTRACE for the pre handlers.
>
> Also, with KPROBES_ON_FTRACE, the link register may be updated by the
> pre handlers or by a registed kretprobe. Honor updated LR by restoring
> it from pt_regs, rather than from the stack save area.
>
> Live patch and function graph continue to work fine with this change.
>
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/2f59be5b970b503ca8db1cb723b155
cheers
next prev parent reply other threads:[~2017-04-24 22:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 12:52 [PATCH v4 0/6] powerpc: add support for KPROBES_ON_FTRACE Naveen N. Rao
[not found] ` <cover.1492606062.git.naveen.n.rao@linux.vnet.ibm.com>
2017-04-19 12:52 ` [PATCH v4 1/6] powerpc: ftrace: minor cleanup Naveen N. Rao
2017-04-23 11:53 ` [v4,1/6] " Michael Ellerman
2017-04-19 12:52 ` [PATCH v4 2/6] powerpc: ftrace: restore LR from pt_regs Naveen N. Rao
2017-04-24 22:47 ` Michael Ellerman [this message]
2017-04-19 12:52 ` [PATCH v4 3/6] kprobes: Skip preparing optprobe if the probe is ftrace-based Naveen N. Rao
2017-04-24 22:47 ` [v4, " Michael Ellerman
2017-04-19 12:52 ` [PATCH v4 4/6] powerpc: kprobes: add support for KPROBES_ON_FTRACE Naveen N. Rao
2017-04-24 22:47 ` [v4,4/6] " Michael Ellerman
2017-04-19 12:52 ` [PATCH v4 5/6] powerpc: introduce a new helper to obtain function entry points Naveen N. Rao
2017-04-24 22:47 ` [v4, " Michael Ellerman
2017-04-19 12:52 ` [PATCH v4 6/6] powerpc: kprobes: prefer ftrace when probing function entry Naveen N. Rao
2017-04-24 22:47 ` [v4,6/6] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3wBhLT756kz9s8S@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox