From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752093AbbJWUQk (ORCPT <rfc822;w@1wt.eu>);
	Fri, 23 Oct 2015 16:16:40 -0400
Received: from mout.kundenserver.de ([212.227.17.13]:49678 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750765AbbJWUQi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 23 Oct 2015 16:16:38 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>, arm@kernel.org,
        Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org,
        Russell King <linux@arm.linux.org.uk>, Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH 2/4] ARM: dts: uniphier: delete i2c aliases
Date: Fri, 23 Oct 2015 22:16:29 +0200
Message-ID: <4000897.7Un1B3qMyp@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1445427390-22750-3-git-send-email-yamada.masahiro@socionext.com>
References: <1445427390-22750-1-git-send-email-yamada.masahiro@socionext.com> <1445427390-22750-3-git-send-email-yamada.masahiro@socionext.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:4hRvihL8mcHJNugT7Hs6IAvum2D3P1wLU2geVpX9W277iP1e2yu
 ZzVYNHxIdUV+UMLl22kjERmzFdaPZ3EJX5yyzXoeQCTjBdV5entNypGnIx9zcOxRdArnA0v
 zO7Fm36yNhK815ZjFVhNwl3POVNGQIGpeHsFFM+F/lIcRwD3Bh3d1z/52UdoRAYuoNhcPBk
 D+qpbHLkpP/lXvbLs0mmA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:cRQ/t5Jvsio=:WsYkcUDOfzoQEh10ANyeT1
 pEkkhwNJgo9fozpfbgnRFmNhRL7pJg4NilrMhus0Nu93/WWvfCMsiY/GHWprXIHPdXEE4jKJn
 L2gfwehQQUYZTk8a2oX/v6LMHY1d0YpfBTfKvMf713gjmdw4hcd4K7uEZXbbC33ngS5fyx588
 xRKskpa/2v45Sqn5f7R+eYeUm/3rrPO71LqtlWw6tD2NfD7c6AZumnLnGjq44DMa3fkSOAEHB
 ddhS6bHL6u9wjbZdsfM99pW7LqGZLDu+dCLF4y6ajj2C+CwvYLG+Wr6YPlxhdAHgYsuU5iD+7
 3uXMwuXa0zjNxcfrRH7e9qlFYwtPpzeSSiVkB2+uEAGck7rwPtqAMNW+5Nog+OWITP0wlPMef
 r3gDTy6OOAVoE6/DM8zaAise9j7WBX24XAizyU0QYN60w4gMhXqyivAGBxqMT4wQm29Qfi5iP
 b4eo24zVICwwjzK1OGZ9sq3MIlNrjVdXHt85+oeHKUu/LEjF/Wu/CZilvZ37Www3R++kAbtL3
 qD7VhNuMX7DZTtHfxh16QnlAR9/jCWjsvKTC6x3J49UTnKb/7vdsvLG6hfWzhVhIOSP9mmfjt
 60MQ+WVKa8jOD13GEF6EsPyZrO6kNzWXLdG7TY15eG/jNgMwgNjqG9LOhrb0wiK1oVWPXUq4K
 tvtHcxedXrPX6y2/HKmywAbynVvizm9BrMerKQUNpPoDUHSVWwLVw6VXq9JhgOlkLiiq4j5Oz
 P33NxIvEUHCCxnA8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday 21 October 2015 20:36:28 Masahiro Yamada wrote:
> The user space should not expect that a particular I2C channel is
> always visible through the same character device.
> No reason to fix the I2C indexes with aliases.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> 

As I said in my reply to the earlier mail, I didn't really like the
idea of having holes in the numbering for the i2c controllers, but
this new approach also doesn't look ideal.

We should have stable bus numbers on any given board, and the aliases
work well for that. I just don't think the aliases need to be stable
between different boards just because they are based on the same
SoC.

I'd suggest staying with the current slightly awkward approach though,
to avoid regressions. Please send a follow-up patch to add the same
aliases on the new boards and drop this patch, unless someone else
can come up with a better idea.

	Arnd