public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Brodsky <kevin.brodsky@arm.com>
To: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 6/6] powerpc/64s: Do not re-activate batched TLB flush
Date: Tue, 7 Oct 2025 16:33:42 +0200	[thread overview]
Message-ID: <4001ebcc-7516-4bea-a920-8750f029b442@arm.com> (raw)
In-Reply-To: <68e4e0f8.050a0220.1e89ea.1c6f@mx.google.com>

On 07/10/2025 11:40, Ritesh Harjani (IBM) wrote:
> Kevin Brodsky <kevin.brodsky@arm.com> writes:
>
>> On 17/06/2025 17:11, Alexander Gordeev wrote:
>>> On Thu, Jun 12, 2025 at 07:36:13PM +0200, Alexander Gordeev wrote:
>>>> Since commit b9ef323ea168 ("powerpc/64s: Disable preemption in hash
>>>> lazy mmu mode") a task can not be preempted while in lazy MMU mode.
>>>> Therefore, the batch re-activation code is never called, so remove it.
>>>>
>>>> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
>>>> ---
>>>>  arch/powerpc/include/asm/thread_info.h |  2 --
>>>>  arch/powerpc/kernel/process.c          | 25 -------------------------
>>>>  2 files changed, 27 deletions(-)
>>> Hi All,
>>>
>>> (I trimmed non-ppc mailing lists/people).
>>>
>>> The whole series does not seem to make it, but this patch alone is still
>>> applicable and makes sence, if I am not mistaken.
>> Yes, I agree. I arrived at the same conclusion working on the next
>> version of the nested lazy_mmu series [1].
>> [1]
>> https://lore.kernel.org/all/20250908073931.4159362-1-kevin.brodsky@arm.com/
> Yes, we disable preemption while in lazy mmu mode for Hash, so I agree that
> we won't call into __switch_to() in between preempt_disable()/_enable().
> So it does look like that we don't need that code.

Thanks for confirming.

>> May I include this patch in v3?
>>
> That should be ok.

Thanks!

- Kevin

      reply	other threads:[~2025-10-07 14:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12 17:36 [PATCH 0/6] mm: Consolidate lazy MMU mode context Alexander Gordeev
2025-06-12 17:36 ` [PATCH 1/6] mm: Cleanup apply_to_pte_range() routine Alexander Gordeev
2025-06-12 17:36 ` [PATCH 2/6] mm: Lock kernel page tables before entering lazy MMU mode Alexander Gordeev
2025-06-13  8:26   ` Ryan Roberts
2025-06-13 10:32   ` Uladzislau Rezki
2025-06-18 17:32   ` Dan Carpenter
2025-06-19  9:53     ` Uladzislau Rezki
2025-06-12 17:36 ` [PATCH 3/6] mm/debug: Detect wrong arch_enter_lazy_mmu_mode() contexts Alexander Gordeev
2025-06-12 17:36 ` [PATCH 4/6] sparc/mm: Do not disable preemption in lazy MMU mode Alexander Gordeev
2025-06-13  8:40   ` Ryan Roberts
2025-06-12 17:36 ` [PATCH 5/6] powerpc/64s: " Alexander Gordeev
2025-06-12 17:36 ` [PATCH 6/6] powerpc/64s: Do not re-activate batched TLB flush Alexander Gordeev
2025-06-17 15:11   ` Alexander Gordeev
2025-10-03  9:38     ` Kevin Brodsky
2025-10-07  9:40       ` Ritesh Harjani
2025-10-07 14:33         ` Kevin Brodsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4001ebcc-7516-4bea-a920-8750f029b442@arm.com \
    --to=kevin.brodsky@arm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=ritesh.list@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox