public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: Michael Rubin <mrubin@google.com>, Peter Zijlstra <peterz@infradead.org>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 13/13] writeback: cleanup __sync_single_inode()
Date: Tue, 15 Jan 2008 20:36:50 +0800	[thread overview]
Message-ID: <400401294.20012@ustc.edu.cn> (raw)
Message-ID: <20080115124803.025520828@mail.ustc.edu.cn> (raw)
In-Reply-To: 20080115123637.518924046@mail.ustc.edu.cn

[-- Attachment #1: writeback-simplify-x.patch --]
[-- Type: text/plain, Size: 1350 bytes --]

Make the if-else straight in __sync_single_inode().
No behavior change.

Cc: Michael Rubin <mrubin@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
---
 fs/fs-writeback.c |   15 +++++++--------
 1 files changed, 7 insertions(+), 8 deletions(-)

--- linux-mm.orig/fs/fs-writeback.c
+++ linux-mm/fs/fs-writeback.c
@@ -254,8 +254,13 @@ __sync_single_inode(struct inode *inode,
 	spin_lock(&inode_lock);
 	inode->i_state &= ~I_SYNC;
 	if (!(inode->i_state & I_FREEING)) {
-		if (!(inode->i_state & I_DIRTY) &&
-		    mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) {
+		if (inode->i_state & I_DIRTY) {
+			/*
+			 * Someone redirtied the inode while were writing back
+			 * the pages.
+			 */
+			requeue_io(inode);
+		} else if (mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) {
 			/*
 			 * We didn't write back all the pages.  nfs_writepages()
 			 * sometimes bales out without doing anything.
@@ -272,12 +277,6 @@ __sync_single_inode(struct inode *inode,
 				 * 2) fast writer during sync: give others a try
 				 */
 				requeue_io_wait(inode);
-		} else if (inode->i_state & I_DIRTY) {
-			/*
-			 * Someone redirtied the inode while were writing back
-			 * the pages.
-			 */
-			requeue_io(inode);
 		} else if (atomic_read(&inode->i_count)) {
 			/*
 			 * The inode is clean, inuse

-- 

  parent reply	other threads:[~2008-01-15 12:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080115123637.518924046@mail.ustc.edu.cn>
2008-01-15 12:36 ` [PATCH 00/13] writeback bug fixes and simplifications take 2 Fengguang Wu
2008-01-15 18:33   ` Michael Rubin
     [not found]     ` <E1JExrc-00014E-FC@localhost.localdomain>
2008-01-16  2:18       ` Fengguang Wu
2008-01-18  7:51   ` Michael Rubin
     [not found]     ` <E1JFmZs-0000wa-3r@localhost.localdomain>
2008-01-18  8:27       ` Fengguang Wu
     [not found] ` <20080115124758.142052041@mail.ustc.edu.cn>
2008-01-15 12:36   ` [PATCH 01/13] writeback: revert 2e6883bdf49abd0e7f0d9b6297fc3be7ebb2250b Fengguang Wu
     [not found] ` <20080115124758.559626681@mail.ustc.edu.cn>
2008-01-15 12:36   ` [PATCH 02/13] writeback: clear PAGECACHE_TAG_DIRTY for truncated page in block_write_full_page() Fengguang Wu
     [not found] ` <20080115124758.972567524@mail.ustc.edu.cn>
2008-01-15 12:36   ` [PATCH 03/13] writeback: introduce writeback_control.more_io Fengguang Wu
     [not found] ` <20080115124759.398587485@mail.ustc.edu.cn>
2008-01-15 12:36   ` [PATCH 04/13] writeback: introduce super_block.s_more_io_wait Fengguang Wu
     [not found] ` <20080115124759.770126448@mail.ustc.edu.cn>
2008-01-15 12:36   ` [PATCH 05/13] writeback: merge duplicate code into writeback_some_pages() Fengguang Wu
     [not found] ` <20080115124800.190056249@mail.ustc.edu.cn>
2008-01-15 12:36   ` [PATCH 06/13] writeback: defer writeback on not-all-pages-written Fengguang Wu
     [not found] ` <20080115124800.602843975@mail.ustc.edu.cn>
2008-01-15 12:36   ` [PATCH 07/13] writeback: defer writeback on locked inode Fengguang Wu
     [not found] ` <20080115124801.012754821@mail.ustc.edu.cn>
2008-01-15 12:36   ` [PATCH 08/13] writeback: defer writeback on locked buffers Fengguang Wu
     [not found] ` <20080115124801.800688912@mail.ustc.edu.cn>
2008-01-15 12:36   ` [PATCH 10/13] writeback: introduce queue_dirty() Fengguang Wu
     [not found] ` <20080115124802.215191468@mail.ustc.edu.cn>
2008-01-15 12:36   ` [PATCH 11/13] writeback: queue_dirty() on memory-backed bdi Fengguang Wu
     [not found] ` <20080115124802.624775214@mail.ustc.edu.cn>
2008-01-15 12:36   ` [PATCH 12/13] writeback: remove redirty_tail() Fengguang Wu
     [not found] ` <20080115124803.025520828@mail.ustc.edu.cn>
2008-01-15 12:36   ` Fengguang Wu [this message]
     [not found] ` <20080115124801.430525129@mail.ustc.edu.cn>
2008-01-15 12:36   ` [PATCH 09/13] writeback: requeue_io() on redirtied inode Fengguang Wu
2008-01-16  8:13   ` David Chinner
     [not found]     ` <E1JFMH1-0001xA-L1@localhost.localdomain>
2008-01-17  4:22       ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=400401294.20012@ustc.edu.cn \
    --to=wfg@mail.ustc.edu.cn \
    --cc=akpm@osdl.org \
    --cc=mrubin@google.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox