[Outreachy kernel] [PATCH] mtd: nand: Added spaces around ('=' and '<')

[Outreachy kernel] [PATCH] mtd: nand: Added spaces around ('=' and '<')

[Arushi Singhal]

Add spaces around ('=' and '<'),  to conform to the Linux
kernel coding style. Issue found using checkpatch.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 drivers/mtd/nand/ams-delta.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/ams-delta.c b/drivers/mtd/nand/ams-delta.c
index d60ada4..9de6572 100644
--- a/drivers/mtd/nand/ams-delta.c
+++ b/drivers/mtd/nand/ams-delta.c
@@ -94,7 +94,7 @@ static void ams_delta_write_buf(struct mtd_info *mtd, const u_char *buf,
 {
 	int i;
 
-	for (i=0; i<len; i++)
+	for (i = 0; i < len; i++)
 		ams_delta_write_byte(mtd, buf[i]);
 }
 
@@ -102,7 +102,7 @@ static void ams_delta_read_buf(struct mtd_info *mtd, u_char *buf, int len)
 {
 	int i;
 
-	for (i=0; i<len; i++)
+	for (i = 0; i < len; i++)
 		buf[i] = ams_delta_read_byte(mtd);
 }
 
-- 
2.7.4

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
To post to this group, send email to outreachy-kernel@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180303140233.GA9634%40seema-Inspiron-15-3567.
For more options, visit https://groups.google.com/d/optout.

[Outreachy kernel] Re: [PATCH] mtd: nand: Added spaces around ('=' and '<')

[Richard Weinberger]

Arushi Singhal,

Am Samstag, 3. März 2018, 15:02:33 CET schrieb Arushi Singhal:
> Add spaces around ('=' and '<'),  to conform to the Linux
> kernel coding style. Issue found using checkpatch.

please fix real issues. Coding style fixes to existing code just add too much 
churn. Except for drivers/staging/.

If you're looking for a small MTD related project, I can offer the following.
Cleanup all ubi_assert()s in drivers/mtd/ubi/.
Some of them need to be transformed into a meaningful warning/error message, 
others into a hard error, such as WARN_ON().
Review/understand every ubi_assert() and convert it.

Thanks,
//richard 

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
To post to this group, send email to outreachy-kernel@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/2872216.aoWXzO2rYL%40blindfold.
For more options, visit https://groups.google.com/d/optout.

[Outreachy kernel] Re: [PATCH] mtd: nand: Added spaces around ('=' and '<')

[Arushi Singhal]

[-- Attachment #1: Type: text/plain, Size: 1709 bytes --]

On Mon, Mar 5, 2018 at 9:12 PM, Richard Weinberger <richard@nod.at> wrote:

> Arushi Singhal,
>
> Am Samstag, 3. März 2018, 15:02:33 CET schrieb Arushi Singhal:
> > Add spaces around ('=' and '<'),  to conform to the Linux
> > kernel coding style. Issue found using checkpatch.
>
> please fix real issues. Coding style fixes to existing code just add too
> much
> churn. Except for drivers/staging/.
>

Hello Richard
Thanks for explaining,


>
> If you're looking for a small MTD related project, I can offer the
> following.
> Cleanup all ubi_assert()s in drivers/mtd/ubi/.
> Some of them need to be transformed into a meaningful warning/error
> message,
> others into a hard error, such as WARN_ON().
> Review/understand every ubi_assert() and convert it.
>

Before doing this task, I read about this discussion (
http://lists.infradead.org/pipermail/linux-mtd/2014-November/056352.html ).
In this discussion it is decided to split ubi_assert() into two different
functions, BUG_ON() and WARN_ON(). Even some of the asserts can be removed
too.

Hope, I am not missing anything.

Thanks
Arushi


>
> Thanks,
> //richard
>

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
To post to this group, send email to outreachy-kernel@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF-2K48uEPHhgoH4K%2B4X0Gnr%3DS3VaG4-VeZ9urfsNEf3QQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: Type: text/html, Size: 2990 bytes --]

[Outreachy kernel] Re: [PATCH] mtd: nand: Added spaces around ('=' and '<')

[Richard Weinberger]

Arushi,

Am Mittwoch, 7. März 2018, 16:38:50 CET schrieb Arushi Singhal:
> On Mon, Mar 5, 2018 at 9:12 PM, Richard Weinberger <richard@nod.at> wrote:
> > Arushi Singhal,
> > 
> > Am Samstag, 3. März 2018, 15:02:33 CET schrieb Arushi Singhal:
> > > Add spaces around ('=' and '<'),  to conform to the Linux
> > > kernel coding style. Issue found using checkpatch.
> > 
> > please fix real issues. Coding style fixes to existing code just add too
> > much
> > churn. Except for drivers/staging/.
> 
> Hello Richard
> Thanks for explaining,
> 
> > If you're looking for a small MTD related project, I can offer the
> > following.
> > Cleanup all ubi_assert()s in drivers/mtd/ubi/.
> > Some of them need to be transformed into a meaningful warning/error
> > message,
> > others into a hard error, such as WARN_ON().
> > Review/understand every ubi_assert() and convert it.
> 
> Before doing this task, I read about this discussion (
> http://lists.infradead.org/pipermail/linux-mtd/2014-November/056352.html ).
> In this discussion it is decided to split ubi_assert() into two different
> functions, BUG_ON() and WARN_ON(). Even some of the asserts can be removed
> too.

Very good! You managed to exhume my forgotten TODOs. ;-)

One comment on BUG_ON(), we have to make very sure that it is not user 
trigger-able.

Thanks,
//richard  

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
To post to this group, send email to outreachy-kernel@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/4005910.RbgyVDuFdx%40blindfold.
For more options, visit https://groups.google.com/d/optout.