From: Bill Davidsen <davidsen@tmr.com>
To: Andries Brouwer <aebr@win.tue.nl>
Cc: Linux Kernel mailing List <linux-kernel@vger.kernel.org>
Subject: Re: PATCH 1/2: Make gotoxy & siblings use unsigned variables
Date: Fri, 16 Jan 2004 13:41:22 -0500 [thread overview]
Message-ID: <40083052.80703@tmr.com> (raw)
In-Reply-To: <1cbAw-2BB-27@gated-at.bofh.it>
Andries Brouwer wrote:
>>>Shouldn't we be using "size_t" for unsigned int
>
>
>>You might be right. I was just being consistent with the other definitions.
>
>
> These are character positions on a screen.
> When did you last see a console in text mode with a line length
> of more than 2^31 ?
>
> If you go for a minimal patch then you should replace "char"
> in one or two places by "unsigned char" and that is all.
Are these screen positions or offsets into the string for the line? The
reason I ask is that with a 2-byte character set no char is going to do
the latter reliably, not only do people run 132 col mode with vt100
windows, just hitting the "full screen" button with most WM will give
you >127 columns.
--
bill davidsen <davidsen@tmr.com>
CTO TMR Associates, Inc
Doing interesting things with small computers since 1979
next parent reply other threads:[~2004-01-16 18:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1c9S3-75-23@gated-at.bofh.it>
[not found] ` <1cauN-131-17@gated-at.bofh.it>
[not found] ` <1cb7n-1Z6-17@gated-at.bofh.it>
[not found] ` <1cbAw-2BB-27@gated-at.bofh.it>
2004-01-16 18:41 ` Bill Davidsen [this message]
2004-01-16 18:54 ` PATCH 1/2: Make gotoxy & siblings use unsigned variables Nigel Cunningham
2004-01-09 18:33 Nigel Cunningham
2004-01-09 19:22 ` Richard B. Johnson
2004-01-09 19:43 ` Nigel Cunningham
2004-01-09 20:33 ` Andries Brouwer
2004-01-09 21:26 ` Nigel Cunningham
2004-01-10 3:34 ` Edgar Toernig
2004-01-13 21:57 ` Pavel Machek
2004-01-09 21:32 ` Andrew Morton
2004-01-09 21:38 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40083052.80703@tmr.com \
--to=davidsen@tmr.com \
--cc=aebr@win.tue.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox