Re: CPU Hotplug: Hotplug Script And SIGPWR

Tim Hockin
2004-01-21T07:42:47Z

On Wed, Jan 21, 2004 at 06:31:06PM +1100, Nick Piggin wrote:
> >If hotplug scripts are failing, you're in really deep trouble. I can't
> >find
> >a single case where a hotplug script failing would not indicate some other
> >larger failure.
> >
>
> sigh. threads-max, pid_max, ulimit, -ENOMEM, oom.

These affect ALL hotplug scripts. If you can't run a hotplug script because
you've exceeded root's ulimit, or the max # of tasks/threads in the system,
you're in trouble - regardless of what the hotplug event was - SOMETHING is
going to go wrong.

If you get ENOMEM you have a bigger problem.

If you get OOM killed, then the OOM killer has gone haywire (not uncommon,
historically).

> I'd rather not add something that, by design can hang any number of
> processes
> including the entire system if a hotplug script fails. Thats just my honest
> opinion, I know its rare enough it probably would never happen to anyone.
>
> Sorry I keep repeating this, its not my call and its never going to affect
> me so I'll shut up now ;)

I'd rather not add anything like that either. I'm not saying I advocate
fast-and-loose at all. On the contrary, I think any action taken in
response to a CPU removal needs to be accountable, and wantonly changing
affinity is NOT.

It'll probably not affect me either, nor is it my decision :)