From: Patrick Gefre <pfg@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: akpm@osdl.org, davidm@napali.hpl.hp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6] Altix updates
Date: Tue, 20 Jan 2004 11:50:19 -0600 [thread overview]
Message-ID: <400D6A5B.7090009@sgi.com> (raw)
In-Reply-To: <20040116144132.A24555@infradead.org>
Christoph Hellwig wrote:
>On Thu, Jan 15, 2004 at 03:54:37PM -0600, Pat Gefre wrote:
>
>
>>001-reorg.patch
>>002-reorg1.patch
>>
>>
>
>The IS_IOADDR() stuff in the accesor funcs in pcibr_reg.c is completly
>bogus, please decide whether you want to pass a pointer to the pcibr_soft
>or bridge_t to it instead of doing second-guessing.
>
>
>
Yes this probably looks a little odd. This was setup this way for TIO.
The macro in the TIO code checks to see
if it is a 'soft' struct or bridge address AND what bridge type it is -
accessing different registers depending
on TIO or not TIO (the 2 cases we have so far). We think this makes the
register access functions pretty flexible/generic.
>Also while the pic.h changes look okay they will conflict with a patch
>I'm about to send that adds common headers for the bridge/xbow/xwidget
>register for mips and IA64. Can you send me a version of pic.h with
>those changes and the big endian ifdefs back in so I can just incorporate
>the new version into my patch?
>
>
>
OK - I'll look into getting this for you.
>Also are all those access you abstract away different in TIOCP? If not
>please don't add the wrappers for them.
>
>
next prev parent reply other threads:[~2004-01-20 17:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-15 21:54 [PATCH 2.6] Altix updates Pat Gefre
2004-01-16 2:34 ` Andrew Morton
2004-01-16 14:41 ` Christoph Hellwig
2004-01-20 17:50 ` Patrick Gefre [this message]
2004-01-20 18:08 ` Christoph Hellwig
2004-01-20 20:12 ` Patrick Gefre
2004-01-20 20:21 ` Christoph Hellwig
2004-01-20 22:23 ` Patrick Gefre
2004-01-20 23:34 ` Christoph Hellwig
2004-01-21 0:23 ` Patrick Gefre
2004-01-21 0:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=400D6A5B.7090009@sgi.com \
--to=pfg@sgi.com \
--cc=akpm@osdl.org \
--cc=davidm@napali.hpl.hp.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox