From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: Gao Xiang <hsiangkao@linux.alibaba.com>,
xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org,
huyue2@coolpad.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] erofs: update print symbols for various flags in trace
Date: Thu, 9 Feb 2023 10:30:45 +0800 [thread overview]
Message-ID: <400c57ca-2804-a660-e543-42e15ac3b4a4@linux.alibaba.com> (raw)
In-Reply-To: <416afeb8-4385-6d8a-4b35-2c75ffaa36cc@linux.alibaba.com>
On 2/9/23 10:29 AM, Gao Xiang wrote:
>
>
> On 2023/2/8 19:29, Jingbo Xu wrote:
>> As new flags introduced, the corresponding print symbols for trace are
>> not added accordingly. Add these missing print symbols for these flags.
>>
>> Also remove the print symbol for EROFS_GET_BLOCKS_RAW as it is going to
>> be removed soon.
>>
>> Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
>> ---
>> v2: remove print symbol for EROFS_GET_BLOCKS_RAW
>> ---
>> include/trace/events/erofs.h | 13 +++++++++----
>> 1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/trace/events/erofs.h b/include/trace/events/erofs.h
>> index e095d36db939..cf4a0d28b178 100644
>> --- a/include/trace/events/erofs.h
>> +++ b/include/trace/events/erofs.h
>> @@ -19,12 +19,17 @@ struct erofs_map_blocks;
>> { 1, "DIR" })
>> #define show_map_flags(flags) __print_flags(flags, "|", \
>> - { EROFS_GET_BLOCKS_RAW, "RAW" })
>
> Should we remove this in the next patch?
> Otherwise it looks good to me.
>
Okay I will update this in the next version.
--
Thanks,
Jingbo
prev parent reply other threads:[~2023-02-09 2:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 11:29 [PATCH v2 1/2] erofs: update print symbols for various flags in trace Jingbo Xu
2023-02-08 11:29 ` [PATCH v2 2/2] erofs: remove unused EROFS_GET_BLOCKS_RAW flag Jingbo Xu
2023-02-09 2:29 ` [PATCH v2 1/2] erofs: update print symbols for various flags in trace Gao Xiang
2023-02-09 2:30 ` Jingbo Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=400c57ca-2804-a660-e543-42e15ac3b4a4@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=huyue2@coolpad.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox