From: Steve Lord <stephen.lord@adic.com>
To: "Måns Rullgård" <mru@kth.se>
Cc: linux-kernel@vger.kernel.org, Nathan Scott <nathans@sgi.com>,
davej@redhat.com
Subject: Re: logic error in XFS
Date: Fri, 23 Jan 2004 09:55:56 -0600 [thread overview]
Message-ID: <4011440C.4070803@adic.com> (raw)
In-Reply-To: <yw1xr7xr80wi.fsf@adic.com>
Måns Rullgård wrote:
>davej@redhat.com writes:
>
>
>
>>Yet another misplaced ! by the looks..
>>
>>
>
>Sure looks like it. When is this code encountered?
>
>
File system recovery, it is going to insert buffer items out of order in
the recovery sequence which means replay could be out of order.
Its been there since around September by the look of it. Definitely should
be the other way around. Thanks Dave.
Steve
>
>
>>diff -urpN --exclude-from=/home/davej/.exclude bk-linus/fs/xfs/xfs_log_recover.c linux-2.5/fs/xfs/xfs_log_recover.c
>>--- bk-linus/fs/xfs/xfs_log_recover.c 2003-10-09 01:01:24.000000000 +0100
>>+++ linux-2.5/fs/xfs/xfs_log_recover.c 2004-01-14 07:06:40.000000000 +0000
>>@@ -1553,7 +1553,7 @@ xlog_recover_reorder_trans(
>> case XFS_LI_BUF:
>> case XFS_LI_6_1_BUF:
>> case XFS_LI_5_3_BUF:
>>- if ((!flags & XFS_BLI_CANCEL)) {
>>+ if (!(flags & XFS_BLI_CANCEL)) {
>> xlog_recover_insert_item_frontq(&trans->r_itemq,
>> itemq);
>> break;
>>
>>
>
>
>
--
Steve Lord <Stephen.Lord@adic.com> Tel: 952-882-0619
next prev parent reply other threads:[~2004-01-23 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-23 6:35 logic error in XFS davej
2004-01-23 9:33 ` Måns Rullgård
[not found] ` <yw1xr7xr80wi.fsf@adic.com>
2004-01-23 15:55 ` Steve Lord [this message]
2004-01-24 0:41 ` Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4011440C.4070803@adic.com \
--to=stephen.lord@adic.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mru@kth.se \
--cc=nathans@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox