logic error in XFS

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* logic error in XFS
@ 2004-01-23  6:35 davej
  2004-01-23  9:33 ` Måns Rullgård
  2004-01-24  0:41 ` Nathan Scott
  0 siblings, 2 replies; 4+ messages in thread
From: davej @ 2004-01-23  6:35 UTC (permalink / raw)
  To: linux-kernel; +Cc: torvalds, akpm, nathans

Yet another misplaced ! by the looks..

    Dave

diff -urpN --exclude-from=/home/davej/.exclude bk-linus/fs/xfs/xfs_log_recover.c linux-2.5/fs/xfs/xfs_log_recover.c
--- bk-linus/fs/xfs/xfs_log_recover.c	2003-10-09 01:01:24.000000000 +0100
+++ linux-2.5/fs/xfs/xfs_log_recover.c	2004-01-14 07:06:40.000000000 +0000
@@ -1553,7 +1553,7 @@ xlog_recover_reorder_trans(
 		case XFS_LI_BUF:
 		case XFS_LI_6_1_BUF:
 		case XFS_LI_5_3_BUF:
-			if ((!flags & XFS_BLI_CANCEL)) {
+			if (!(flags & XFS_BLI_CANCEL)) {
 				xlog_recover_insert_item_frontq(&trans->r_itemq,
 								itemq);
 				break;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: logic error in XFS
  2004-01-23  6:35 logic error in XFS davej
@ 2004-01-23  9:33 ` Måns Rullgård
       [not found]   ` <yw1xr7xr80wi.fsf@adic.com>
  2004-01-24  0:41 ` Nathan Scott
  1 sibling, 1 reply; 4+ messages in thread
From: Måns Rullgård @ 2004-01-23  9:33 UTC (permalink / raw)
  To: linux-kernel

davej@redhat.com writes:

> Yet another misplaced ! by the looks..

Sure looks like it.  When is this code encountered?

> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/fs/xfs/xfs_log_recover.c linux-2.5/fs/xfs/xfs_log_recover.c
> --- bk-linus/fs/xfs/xfs_log_recover.c	2003-10-09 01:01:24.000000000 +0100
> +++ linux-2.5/fs/xfs/xfs_log_recover.c	2004-01-14 07:06:40.000000000 +0000
> @@ -1553,7 +1553,7 @@ xlog_recover_reorder_trans(
>  		case XFS_LI_BUF:
>  		case XFS_LI_6_1_BUF:
>  		case XFS_LI_5_3_BUF:
> -			if ((!flags & XFS_BLI_CANCEL)) {
> +			if (!(flags & XFS_BLI_CANCEL)) {
>  				xlog_recover_insert_item_frontq(&trans->r_itemq,
>  								itemq);
>  				break;

-- 
Måns Rullgård
mru@kth.se


^ permalink raw reply	[flat|nested] 4+ messages in thread

[parent not found: <yw1xr7xr80wi.fsf@adic.com>]

* Re: logic error in XFS
       [not found]   ` <yw1xr7xr80wi.fsf@adic.com>
@ 2004-01-23 15:55     ` Steve Lord
  0 siblings, 0 replies; 4+ messages in thread
From: Steve Lord @ 2004-01-23 15:55 UTC (permalink / raw)
  To: Måns Rullgård; +Cc: linux-kernel, Nathan Scott, davej

Måns Rullgård wrote:

>davej@redhat.com writes:
>
>  
>
>>Yet another misplaced ! by the looks..
>>    
>>
>
>Sure looks like it.  When is this code encountered?
>  
>

File system recovery, it is going to insert buffer items out of order in
the recovery sequence which means replay could be out of order.
Its been there since around September by the look of it. Definitely should
be the other way around. Thanks Dave.

Steve

>  
>
>>diff -urpN --exclude-from=/home/davej/.exclude bk-linus/fs/xfs/xfs_log_recover.c linux-2.5/fs/xfs/xfs_log_recover.c
>>--- bk-linus/fs/xfs/xfs_log_recover.c	2003-10-09 01:01:24.000000000 +0100
>>+++ linux-2.5/fs/xfs/xfs_log_recover.c	2004-01-14 07:06:40.000000000 +0000
>>@@ -1553,7 +1553,7 @@ xlog_recover_reorder_trans(
>> 		case XFS_LI_BUF:
>> 		case XFS_LI_6_1_BUF:
>> 		case XFS_LI_5_3_BUF:
>>-			if ((!flags & XFS_BLI_CANCEL)) {
>>+			if (!(flags & XFS_BLI_CANCEL)) {
>> 				xlog_recover_insert_item_frontq(&trans->r_itemq,
>> 								itemq);
>> 				break;
>>    
>>
>
>  
>


-- 
Steve Lord <Stephen.Lord@adic.com>                Tel: 952-882-0619


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: logic error in XFS
  2004-01-23  6:35 logic error in XFS davej
  2004-01-23  9:33 ` Måns Rullgård
@ 2004-01-24  0:41 ` Nathan Scott
  1 sibling, 0 replies; 4+ messages in thread
From: Nathan Scott @ 2004-01-24  0:41 UTC (permalink / raw)
  To: davej, marcelo.tosatti; +Cc: linux-kernel, torvalds, akpm

On Fri, Jan 23, 2004 at 06:35:25AM +0000, davej@redhat.com wrote:
> Yet another misplaced ! by the looks..
> 

Thanks Dave, your fix looks good to me too.  Marcelo, this affects
2.4 too - please apply this patch.

thanks.

> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/fs/xfs/xfs_log_recover.c linux-2.5/fs/xfs/xfs_log_recover.c
> --- bk-linus/fs/xfs/xfs_log_recover.c	2003-10-09 01:01:24.000000000 +0100
> +++ linux-2.5/fs/xfs/xfs_log_recover.c	2004-01-14 07:06:40.000000000 +0000
> @@ -1553,7 +1553,7 @@ xlog_recover_reorder_trans(
>  		case XFS_LI_BUF:
>  		case XFS_LI_6_1_BUF:
>  		case XFS_LI_5_3_BUF:
> -			if ((!flags & XFS_BLI_CANCEL)) {
> +			if (!(flags & XFS_BLI_CANCEL)) {
>  				xlog_recover_insert_item_frontq(&trans->r_itemq,
>  								itemq);
>  				break;

-- 
Nathan

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2004-01-24  0:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-23  6:35 logic error in XFS davej
2004-01-23  9:33 ` Måns Rullgård
     [not found]   ` <yw1xr7xr80wi.fsf@adic.com>
2004-01-23 15:55     ` Steve Lord
2004-01-24  0:41 ` Nathan Scott

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox