[PATCH] IBM PowerPC Virtual Ethernet Driver

[PATCH] IBM PowerPC Virtual Ethernet Driver

[Santiago Leon]

Here's a patch that adds the inter-partition Virtual Ethernet driver for 
newer IBM iSeries and pSeries systems:

http://www-124.ibm.com/linux/patches/ppc64/ibmveth.patch

The patch applies against the 2.4.25-pre6 tree...

Jeff, can you formally add this driver to 2.4?... I'm waiting for some
ppc64 architectural addition to send out the driver for 2.6...

Comments and suggestions are always welcome...
-- 
Santiago A. Leon
Power Linux Development
IBM Linux Technology Center

Re: [PATCH] IBM PowerPC Virtual Ethernet Driver

[Christoph Hellwig]

On Mon, Jan 19, 2004 at 03:24:10PM -0500, Santiago Leon wrote:
> Here's a patch that adds the inter-partition Virtual Ethernet driver for 
> newer IBM iSeries and pSeries systems:
> 
> http://www-124.ibm.com/linux/patches/ppc64/ibmveth.patch
> 
> The patch applies against the 2.4.25-pre6 tree...

Usually patches are subitted inline to ease review..

> Jeff, can you formally add this driver to 2.4?... I'm waiting for some
> ppc64 architectural addition to send out the driver for 2.6...

I think we shouldn't accept new drivers in 2.4 anymore unless they're
already in 2.6

Re: [PATCH] IBM PowerPC Virtual Ethernet Driver

[Santiago Leon]

Christoph Hellwig wrote:

>>http://www-124.ibm.com/linux/patches/ppc64/ibmveth.patch
>>
>>The patch applies against the 2.4.25-pre6 tree...
> 
> 
> Usually patches are subitted inline to ease review..
> 

That was my original intention, however section 4, question 1 in the FAQ 
states:
"If your patch is on the large size (say larger than 500 lines) consider 
posting a URL pointing to the patch along with the patch description, 
instead of the whole patch."
This patch was 1300+ lines.

> I think we shouldn't accept new drivers in 2.4 anymore unless they're
> already in 2.6

Sure, it makes sense... I just wanted to get this driver out since the 
2.4 tree has some architectural features that 2.6 doesn't have yet... 
I'm not sure how those features made it to 2.4 before 2.6 though!...

-- 
Santiago A. Leon
Power Linux Development
IBM Linux Technology Center

Re: [PATCH] IBM PowerPC Virtual Ethernet Driver

[Jeff Garzik]

Christoph Hellwig wrote:
> On Mon, Jan 19, 2004 at 03:24:10PM -0500, Santiago Leon wrote:
>>Jeff, can you formally add this driver to 2.4?... I'm waiting for some
>>ppc64 architectural addition to send out the driver for 2.6...
> 
> 
> I think we shouldn't accept new drivers in 2.4 anymore unless they're
> already in 2.6


The architectural dependency is queued for 2.6 and in 2.4, so I'm OK 
with it.

	Jeff