From: Michael Veeck <michael.veeck@gmx.net>
To: owner-xfs@oss.sgi.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] XFS: remove warning in xfs_log_recover, 2.6.2-rc2
Date: Tue, 27 Jan 2004 15:09:30 +0100 [thread overview]
Message-ID: <4016711A.10004@gmx.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
Compiling the 2.6.2-rc2 kernel on my machine with allyesconfig and gcc
3.3.1 triggers the following warning:
CC fs/xfs/xfs_log_recover.o
fs/xfs/xfs_log_recover.c: In function `xlog_recover_reorder_trans':
fs/xfs/xfs_log_recover.c:1534: warning: `flags' might be used
uninitialized in this function
I've added an "= 0" to the appropiate line which lets it cleanly compile
now. Attached patch fixes the warning and is against 2.6.2-rc2. Apply
with patch -p1 < patch-XFSwarning.
Best regards
Michael Veeck
[-- Attachment #2: patch-XFSwarning --]
[-- Type: text/plain, Size: 453 bytes --]
diff -Naur a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
--- old/fs/xfs/xfs_log_recover.c 2004-01-27 14:28:03.000000000 +0100
+++ new/fs/xfs/xfs_log_recover.c 2004-01-27 14:02:25.000000000 +0100
@@ -1531,7 +1531,7 @@
xlog_recover_item_t *first_item, *itemq, *itemq_next;
xfs_buf_log_format_t *buf_f;
xfs_buf_log_format_v1_t *obuf_f;
- ushort flags;
+ ushort flags = 0;
first_item = itemq = trans->r_itemq;
trans->r_itemq = NULL;
[-- Attachment #3: README --]
[-- Type: text/plain, Size: 106 bytes --]
[PATCH] xfs has uninitialized flags-variable in xfs_log_recover. init it to 0. from michael.veeck@gmx.net
reply other threads:[~2004-01-27 14:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4016711A.10004@gmx.net \
--to=michael.veeck@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=owner-xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox