* [PATCH] XFS: remove warning in xfs_log_recover, 2.6.2-rc2
@ 2004-01-27 14:09 Michael Veeck
0 siblings, 0 replies; only message in thread
From: Michael Veeck @ 2004-01-27 14:09 UTC (permalink / raw)
To: owner-xfs; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
Compiling the 2.6.2-rc2 kernel on my machine with allyesconfig and gcc
3.3.1 triggers the following warning:
CC fs/xfs/xfs_log_recover.o
fs/xfs/xfs_log_recover.c: In function `xlog_recover_reorder_trans':
fs/xfs/xfs_log_recover.c:1534: warning: `flags' might be used
uninitialized in this function
I've added an "= 0" to the appropiate line which lets it cleanly compile
now. Attached patch fixes the warning and is against 2.6.2-rc2. Apply
with patch -p1 < patch-XFSwarning.
Best regards
Michael Veeck
[-- Attachment #2: patch-XFSwarning --]
[-- Type: text/plain, Size: 453 bytes --]
diff -Naur a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
--- old/fs/xfs/xfs_log_recover.c 2004-01-27 14:28:03.000000000 +0100
+++ new/fs/xfs/xfs_log_recover.c 2004-01-27 14:02:25.000000000 +0100
@@ -1531,7 +1531,7 @@
xlog_recover_item_t *first_item, *itemq, *itemq_next;
xfs_buf_log_format_t *buf_f;
xfs_buf_log_format_v1_t *obuf_f;
- ushort flags;
+ ushort flags = 0;
first_item = itemq = trans->r_itemq;
trans->r_itemq = NULL;
[-- Attachment #3: README --]
[-- Type: text/plain, Size: 106 bytes --]
[PATCH] xfs has uninitialized flags-variable in xfs_log_recover. init it to 0. from michael.veeck@gmx.net
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-01-27 14:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-27 14:09 [PATCH] XFS: remove warning in xfs_log_recover, 2.6.2-rc2 Michael Veeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox