public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: George Anzinger <george@mvista.com>
To: jim.houston@comcast.net
Cc: Andi Kleen <ak@suse.de>,
	akpm@osdl.org, amitkale@emsyssoft.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kgdb-x86_64-support.patch for 2.6.2-rc1-mm3
Date: Tue, 27 Jan 2004 12:37:48 -0800	[thread overview]
Message-ID: <4016CC1C.8020709@mvista.com> (raw)
In-Reply-To: <1075232116.1020.326.camel@new.localdomain>

Jim Houston wrote:
> On Tue, 2004-01-27 at 13:02, Andi Kleen wrote:
> 
>>On 27 Jan 2004 12:43:20 -0500
>>Jim Houston <jim.houston@comcast.net> wrote:
> 
> 
>>>arch/x86_64/Kconfig
>>>arch/x86_64/Kconfig.kgdb
>>>	We used a different approach to selecting DEBUG_INFO.
>>>	I was not really happy with the way select DEBUG_INFO worked.
>>
>>You reverted it back? 
>>
>>What I did was to change all not really kgdb specific CONFIG_KGDB uses in
>>the main kernel with CONFIG_DEBUG_INFO (mostly CFI support). I don't feel
>>strongly about it, but this way there is no reference to an unknown
>>config symbol in mainline. Also DEBUG_INFO including CFI makes sense I think.

If we are going to use DEBUG_INFO could we change the "-g" it produces to 
"-gdwarft-2", especially since you (and I) are using dwarft2 CFI stuff.

-g
> 
> 
> Hi Andi,
> 
> I'm using CONFIG_DEBUG_INFO, but I used a different mechanism to
> select it when KGDB is selected.  I'm still learning to speak Kconfig.
> 
> My patch:
> 
>    config KGDB
>         bool "Include kgdb kernel debugger"
>         depends on DEBUG_KERNEL
>         select DEBUG_INFO
>         help
>           If you say Y here, the system will be compiled with the debug
> 
> Your patch:
> 
>   config DEBUG_INFO
>         bool "Compile kernel with debug information" if !KGDB
>         default y
> 
> Using "select DEBUG_INFO" selects the option and makes the input box
> on xconfig disappear.  The line describing the option remains, perhaps
> leaving a user wondering why this line doesn't have an input box.
> 
> With your version, the DEBUG_INFO option disappears when KGDB forces
> it on.
> 
> I was looking for a way to get the old behavior where the 
> the effect was controlled by an OR of the two options.
> 
> Jim Houston - Concurrent Computer Corp.
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
George Anzinger   george@mvista.com
High-res-timers:  http://sourceforge.net/projects/high-res-timers/
Preemption patch: http://www.kernel.org/pub/linux/kernel/people/rml


  parent reply	other threads:[~2004-01-27 20:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20040127030529.8F860C60FC@h00e098094f32.ne.client2.attbi.com>
2004-01-27  3:28 ` [PATCH] kgdb-x86_64-support.patch for 2.6.2-rc1-mm3 Andrew Morton
2004-01-27 13:58   ` Jim Houston
2004-01-27 14:56 ` Andi Kleen
2004-01-27 17:43   ` Jim Houston
2004-01-27 18:02     ` Andi Kleen
2004-01-27 19:35       ` Jim Houston
2004-01-27 19:43         ` Andi Kleen
2004-01-27 20:37         ` George Anzinger [this message]
2004-01-27 20:54           ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4016CC1C.8020709@mvista.com \
    --to=george@mvista.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=amitkale@emsyssoft.com \
    --cc=jim.houston@comcast.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox