From: Valdis.Kletnieks@vt.edu
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
Hugh Dickins <hughd@google.com>,
akpm@linux-foundation.org, Sabrina Dubroca <sd@queasysnail.net>,
Vincent Donnefort <vdonnefort@gmail.com>,
Bryan Wu <cooloney@gmail.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH][input-led] Defer input led work to workqueue
Date: Tue, 26 Aug 2014 14:51:10 -0400 [thread overview]
Message-ID: <4017.1409079070@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Tue, 26 Aug 2014 10:01:35 +0200." <1409040095.2489.3.camel@jlt4.sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 484 bytes --]
On Tue, 26 Aug 2014 10:01:35 +0200, Johannes Berg said:
> On Tue, 2014-08-26 at 03:54 +0200, Samuel Thibault wrote:
>
> > + vt_led_wq = alloc_workqueue("input_leds", WQ_UNBOUND, 0);
> > + if (!vt_led_wq)
> > + return -ENOMEM;
>
> Does this really need a separate workqueue rather than just using
> schedule_work()? There doesn't seem to be much point in having its own
> workqueue really, to me.
As I noted in another email, the patch works. Whether it's *correct* I can't
tell. :)
[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]
next prev parent reply other threads:[~2014-08-26 18:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 1:54 [PATCH][input-led] Defer input led work to workqueue Samuel Thibault
2014-08-26 8:01 ` Johannes Berg
2014-08-26 9:13 ` Samuel Thibault
2014-08-26 18:51 ` Valdis.Kletnieks [this message]
2014-08-26 9:17 ` [PATCHv2][input-led] " Samuel Thibault
2014-08-26 13:22 ` Johannes Berg
2014-08-26 13:24 ` Samuel Thibault
2014-08-26 13:32 ` Samuel Thibault
2014-08-26 20:41 ` Valdis.Kletnieks
2014-08-26 18:49 ` [PATCH][input-led] " Valdis.Kletnieks
2014-08-26 20:02 ` Sabrina Dubroca
2014-08-26 21:55 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4017.1409079070@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=cooloney@gmail.com \
--cc=hughd@google.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=sd@queasysnail.net \
--cc=vdonnefort@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox