From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754069AbcC3NyD (ORCPT ); Wed, 30 Mar 2016 09:54:03 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:60718 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751805AbcC3NyB (ORCPT ); Wed, 30 Mar 2016 09:54:01 -0400 From: Arnd Bergmann To: Felipe Balbi Cc: Greg Kroah-Hartman , Bin Liu , Peter Chen , Kishon Vijay Abraham I , Peter Chen , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: rework CONFIG_USB_COMMON logic Date: Wed, 30 Mar 2016 15:53:45 +0200 Message-ID: <4019862.J6BPYbmbYs@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <871t6sqmu2.fsf@intel.com> References: <1458751543-2167046-1-git-send-email-arnd@arndb.de> <871t6sqmu2.fsf@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:5arbi3/j9HS2TrJz6nKqzLnKTxZV+nRU7XrF5IboRWF6rzUL8ou uq3nJbxPR6djkml4Vc05GJ6ilI9qkYhVfiZ8t04XjAhZEWU4+OlwYZA/WGTwxIPYORzUJpz 1Ut6mQ3EufACbWkVF38eKeDNHb/5fUCx4QMDmQGRGwBzMtRh+O4XpSzNq3ApjwB6A/WVvrU DJDl85tW1fgii8VXYU+jw== X-UI-Out-Filterresults: notjunk:1;V01:K0:LOcGwgGDxUI=:zxgUQ2ANkIOx7o/LesMHf3 8Ib1Hn4/E9PS0TPVqWcP/SxdR/6CpduRsdoAABJZWuwuKKUobn1GX9SfiVNhpWIVbuKu0O0Km TFJDJeLMzyuKKOmC/d1TjNj14gWQyfnpBapov6DsKGYQaWIMzsI0CSXDAwqG5NSAAAtXmofCM zlIctQkSlyUQKNEySdvej7c9JDAREvPfbZHlUKy+fbaZtejJRICkVERx3bHYQlmr4+DOVWaiA sFDY8YfIf1TxlacOd+bCzZtGTOP3mlkKZfF/2xoF+eUyPRkcMRIoPnquAPjFxIHBOVDIx+8hU tf8AGRr8yZyjBOILQmSO60+BVzfwP146JmdDOOTo87jgS0VOiFcqIgIi9Uz+WqnQ2mYqvpmZq /pP4he1nmfvwDFEzrmCq71sD9caNBRaWOnoNe4Phsrrofj3ETasBkp1OA+IP77aEGifdef0gh JzJNILubWrguuThWSQugYiivit9Q+9UWnwTLEoB2yBqEfbNYD3nPZNwOZW64A7XS4KDozvoSH NDr0262+wu6KVXuNrJJn/oehXMHfSaNQeHPa8QBXlzksacHS/HqYyto2BlyyeA9RGIcAdsY2c 6fxpIW4elkACtDi/uPUVHFmH/Gt2ln0kxEzNvBfUxbggxNHgGuV/BbJ1PZZHPgkMI3gveeI4q n3djkyxpHGLC+DY+pbIOwnVE8iAlJjyN1Bbco+4HNbZuOC8+n+QvUpwmLXx3xTQowDfuvgzVK b//XQTdnglGvIkGV Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 30 March 2016 13:31:01 Felipe Balbi wrote: > Arnd Bergmann writes: > > [ text/plain ] > > The phy-am335x driver selects 'USB_COMMON', but all other drivers > > use 'depends on' for that symbol, and it depends on USB || USB_GADGET > > itself, which causes a Kconfig warning: > > > > warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET)) > > > > As suggested by Felipe Balbi, this turns the logic around, and makes > > 'USB_COMMON' selected by everything else that needs it, so we can > > remove the dependencies. > > > > Fixes: 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing for host-only mode") > > Signed-off-by: Arnd Bergmann > > Acked-by: Felipe Balbi > > Reviewed-by: Peter Chen > > --- > > I seem to have dropped the ball on this one after my initial submission > > when it wasn't clear who should merge the patch. > > > > Please apply to the USB or the USB gadget tree, whoever gets there > > first. > > seems like this is one of those "can wait for next merge window" right ? > I'll take it through my tree. No issues. Correct, it's not urgent at all, I just want it to disappear from my backlog of unapplied patches. Arnd