Re: [Compile Regression in 2.4.25-pre8][PATCH 15/42]

Marcelo Tosatti
2004-02-04T16:55:25Z

On Mon, 2 Feb 2004, Kronos wrote:

>
> ../fdomain.c:565: warning: `fdomain_setup' defined but not used
>
> fdomain_setup isn't used when the driver is modular.
>
> diff -Nru -X dontdiff linux-2.4-vanilla/drivers/scsi/fdomain.c linux-2.4/drivers/scsi/fdomain.c
> --- linux-2.4-vanilla/drivers/scsi/fdomain.c Sat Jan 31 15:54:42 2004
> +++ linux-2.4/drivers/scsi/fdomain.c Sat Jan 31 17:21:13 2004
> @@ -561,6 +561,7 @@
> printk( "\n" );
> }
>
> +#ifndef MODULE
> static int __init fdomain_setup( char *str )
> {
> int ints[4];
> @@ -584,6 +585,7 @@
> }
>
> __setup("fdomain=", fdomain_setup);
> +#endif
>
>
> static void do_pause( unsigned amount ) /* Pause for amount*10 milliseconds */

What?

from fdomain.c:

#ifdef MODULE
if (fdomain)
fdomain_setup(fdomain);
#endif