Re: [Compile Regression in 2.4.25-pre8][PATCH 11/42]

Richard B. Johnson
2004-02-02T21:23:22Z

On Mon, 2 Feb 2004, Kronos wrote:

>
> include/asm/smpboot.h:126: warning: deprecated use of label at end of compound statement
>
> Move the return statement under 'default' label to suppress the warning.
>
> diff -Nru -X dontdiff linux-2.4-vanilla/include/asm-i386/smpboot.h linux-2.4/include/asm-i386/smpboot.h
> --- linux-2.4-vanilla/include/asm-i386/smpboot.h Tue Nov 11 17:51:14 2003
> +++ linux-2.4/include/asm-i386/smpboot.h Sat Jan 31 17:10:50 2004
> @@ -123,8 +123,8 @@
> cpu = (cpu+1)%smp_num_cpus;
> return cpu_to_physical_apicid(cpu);
> default:
> + return cpu_online_map;
> }
> - return cpu_online_map;
> }
> #else
> #define target_cpus() (cpu_online_map)
>

Not correct. This removes the main-line return of a value.
You just need a ';' after the default to suppress the error
(or a break; ). Neither will make any additional code.

Cheers,
Dick Johnson
Penguin : Linux version 2.4.24 on an i686 machine (797.90 BogoMips).
Note 96.31% of all statistics are fiction.